From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan de Oliveira Subject: Re: [PATCH 6/7] drm/i915: Improve how the memory for crtc state is allocated Date: Fri, 16 Jan 2015 10:50:43 +0200 Message-ID: <54B8D0E3.7040605@gmail.com> References: <1421326527-24906-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1421326527-24906-7-git-send-email-ander.conselvan.de.oliveira@intel.com> <20150115185040.GF22549@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 6853D6E039 for ; Fri, 16 Jan 2015 00:51:00 -0800 (PST) Received: by mail-wi0-f172.google.com with SMTP id bs8so2466839wib.5 for ; Fri, 16 Jan 2015 00:50:59 -0800 (PST) In-Reply-To: <20150115185040.GF22549@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDEvMTUvMjAxNSAwODo1MCBQTSwgTWF0dCBSb3BlciB3cm90ZToKPiBPbiBUaHUsIEphbiAx NSwgMjAxNSBhdCAwMjo1NToyNlBNICswMjAwLCBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEg d3JvdGU6Cj4+IFRoZSBwcmV2aW91cyBwYXRjaCBjaGFuZ2VkIHRoZSBjb25maWcgZmllbGQgaW4g aW50ZWxfY3J0YyB0byBhIHBvaW50ZXIsCj4+IGJ1dCB0byBrZWVwIHRoZSBtZWNoYW5pY2FsIGNo YW5nZXMgKGRvbmUgd2l0aCBzcGF0Y2gpIHNlcGFyYXRlIGZyb20gdGhlCj4+IG5ldyBjb2RlLCB0 aGUgcG9pbnRlciB3YXMgbWFkZSB0byBwb2ludCB0byBhIG5ldyBfY29uZmlnIGZpZWxkIHdpdGgg dHlwZQo+PiBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSBhZGRlZCB0byB0aGF0IHN0cnVjdC4gVGhp cyBwYXRjaCBpbXByb3ZlcyB0aGF0Cj4+IGNvZGUgYnkgZ2V0dGluZyByaWQgb2YgdGhhdCBmaWVs ZCwgYWxsb2NhdGluZyBhIHN0YXRlIHN0cnVjdCBpbgo+PiBpbnRlbF9jcnRjX2luaXQoKSBhIGtl ZXBpbmcgaXQgcHJvcGVybHkgdXBkYXRlZCB3aGVuIGEgbW9kZSBzZXQKPj4gaGFwcGVucy4KPj4K Pj4gdjI6IE1hbnVhbCBjaGFuZ2VzIHNwbGl0IGZyb20gcHJldmlvdXMgcGF0Y2guIChNYXR0KQo+ PiAgICAgIERvbid0IGxlYWsgdGhlIGN1cnJlbnQgc3RhdGUgd2hlbiB0aGUgY3J0YyBpcyBkZXN0 cm95ZWQgKE1hdHQpCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2 ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPgo+IEkgZG9uJ3Qg c2VlIGEgbmVlZCB0byBrZWVwIHBhdGNoICM3IHNlcGFyYXRlIGZyb20gdGhlIGNoYW5nZXMgeW91 J3JlCj4gbWFraW5nIGhlcmU7IEknZCBnbyBhaGVhZCBhbmQganVzdCBzcXVhc2ggaXQgaW50byB0 aGlzIHBhdGNoIHNpbmNlIGl0J3MKPiBhIHRyaXZpYWwgY2hhbmdlLgo+Cj4gQWx0aG91Z2ggNis3 IGxvb2sgb2theSwgSSBkbyBxdWVzdGlvbiB3aGV0aGVyIHdlIHJlYWxseSB3YW50IHRvIGtlZXAK PiBpbnRlbF9jcnRjLT5jb25maWcgbm93IHRoYXQgb3VyIGludGVsIGNydGMgc3RhdGUgaXMgYSBz dWJjbGFzcyBvZiB0aGUKPiBEUk0gc3RhdGUgb2JqZWN0IGFuZCBjYW4gYWx3YXlzIGJlIGFjY2Vz c2VkIHRocm91Z2ggb3VyIGJhc2UgcG9pbnRlci4KPiBGb3IgcGxhbmVzLCB3ZSBqdXN0IGdyYWIg dGhlIGJhc2Ugc3RhdGUgdGhyb3VnaCB0aGUKPiBvYmplY3QncyBiYXNlIHBvaW50ZXIsIHRoZW4g Y2FzdCB0aGF0IHRvIHRoZSBpOTE1LXNwZWNpZmljIHN0YXRlIG9iamVjdDsKPiBpLmUuLAo+Cj4g ICAgICAgICAgZm9vID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoaW50ZWxfcGxhbmUtPmJhc2Uuc3Rh dGUpOwo+Cj4gTXkgaW5jbGluYXRpb24gd291bGQgYmUgdG8gaGFuZGxlIGNydGMncyB0aGUgc2Ft ZSB3YXkgZm9yIGNvbnNpc3RlbmN5Cj4gYW5kIHNvIHRoYXQgd2UgZG9uJ3QgaGF2ZSB0d28gcG9p bnRlcnMgcGVyIG9iamVjdCAob25lIGJhc2UsIG9uZQo+IGk5MTUtc3BlY2lmaWMpIHRoYXQgYXJl IGVzc2VudGlhbGx5IHBvaW50aW5nIGF0IHRoZSBzYW1lIHRoaW5nIGFuZCBoYXZlCj4gdG8gYmUg a2VwdCBpbiBzeW5jLgoKRGFuaWVsIHdhcyBhbnRpY2lwYXRpbmcgd2Ugd291bGQgc3RpbGwgbmVl ZCAtPmNvbmZpZyBhbmQgLT5uZXdfY29uZmlnLiAKRm9yIGFzeW5jIHVwZGF0ZXMsIHdlIHdvdWxk IGNvbW1pdCBkcm1fY3J0Yy0+c3RhdGUgYmVmb3JlIGl0IGlzIHdyaXR0ZW4gCnRvIHRoZSBoYXJk d2FyZS4gSW4gdGhhdCBjYXNlLCB0aGUgaGFyZHdhcmUgY3VycmVudCBzdGF0ZSB3b3VsZCBzdGls bCBiZSAKaW4gaW50ZWxfY3J0Yy0+Y29uZmlnIGFuZCBkcm1fY3J0Yy0+c3RhdGUgd291bGQgYWN0 dWFsbHkgbWF0Y2ggCi0+bmV3X2NvbmZpZy4gV2UnbGwgaGF2ZSB0byBzb3J0IHRoaXMgb3V0IGxh dGVyLCBzbyBJIGp1c3QgYXZvaWRlZCBkb2luZyAKdG9vIG1hbnkgY2hhbmdlcy4KCkFuZGVyCgo+ IEFueXdheSwgeW91IGNhbiBjb25zaWRlciB0aGlzIGVudGlyZSBzZXJpZXMKPgo+ICAgICAgUmV2 aWV3ZWQtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4KPiB3aGV0 aGVyIG9yIG5vdCB5b3UgZGVjaWRlIHRvIG1ha2UgZnVydGhlciB1cGRhdGVzIHRvIDYrNy4gIFRo ZSB1c2Ugb2YKPiBDb2NjaW5lbGxlIHRvIGF1dG8tZ2VuZXJhdGUgbW9zdCBvZiB0aGVzZSBwYXRj aGVzIHdhcyBncmVhdCBhbmQgbWFkZSB0aGUKPiBzZXJpZXMgdmVyeSBlYXN5IHRvIHJldmlldy4K Pgo+Cj4gTWF0dAo+Cj4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgMjAgKysrKysrKysrKysrKysrKy0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaCAgICAgfCAgMSAtCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRp b25zKCspLCA1IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4+IGluZGV4IGFjZGFlZDIuLjAwMmU1YTkgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPj4gQEAgLTg5MjYsNiArODkyNiwxMyBAQCBvdXQ6Cj4+ICAgCWludGVs X3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPj4gICB9Cj4+Cj4+ICtzdGF0aWMgdm9pZCBpbnRl bF9jcnRjX3NldF9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gKwkJCQkgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4+ICt7Cj4+ICsJa2ZyZWUoY3J0Yy0+Y29u ZmlnKTsKPj4gKwljcnRjLT5jb25maWcgPSBjcnRjX3N0YXRlOwo+PiArfQo+PiArCj4+ICAgc3Rh dGljIHZvaWQgaW50ZWxfY3J0Y19kZXN0cm95KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4gICB7 Cj4+ICAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRj KTsKPj4gQEAgLTg5NDQsNiArODk1MSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2NydGNfZGVzdHJv eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4+Cj4+ICAgCWRybV9jcnRjX2NsZWFudXAoY3J0Yyk7 Cj4+Cj4+ICsJaW50ZWxfY3J0Y19zZXRfc3RhdGUoaW50ZWxfY3J0YywgTlVMTCk7Cj4+ICAgCWtm cmVlKGludGVsX2NydGMpOwo+PiAgIH0KPj4KPj4gQEAgLTEwOTk1LDggKzExMDAzLDcgQEAgc3Rh dGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gICAJCWNy dGMtPm1vZGUgPSAqbW9kZTsKPj4gICAJCS8qIG1vZGVfc2V0L2VuYWJsZS9kaXNhYmxlIGZ1bmN0 aW9ucyByZWx5IG9uIGEgY29ycmVjdCBwaXBlCj4+ICAgCQkgKiBjb25maWcuICovCj4+IC0JCSgq KHRvX2ludGVsX2NydGMoY3J0YyktPmNvbmZpZykpID0gKnBpcGVfY29uZmlnOwo+PiAtCQl0b19p bnRlbF9jcnRjKGNydGMpLT5uZXdfY29uZmlnID0gdG9faW50ZWxfY3J0YyhjcnRjKS0+Y29uZmln Owo+PiArCQlpbnRlbF9jcnRjX3NldF9zdGF0ZSh0b19pbnRlbF9jcnRjKGNydGMpLCBwaXBlX2Nv bmZpZyk7Cj4+Cj4+ICAgCQkvKgo+PiAgIAkJICogQ2FsY3VsYXRlIGFuZCBzdG9yZSB2YXJpb3Vz IGNvbnN0YW50cyB3aGljaAo+PiBAQCAtMTEwNDAsNyArMTEwNDcsNiBAQCBkb25lOgo+PiAgIAlp ZiAocmV0ICYmIGNydGMtPmVuYWJsZWQpCj4+ICAgCQljcnRjLT5tb2RlID0gKnNhdmVkX21vZGU7 Cj4+Cj4+IC0Ja2ZyZWUocGlwZV9jb25maWcpOwo+PiAgIAlrZnJlZShzYXZlZF9tb2RlKTsKPj4g ICAJcmV0dXJuIHJldDsKPj4gICB9Cj4+IEBAIC0xMjE4Nyw2ICsxMjE5Myw3IEBAIHN0YXRpYyB2 b2lkIGludGVsX2NydGNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgcGlwZSkKPj4g ICB7Cj4+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3By aXZhdGU7Cj4+ICAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjOwo+PiArCXN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0gTlVMTDsKPj4gICAJc3RydWN0IGRybV9wbGFu ZSAqcHJpbWFyeSA9IE5VTEw7Cj4+ICAgCXN0cnVjdCBkcm1fcGxhbmUgKmN1cnNvciA9IE5VTEw7 Cj4+ICAgCWludCBpLCByZXQ7Cj4+IEBAIC0xMjE5NSw2ICsxMjIwMiwxMSBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9jcnRjX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUpCj4+ICAg CWlmIChpbnRlbF9jcnRjID09IE5VTEwpCj4+ICAgCQlyZXR1cm47Cj4+Cj4+ICsJY3J0Y19zdGF0 ZSA9IGt6YWxsb2Moc2l6ZW9mKCpjcnRjX3N0YXRlKSwgR0ZQX0tFUk5FTCk7Cj4+ICsJaWYgKCFj cnRjX3N0YXRlKQo+PiArCQlnb3RvIGZhaWw7Cj4+ICsJaW50ZWxfY3J0Y19zZXRfc3RhdGUoaW50 ZWxfY3J0YywgY3J0Y19zdGF0ZSk7Cj4+ICsKPj4gICAJcHJpbWFyeSA9IGludGVsX3ByaW1hcnlf cGxhbmVfY3JlYXRlKGRldiwgcGlwZSk7Cj4+ICAgCWlmICghcHJpbWFyeSkKPj4gICAJCWdvdG8g ZmFpbDsKPj4gQEAgLTEyMjQwLDcgKzEyMjUyLDYgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19p bml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBwaXBlKQo+PiAgIAlkcm1fY3J0Y19oZWxw ZXJfYWRkKCZpbnRlbF9jcnRjLT5iYXNlLCAmaW50ZWxfaGVscGVyX2Z1bmNzKTsKPj4KPj4gICAJ V0FSTl9PTihkcm1fY3J0Y19pbmRleCgmaW50ZWxfY3J0Yy0+YmFzZSkgIT0gaW50ZWxfY3J0Yy0+ cGlwZSk7Cj4+IC0JaW50ZWxfY3J0Yy0+Y29uZmlnID0gJmludGVsX2NydGMtPl9jb25maWc7Cj4+ ICAgCXJldHVybjsKPj4KPj4gICBmYWlsOgo+PiBAQCAtMTIyNDgsNiArMTIyNTksNyBAQCBmYWls Ogo+PiAgIAkJZHJtX3BsYW5lX2NsZWFudXAocHJpbWFyeSk7Cj4+ICAgCWlmIChjdXJzb3IpCj4+ ICAgCQlkcm1fcGxhbmVfY2xlYW51cChjdXJzb3IpOwo+PiArCWtmcmVlKGNydGNfc3RhdGUpOwo+ PiAgIAlrZnJlZShpbnRlbF9jcnRjKTsKPj4gICB9Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oCj4+IGluZGV4IDBiNTlhOTMuLmM4YzBiN2YgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4+IEBAIC00NjksNyArNDY5LDYgQEAgc3RydWN0IGludGVsX2NydGMgewo+PiAgIAl1 aW50MzJfdCBjdXJzb3JfYmFzZTsKPj4KPj4gICAJc3RydWN0IGludGVsX3BsYW5lX2NvbmZpZyBw bGFuZV9jb25maWc7Cj4+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgX2NvbmZpZzsKPj4gICAJ c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNvbmZpZzsKPj4gICAJc3RydWN0IGludGVsX2NydGNf c3RhdGUgKm5ld19jb25maWc7Cj4+ICAgCWJvb2wgbmV3X2VuYWJsZWQ7Cj4+IC0tCj4+IDEuOS4x Cj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==