From: Deepak S <deepak.s@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/7] drm/i915: Drop VLV checks from rc6p and rc6pp sysfs files
Date: Tue, 20 Jan 2015 08:51:18 +0530 [thread overview]
Message-ID: <54BDC9AE.8050406@linux.intel.com> (raw)
In-Reply-To: <1421668253-18641-6-git-send-email-ville.syrjala@linux.intel.com>
On Monday 19 January 2015 05:20 PM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't register the rc6p and rc6pp sysfs files on VLV, so there's no
> point in having any VLV checks in them. Drop the checks.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 4a5af69..04174f0 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -116,8 +116,6 @@ show_rc6p_ms(struct device *kdev, struct device_attribute *attr, char *buf)
> {
> struct drm_minor *dminor = dev_to_drm_minor(kdev);
> u32 rc6p_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6p);
> - if (IS_VALLEYVIEW(dminor->dev))
> - rc6p_residency = 0;
> return snprintf(buf, PAGE_SIZE, "%u\n", rc6p_residency);
> }
>
> @@ -126,8 +124,6 @@ show_rc6pp_ms(struct device *kdev, struct device_attribute *attr, char *buf)
> {
> struct drm_minor *dminor = dev_to_drm_minor(kdev);
> u32 rc6pp_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6pp);
> - if (IS_VALLEYVIEW(dminor->dev))
> - rc6pp_residency = 0;
> return snprintf(buf, PAGE_SIZE, "%u\n", rc6pp_residency);
> }
>
Reviewed-by: Deepak S<deepak.s@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-20 3:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 11:50 [PATCH 0/7] drm/i915: CHV RC6/turbo fixes and improvements ville.syrjala
2015-01-19 11:50 ` [PATCH 1/7] drm/i915: Disable RC6 before configuring in on VLV/CHV ville.syrjala
2015-01-19 12:23 ` Chris Wilson
2015-01-20 3:17 ` Deepak S
2015-01-19 11:50 ` [PATCH 2/7] drm/i915: Change VLV GEN6_RP_DOWN_TIMEOUT value to decimal ville.syrjala
2015-01-19 12:23 ` Chris Wilson
2015-01-20 3:19 ` Deepak S
2015-01-19 11:50 ` [PATCH 3/7] drm/i915: Configure GEN6_RP_DOWN_TIMEOUT on CHV ville.syrjala
2015-01-20 3:15 ` Deepak S
2015-01-20 9:28 ` Ville Syrjälä
2015-01-19 11:50 ` [PATCH 4/7] Revert "Revert "drm/i915/chv: Use timeout mode for RC6 on chv"" ville.syrjala
2015-01-20 3:20 ` Deepak S
2015-01-19 11:50 ` [PATCH 5/7] drm/i915: Drop VLV checks from rc6p and rc6pp sysfs files ville.syrjala
2015-01-19 12:16 ` Chris Wilson
2015-01-20 3:21 ` Deepak S [this message]
2015-01-19 11:50 ` [PATCH 6/7] drm/i915: Rename 'reg' to 'clk_reg' to unconfuse it from the other 'reg' ville.syrjala
2015-01-19 12:17 ` Chris Wilson
2015-01-19 12:24 ` Chris Wilson
2015-01-20 3:22 ` Deepak S
2015-01-19 11:50 ` [PATCH 7/7] drm/i915: Add media rc6 residency file to sysfs ville.syrjala
2015-01-19 12:27 ` Chris Wilson
2015-01-19 19:16 ` shuang.he
2015-01-20 3:24 ` Deepak S
2015-01-20 8:50 ` Daniel Vetter
2015-01-20 9:30 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BDC9AE.8050406@linux.intel.com \
--to=deepak.s@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox