From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramalingam C Subject: Re: [PATCH 9/10] drm/i915: Add debugfs entry for DRRS Date: Wed, 21 Jan 2015 17:56:52 +0530 Message-ID: <54BF9B0C.8000803@intel.com> References: <1420836965-10068-1-git-send-email-vandana.kannan@intel.com> <1420836965-10068-10-git-send-email-vandana.kannan@intel.com> <20150111124054.GA27134@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0298950762==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EFCA6E0D8 for ; Wed, 21 Jan 2015 04:31:17 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , Chris Wilson , Vandana Kannan , intel-gfx , Paulo Zanoni , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0298950762== Content-Type: multipart/alternative; boundary="------------080001070001090903000307" This is a multi-part message in MIME format. --------------080001070001090903000307 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi On Friday 16 January 2015 04:48 AM, Rodrigo Vivi wrote: > On Sun, Jan 11, 2015 at 4:40 AM, Chris Wilson wrote: >> On Sat, Jan 10, 2015 at 02:26:04AM +0530, Vandana Kannan wrote: >>> Adding a debugfs entry to determine if DRRS is supported or not >>> >>> Signed-off-by: Vandana Kannan >>> --- >>> drivers/gpu/drm/i915/i915_debugfs.c | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c >>> index e515aad..544b4c3 100644 >>> --- a/drivers/gpu/drm/i915/i915_debugfs.c >>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c >>> @@ -2825,6 +2825,23 @@ static int i915_ddb_info(struct seq_file *m, void *unused) >>> return 0; >>> } >>> >>> +static int i915_drrs_status(struct seq_file *m, void *unused) >>> +{ >>> + struct drm_info_node *node = m->private; >>> + struct drm_device *dev = node->minor->dev; >>> + struct intel_crtc *crtc; >>> + >>> + for_each_intel_crtc(dev, crtc) { >>> + if (crtc->active) { >> Don't you want to know which CRTC this is? Would this not be better >> extending display_info with the extra CRTC status? >> >>> + if (crtc->config.has_drrs) > Also it just shows if panel supports drrs, not if it is enabled... Yes. We need to provide information on the platform's DRRS capability, crtc and the current DRRS state (LOW_RR/HIGH_RR). I am working on the same. > >>> + seq_puts(m, "DRRS enabled"); >>> + else >>> + seq_puts(m, "DRRS disabled"); >>> + } >>> + } >> -Chris >> >> -- >> Chris Wilson, Intel Open Source Technology Centre >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > --Ram --------------080001070001090903000307 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit Hi

On Friday 16 January 2015 04:48 AM, Rodrigo Vivi wrote:
On Sun, Jan 11, 2015 at 4:40 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:

On Sat, Jan 10, 2015 at 02:26:04AM +0530, Vandana Kannan wrote:

Adding a debugfs entry to determine if DRRS is supported or not

Signed-off-by: Vandana Kannan <vandana.kannan@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index e515aad..544b4c3 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2825,6 +2825,23 @@ static int i915_ddb_info(struct seq_file *m, void *unused)
      return 0;
 }

+static int i915_drrs_status(struct seq_file *m, void *unused)
+{
+     struct drm_info_node *node = m->private;
+     struct drm_device *dev = node->minor->dev;
+     struct intel_crtc *crtc;
+
+     for_each_intel_crtc(dev, crtc) {
+             if (crtc->active) {

Don't you want to know which CRTC this is? Would this not be better
extending display_info with the extra CRTC status?


+                     if (crtc->config.has_drrs)

Also it just shows if panel supports drrs, not if it is enabled...
Yes. We need to provide information on the platform's DRRS capability, crtc
and the current DRRS state (LOW_RR/HIGH_RR). I am working on the same. 


+                             seq_puts(m, "DRRS enabled");
+                     else
+                             seq_puts(m, "DRRS disabled");
+             }
+     }

-Chris

--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--Ram
--------------080001070001090903000307-- --===============0298950762== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0298950762==--