From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan de Oliveira Subject: Re: [PATCH 09/10] drm/i915: Switch plane properties to full atomic helper. Date: Thu, 22 Jan 2015 19:16:12 +0200 Message-ID: <54C1305C.701@gmail.com> References: <1421886949-26704-1-git-send-email-matthew.d.roper@intel.com> <1421886949-26704-10-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by gabe.freedesktop.org (Postfix) with ESMTP id B590A6E380 for ; Thu, 22 Jan 2015 09:16:15 -0800 (PST) Received: by mail-we0-f179.google.com with SMTP id q59so3020601wes.10 for ; Thu, 22 Jan 2015 09:16:15 -0800 (PST) In-Reply-To: <1421886949-26704-10-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UmV2aWV3ZWQtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8Y29uc2VsdmFuMkBnbWFp bC5jb20+CgpPbiAwMS8yMi8yMDE1IDAyOjM1IEFNLCBNYXR0IFJvcGVyIHdyb3RlOgo+IFRoaXMg d2lsbCBleGVyY2lzZSBvdXIgYXRvbWljIHBpcGVsaW5lIGZvciBsZWdhY3kgcHJvcGVydHkgdXBk YXRlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRl bC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUu YyB8ICA5ICsrKysrKysrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j ICAgICAgfCAgMyArKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jICAg ICAgIHwgMjYgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwg MTEgaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+IGluZGV4IDRhMzkxNGYuLjllNmY3MjcgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+IEBAIC0xMTgsNiArMTE4 LDE1IEBAIHN0YXRpYyBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lLAo+ICAgCWludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+Cj4gICAJ LyoKPiArCSAqIEJvdGggY3J0YyBhbmQgcGxhbmUtPmNydGMgY291bGQgYmUgTlVMTCBpZiB3ZSdy ZSB1cGRhdGluZyBhCj4gKwkgKiBwcm9wZXJ0eSB3aGlsZSB0aGUgcGxhbmUgaXMgZGlzYWJsZWQu ICBXZSBkb24ndCBhY3R1YWxseSBoYXZlCj4gKwkgKiBhbnl0aGluZyBkcml2ZXItc3BlY2lmaWMg d2UgbmVlZCB0byB0ZXN0IGluIHRoYXQgY2FzZSwgc28KPiArCSAqIGp1c3QgcmV0dXJuIHN1Y2Nl c3MuCj4gKwkgKi8KPiArCWlmICghY3J0YykKPiArCQlyZXR1cm4gMDsKPiArCj4gKwkvKgo+ICAg CSAqIFRoZSBvcmlnaW5hbCBzcmMvZGVzdCBjb29yZGluYXRlcyBhcmUgc3RvcmVkIGluIHN0YXRl LT5iYXNlLCBidXQKPiAgIAkgKiB3ZSB3YW50IHRvIGtlZXAgYW5vdGhlciBjb3B5IGludGVybmFs IHRvIG91ciBkcml2ZXIgdGhhdCB3ZSBjYW4KPiAgIAkgKiBjbGlwL21vZGlmeSBvdXJzZWx2ZXMu Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGRiMjA3NzMuLjkwYjc4 OGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTM3LDYgKzM3 LDcgQEAKPiAgICNpbmNsdWRlIDxkcm0vaTkxNV9kcm0uaD4KPiAgICNpbmNsdWRlICJpOTE1X2Ry di5oIgo+ICAgI2luY2x1ZGUgImk5MTVfdHJhY2UuaCIKPiArI2luY2x1ZGUgPGRybS9kcm1fYXRv bWljX2hlbHBlci5oPgo+ICAgI2luY2x1ZGUgPGRybS9kcm1fZHBfaGVscGVyLmg+Cj4gICAjaW5j bHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ICAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVf aGVscGVyLmg+Cj4gQEAgLTEyMDU1LDcgKzEyMDU2LDcgQEAgY29uc3Qgc3RydWN0IGRybV9wbGFu ZV9mdW5jcyBpbnRlbF9wbGFuZV9mdW5jcyA9IHsKPiAgIAkudXBkYXRlX3BsYW5lID0gZHJtX3Bs YW5lX2hlbHBlcl91cGRhdGUsCj4gICAJLmRpc2FibGVfcGxhbmUgPSBkcm1fcGxhbmVfaGVscGVy X2Rpc2FibGUsCj4gICAJLmRlc3Ryb3kgPSBpbnRlbF9wbGFuZV9kZXN0cm95LAo+IC0JLnNldF9w cm9wZXJ0eSA9IGludGVsX3BsYW5lX3NldF9wcm9wZXJ0eSwKPiArCS5zZXRfcHJvcGVydHkgPSBk cm1fYXRvbWljX2hlbHBlcl9wbGFuZV9zZXRfcHJvcGVydHksCj4gICAJLmF0b21pY19nZXRfcHJv cGVydHkgPSBpbnRlbF9wbGFuZV9hdG9taWNfZ2V0X3Byb3BlcnR5LAo+ICAgCS5hdG9taWNfc2V0 X3Byb3BlcnR5ID0gaW50ZWxfcGxhbmVfYXRvbWljX3NldF9wcm9wZXJ0eSwKPiAgIAkuYXRvbWlj X2R1cGxpY2F0ZV9zdGF0ZSA9IGludGVsX3BsYW5lX2R1cGxpY2F0ZV9zdGF0ZSwKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IDUwNjgzZDQuLjBhNTJjNDQgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xMzYyLDMyICsxMzYyLDYgQEAgb3V0 X3VubG9jazoKPiAgIAlyZXR1cm4gcmV0Owo+ICAgfQo+Cj4gLWludCBpbnRlbF9wbGFuZV9zZXRf cHJvcGVydHkoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gLQkJCSAgICAgc3RydWN0IGRybV9w cm9wZXJ0eSAqcHJvcCwKPiAtCQkJICAgICB1aW50NjRfdCB2YWwpCj4gLXsKPiAtCXN0cnVjdCBk cm1fZGV2aWNlICpkZXYgPSBwbGFuZS0+ZGV2Owo+IC0JdWludDY0X3Qgb2xkX3ZhbDsKPiAtCWlu dCByZXQgPSAtRU5PRU5UOwo+IC0KPiAtCWlmIChwcm9wID09IGRldi0+bW9kZV9jb25maWcucm90 YXRpb25fcHJvcGVydHkpIHsKPiAtCQkvKiBleGFjdGx5IG9uZSByb3RhdGlvbiBhbmdsZSBwbGVh c2UgKi8KPiAtCQlpZiAoaHdlaWdodDMyKHZhbCAmIDB4ZikgIT0gMSkKPiAtCQkJcmV0dXJuIC1F SU5WQUw7Cj4gLQo+IC0JCWlmIChwbGFuZS0+c3RhdGUtPnJvdGF0aW9uID09IHZhbCkKPiAtCQkJ cmV0dXJuIDA7Cj4gLQo+IC0JCW9sZF92YWwgPSBwbGFuZS0+c3RhdGUtPnJvdGF0aW9uOwo+IC0J CXBsYW5lLT5zdGF0ZS0+cm90YXRpb24gPSB2YWw7Cj4gLQkJcmV0ID0gaW50ZWxfcGxhbmVfcmVz dG9yZShwbGFuZSk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcGxhbmUtPnN0YXRlLT5yb3RhdGlvbiA9 IG9sZF92YWw7Cj4gLQl9Cj4gLQo+IC0JcmV0dXJuIHJldDsKPiAtfQo+IC0KPiAgIGludCBpbnRl bF9wbGFuZV9yZXN0b3JlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lKQo+ICAgewo+ICAgCWlmICgh cGxhbmUtPmNydGMgfHwgIXBsYW5lLT5mYikKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK