From: Nick Hoath <nicholas.hoath@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests
Date: Fri, 30 Jan 2015 16:45:31 +0000 [thread overview]
Message-ID: <54CBB52B.5030703@intel.com> (raw)
In-Reply-To: <20150130163355.GI14009@phenom.ffwll.local>
On 30/01/2015 16:33, Daniel Vetter wrote:
> On Fri, Jan 30, 2015 at 11:01:30AM +0200, Mika Kuoppala wrote:
>> Nick Hoath <nicholas.hoath@intel.com> writes:
>>
>>> Remove request from list before unreferencing it, in case it's actually
>>> the only reference. (Found by Tvrtko Ursulin)
>>>
>>> Signed-off-by: Nick Hoath <nicholas.hoath@intel.com>
>
> Do we have a Bugzilla: or similar report? Also when fixing a regression
There's no bug report.
> please dig out the offending original commit from the history. Though in
> this case here I'm not sure whether it is one ...
I guess the closest thing to an offending commit is
6d3d8274bc45de4babb62d64562d92af984dd238 drm/i915: Subsume
intel_ctx_submit_request in to drm_i915_gem_request
>
> Please reply with this information so that I can amend the commit message.
>
>> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Queued for -next, thanks for the patch.
> -Daniel
>
Cheers,
Nick
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-30 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 16:55 [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests Nick Hoath
2015-01-30 9:01 ` Mika Kuoppala
2015-01-30 16:33 ` Daniel Vetter
2015-01-30 16:45 ` Nick Hoath [this message]
2015-01-30 18:37 ` Daniel Vetter
2015-01-31 22:42 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBB52B.5030703@intel.com \
--to=nicholas.hoath@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox