public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Nick Hoath <nicholas.hoath@intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 15/18] drm/i915/skl: Implement WaDisableHDCInvalidation
Date: Wed, 11 Feb 2015 15:39:58 +0000	[thread overview]
Message-ID: <54DB77CE.10208@intel.com> (raw)
In-Reply-To: <1423510402-12605-16-git-send-email-damien.lespiau@intel.com>

On 09/02/2015 19:33, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Reviewed-by: Nick Hoath <nicholas.hoath@intel.com>

> ---
>   drivers/gpu/drm/i915/i915_reg.h | 1 +
>   drivers/gpu/drm/i915/intel_pm.c | 6 ++++++
>   2 files changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 3ae7a09..b363c5e 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -140,6 +140,7 @@
>   #define GEN8_RING_PDP_LDW(ring, n)	((ring)->mmio_base+0x270 + (n) * 8)
>
>   #define GAM_ECOCHK			0x4090
> +#define   BDW_DISABLE_HDC_INVALIDATION	(1<<25)
>   #define   ECOCHK_SNB_BIT		(1<<10)
>   #define   HSW_ECOCHK_ARB_PRIO_SOL	(1<<6)
>   #define   ECOCHK_PPGTT_CACHE64B		(0x3<<3)
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index f53ef11..8f9149b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -81,6 +81,12 @@ static void skl_init_clock_gating(struct drm_device *dev)
>   			   GEN6_VFUNIT_CLOCK_GATE_DISABLE);
>   	}
>
> +	if (INTEL_REVID(dev) <= SKL_REVID_D0)
> +		/* WaDisableHDCInvalidation:skl */
> +		I915_WRITE(GAM_ECOCHK, I915_READ(GAM_ECOCHK) |
> +			   BDW_DISABLE_HDC_INVALIDATION);
> +
> +
>   	if (INTEL_REVID(dev) <= SKL_REVID_E0)
>   		/* WaDisableLSQCROPERFforOCL:skl */
>   		I915_WRITE(GEN8_L3SQCREG4, I915_READ(GEN8_L3SQCREG4) |
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-02-11 15:40 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 19:33 [PATCH 00/18] A few more workarounds Damien Lespiau
2015-02-09 19:33 ` [PATCH 01/18] drm/i915: Support not having an init clock gating function defined Damien Lespiau
2015-02-10  9:39   ` Daniel Vetter
2015-02-11 14:44   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 02/18] drm/i915/skl: Implement WaDisableHBR2 Damien Lespiau
2015-02-11 14:49   ` Nick Hoath
2015-02-11 17:43     ` [PATCH v2] " Damien Lespiau
2015-02-13  5:09       ` shuang.he
2015-03-12 18:18       ` Jesse Barnes
2015-03-12 18:36         ` Jani Nikula
2015-03-12 19:03           ` Jesse Barnes
2015-03-13  9:21             ` Daniel Vetter
2015-02-09 19:33 ` [PATCH 03/18] drm/i915/skl: Document the WM read latency W/A with its name Damien Lespiau
2015-02-11 14:51   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 04/18] drm/i915/skl: Provide a gen9 specific init_render_ring() Damien Lespiau
2015-02-11 14:52   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 05/18] drm/i915/skl: Make the init clock gating function skylake specific Damien Lespiau
2015-02-11 14:56   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 06/18] drm/i915/skl: Implement WaSetGAPSunitClckGateDisable Damien Lespiau
2015-02-11 14:56   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 07/18] drm/i915/skl: Implement WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken Damien Lespiau
2015-02-12 13:29   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 08/18] drm/i915/skl: Document that we implement WaRsClearFWBitsAtReset Damien Lespiau
2015-02-11 15:08   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 09/18] drm/i915/skl: Implement WaEnableLbsSlaRetryTimerDecrement Damien Lespiau
2015-02-12 15:09   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 10/18] drm/i915/skl: Implement WaDisableVFUnitClockGating Damien Lespiau
2015-02-11 15:21   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 11/18] drm/i915/skl: Introduce a SKL specific init_workarounds() Damien Lespiau
2015-02-11 15:24   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 12/18] drm/i915/skl: Implement WaDisablePowerCompilerClockGating Damien Lespiau
2015-02-11 15:29   ` Nick Hoath
2015-02-11 17:48     ` Damien Lespiau
2015-02-18  9:57       ` Nick Hoath
2015-02-23 16:31         ` Daniel Vetter
2015-02-09 19:33 ` [PATCH 13/18] drm/i915/skl: Implement WaDisablePartialResolveInVc Damien Lespiau
2015-02-11 15:31   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 14/18] drm/i915/skl: Implement WaDisableLSQCROPERFforOCL Damien Lespiau
2015-02-11 15:34   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 15/18] drm/i915/skl: Implement WaDisableHDCInvalidation Damien Lespiau
2015-02-11 15:39   ` Nick Hoath [this message]
2015-02-09 19:33 ` [PATCH 16/18] drm/i915/skl: Implement WaDisableChickenBitTSGBarrierAckForFFSliceCS Damien Lespiau
2015-02-11 15:42   ` Nick Hoath
2015-02-11 16:04     ` Daniel Vetter
2015-02-09 19:33 ` [PATCH 17/18] drm/i915/skl: Implement WaCcsTlbPrefetchDisable:skl Damien Lespiau
2015-02-11 15:44   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 18/18] drm/i915/skl: Implement WaBarrierPerformanceFixDisable Damien Lespiau
2015-02-10 14:02   ` shuang.he
2015-02-11 15:51   ` Nick Hoath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DB77CE.10208@intel.com \
    --to=nicholas.hoath@intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox