From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Hoath Subject: Re: [PATCH 1/2] drm/i915/skl: Fix always true comparison in a revision id check Date: Thu, 12 Feb 2015 13:33:29 +0000 Message-ID: <54DCABA9.1050908@intel.com> References: <1423678904-23698-1-git-send-email-damien.lespiau@intel.com> <1423678904-23698-2-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id E2D2B6E72E for ; Thu, 12 Feb 2015 05:33:32 -0800 (PST) In-Reply-To: <1423678904-23698-2-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Lespiau, Damien" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTEvMDIvMjAxNSAxODoyMSwgTGVzcGlhdSwgRGFtaWVuIHdyb3RlOgo+IEl0J3MgYWx3YXlz IGEgZ29vZCBpZGVhIHRvIGtlZXAgc3RhdGljIGFuYWx5c2lzIGhhcHB5IChhbHNvIGJlY2F1c2Ug aXQKPiBwcm9tcHRzIGRvaW5nIHRoZSBjaGVjayBsaWtlIEkgcHJvcG9zZWQgOiksIHRoaXMgdGlt ZSBzbWF0Y2ggY29tcGxhaW5zOgo+Cj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5jOjg5MSBnZW45X2luaXRfd29ya2Fyb3VuZHMoKSB3YXJuOgo+ICAgIGFsd2F5cyB0cnVl IGNvbmRpdGlvbiAnKCgtPmRldi0+cGRldi0+cmV2aXNpb24pID49ICgwKSkgPT4gKDAtMjU1ID49 IDApJwo+Cj4gVGhhdCdzIGJlY2F1c2UgcmV2aXNpb24gaXMgYSB1OC4gVHdlYWsgYSBiaXQgdGhl IGNvbmRpdGlvbiB0aGVuLgo+Cj4gQ2M6IE5pY2sgSG9hdGggPG5pY2hvbGFzLmhvYXRoQGludGVs LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVuLmxlc3BpYXVAaW50 ZWwuY29tPgoKQSBiaXQgY29udHJpdmVkIDopIGJ1dDoKUmV2aWV3ZWQtYnk6IE5pY2sgSG9hdGgg PG5pY2hvbGFzLmhvYXRoQGludGVsLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmMgfCA0ICsrLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu Z2J1ZmZlci5jCj4gaW5kZXggMjA2MDYxMC4uODczNWU1NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtOTU3LDggKzk1Nyw4IEBAIHN0YXRpYyBpbnQg Z2VuOV9pbml0X3dvcmthcm91bmRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gICAJ V0FfU0VUX0JJVF9NQVNLRUQoSEFMRl9TTElDRV9DSElDS0VOMywKPiAgIAkJCSAgR0VOOV9ESVNB QkxFX09DTF9PT0JfU1VQUFJFU1NfTE9HSUMpOwo+Cj4gLQlpZiAoSU5URUxfUkVWSUQoZGV2KSA+ PSBTS0xfUkVWSURfQTAgJiYKPiAtCSAgICBJTlRFTF9SRVZJRChkZXYpIDw9IFNLTF9SRVZJRF9C MCkgewo+ICsJaWYgKElOVEVMX1JFVklEKGRldikgPT0gU0tMX1JFVklEX0EwIHx8Cj4gKwkgICAg SU5URUxfUkVWSUQoZGV2KSA9PSBTS0xfUkVWSURfQjApIHsKPiAgIAkJLyoKPiAgIAkJKiBXYURp c2FibGVEZ01pcnJvckZpeEluSGFsZlNsaWNlQ2hpY2tlbjU6c2tsCj4gICAJCSogVGhpcyBpcyBh IHByZS1wcm9kdWN0aW9uIHcvYS4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK