From: Nick Hoath <nicholas.hoath@intel.com>
To: "Lespiau, Damien" <damien.lespiau@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915/skl: Use a LRI for WaDisableDgMirrorFixInHalfSliceChicken5
Date: Thu, 12 Feb 2015 13:36:29 +0000 [thread overview]
Message-ID: <54DCAC5D.5030100@intel.com> (raw)
In-Reply-To: <1423678904-23698-3-git-send-email-damien.lespiau@intel.com>
On 11/02/2015 18:21, Lespiau, Damien wrote:
> I have no idea how that crept in, but we need to do the write from the
> ring and this is a masked register. Two fixes in 1!
>
> Cc: Nick Hoath <nicholas.hoath@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Nick Hoath <nicholas.hoath@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 8735e56..acc1669 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -959,13 +959,9 @@ static int gen9_init_workarounds(struct intel_engine_cs *ring)
>
> if (INTEL_REVID(dev) == SKL_REVID_A0 ||
> INTEL_REVID(dev) == SKL_REVID_B0) {
> - /*
> - * WaDisableDgMirrorFixInHalfSliceChicken5:skl
> - * This is a pre-production w/a.
> - */
> - I915_WRITE(GEN9_HALF_SLICE_CHICKEN5,
> - I915_READ(GEN9_HALF_SLICE_CHICKEN5) &
> - ~GEN9_DG_MIRROR_FIX_ENABLE);
> + /* WaDisableDgMirrorFixInHalfSliceChicken5:skl */
> + WA_CLR_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN5,
> + GEN9_DG_MIRROR_FIX_ENABLE);
> }
>
> if (INTEL_REVID(dev) >= SKL_REVID_C0) {
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-12 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 18:21 [PATCH 0/2] A couple of fixes on top of the recent W/A work Damien Lespiau
2015-02-11 18:21 ` [PATCH 1/2] drm/i915/skl: Fix always true comparison in a revision id check Damien Lespiau
2015-02-12 13:33 ` Nick Hoath
2015-02-11 18:21 ` [PATCH 2/2] drm/i915/skl: Use a LRI for WaDisableDgMirrorFixInHalfSliceChicken5 Damien Lespiau
2015-02-12 13:36 ` Nick Hoath [this message]
2015-02-13 8:59 ` Daniel Vetter
2015-02-13 7:03 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCAC5D.5030100@intel.com \
--to=nicholas.hoath@intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox