From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Hoath Subject: Re: [PATCH] drm/i915: Fix an incorrect free rather than derefence issue. Date: Fri, 13 Feb 2015 09:58:50 +0000 Message-ID: <54DDCADA.9090504@intel.com> References: <1423744161-21554-1-git-send-email-nicholas.hoath@intel.com> <20150213093215.GH24485@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id CA07989216 for ; Fri, 13 Feb 2015 01:58:53 -0800 (PST) In-Reply-To: <20150213093215.GH24485@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMDIvMjAxNSAwOTozMiwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUaHUsIEZlYiAx MiwgMjAxNSBhdCAxMjoyOToyMVBNICswMDAwLCBOaWNrIEhvYXRoIHdyb3RlOgo+PiBCdWd6aWxs YTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg2NTIKPj4K Pj4gU2lnbmVkLW9mZi1ieTogTmljayBIb2F0aCA8bmljaG9sYXMuaG9hdGhAaW50ZWwuY29tPgo+ Cj4gQ29tbWl0IG1lc3NhZ2UgaXMgbWlzc2luZyB0aGUgYWJzb2x1dGVseSBjcnVjaWFsIGRldGFp bCBhYm91dCB3aGljaCBwYXRjaAo+IGludHJvZHVjZWQgdGhpcyByZWdyZXNzaW9uOgo+Cj4gY29t bWl0IDZkM2Q4Mjc0YmM0NWRlNGJhYmI2MmQ2NDU2MmQ5MmFmOTg0ZGQyMzgKPiBBdXRob3I6ICAg ICBOaWNrIEhvYXRoIDxuaWNob2xhcy5ob2F0aEBpbnRlbC5jb20+Cj4gQXV0aG9yRGF0ZTogVGh1 IEphbiAxNSAxMzoxMDozOSAyMDE1ICswMDAwCj4KPiAgICAgIGRybS9pOTE1OiBTdWJzdW1lIGlu dGVsX2N0eF9zdWJtaXRfcmVxdWVzdCBpbiB0byBkcm1faTkxNV9nZW1fcmVxdWVzdAo+Cj4gQW5v dGhlciB0aGluZyBJJ3ZlIG5vdGljZWQgaXMgdGhhdCB3ZSBleHBsaWNpdGx5IGRyb3AgdGhlIGNv bnRleHQKPiByZWZlcmVuY2UgZm9yIHRoZSByZXF1ZXN0IGJlZm9yZSBkcm9wcGluZyB0aGUgcmVx dWVzdCByZWZlcmVuY2UuIFdpdGhvdXQKPiBjbGVhcmluZyB0aGUgcmVxLT5jdHggcG9pbnRlci4g VGhhdCBoYXMgYSB2ZXJ5IGhpZ2ggY2hhbmNlIHRvIGxlYWRpbmcgdG8KPiB0ZWFycywgaW1vIHRo ZSBjb250ZXh0IHVucmVmZXJlbmNlaW5nIHNob3VsZCBiZSBwdXNoZWQgaW50bwo+IGk5MTVfZ2Vt X3JlcXVlc3RfZnJlZS4KPgo+IEV4Y2VwdCB0aGF0IGl0J3MgdGhlcmUgYWxyZWFkeSwgd2hpY2gg bWVhbnMgd2UgaGF2ZSBhIGRvdWJsZSB1bnJlZiBub3c/CgpMb29raW5nIGF0IHRoZSBjb2RlLCBp dCBsb29rcyBsaWtlIHRoYXQncyB0aGUgY2FzZS4KCj4KPiBBbHNvIHRoaXMgcGF0Y2ggaXMgZm9y IHRoZSBsZWdhY3kgcmluZ2J1ZmZlciBjb2RlLCBidXQgdGhlIHJlZmVyZW5jZWQgYnVnCj4gaXMg Zm9yIGdlbjgrIGV4ZWNsaXN0cy4gV2UncmUgZGVmaW5pdGVseSBub3QgcnVubmluZyB0aGlzIGNv ZGUgaGVyZSBJCj4gdGhpbmsuCgppOTE1X2dlbV9yZXNldF9yaW5nX2NsZWFudXAgaXMgdXNlZCBp biBleGVjbGlzdHMgaW4gdGhlIGhhbmcgcmVjb3ZlcnkgY2FzZS4KCj4KPiBJbW8gc3RlcCBvbmUg aXMgdG8gZHJvcCBhbGwgdGhlIGV4cGxpY2l0IGN0eCByZWZjb3VudGluZyBmb3IgcmVxLT5jdHgg YW5kCj4gYWx3YXlzIHJlbHkgb24gdGhlIGltcGxpY2l0IHJlZmVyZW5jZS4gVGhlbiBzZWUgd2hh dCBoYXBwZW5zLgoKSSBhZ3JlZSB0aGF0IHRoZSByZWZjb3VudGluZyBuZWVkcyByZS1ldmFsdWF0 aW5nIGFmdGVyIHRoZSBtZXJnZSBvZiAKZXhlY2xpc3QgcXVldWUgZW50cmllcyAmIHJlcXVlc3Rz LCBob3dldmVyIEkgdGhpbmsgdGhlIGNsZWFudXAgb2YgdGhlIApkb3VibGUgdW5yZWYvcmVtb3Zp bmcgdGhlIHJlZmNvdW50aW5nIHNob3VsZCBiZSBkb25lIGluIGFub3RoZXIgCnBhdGNoc2V0LiBU aGlzIHBhdGNoIGlzIHB1cmVseSB0byBmaXggdGhlIGlzc3VlIHJhaXNlZCBpbiA4ODY1Mi4gRGVw ZW5kcyAKb24gdGhlIHJlbGF0aXZlIHByaW9yaXRpZXMuCgo+Cj4gQ2hlZXJzLCBEYW5pZWwKPgo+ Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCAyICstCj4+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDIgKy0KPj4gICAyIGZpbGVzIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4+IGluZGV4IDE3NjU5ODkuLmRjMTBkODYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+PiBAQCAtMjY2MSw3ICsyNjYxLDcgQEAgc3RhdGljIHZvaWQgaTkxNV9nZW1fcmVz ZXRfcmluZ19jbGVhbnVwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAJ CQlpbnRlbF9scl9jb250ZXh0X3VucGluKHJpbmcsIHN1Ym1pdF9yZXEtPmN0eCk7Cj4+Cj4+ICAg CQlpOTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKHN1Ym1pdF9yZXEtPmN0eCk7Cj4+IC0JCWtm cmVlKHN1Ym1pdF9yZXEpOwo+PiArCQlpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlKHN1Ym1p dF9yZXEpOwo+PiAgIAl9Cj4+Cj4+ICAgCS8qCj4+IC0tCj4+IDIuMS4xCj4+Cj4+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IEludGVsLWdmeCBtYWls aW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==