From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH 4/5] drm/i915: Cache last obj->pages location for i915_gem_object_get_page() Date: Fri, 13 Feb 2015 13:33:40 +0000 Message-ID: <54DDFD34.4040305@Intel.com> References: <1421234459-21424-1-git-send-email-chris@chris-wilson.co.uk> <1421234459-21424-4-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 59AEF6E7C6 for ; Fri, 13 Feb 2015 05:33:43 -0800 (PST) In-Reply-To: <1421234459-21424-4-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTQvMDEvMjAxNSAxMToyMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IFRoZSBiaWdnZXN0IHVz ZXIgb2YgaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKCkgaXMgdGhlIHJlbG9jYXRpb24KPiBwcm9j ZXNzaW5nIGR1cmluZyBleGVjYnVmZmVyLiBUeXBpY2FsbHkgdXNlcnNwYWNlIHBhc3NlcyBpbiBh IHNldCBvZgo+IHJlbG9jYXRpb25zIGluIHNvcnRlZCBvcmRlci4gU2FkbHksIHdlIGFsdGVybmF0 ZSBiZXR3ZWVuIHJlbG9jYXRpb25zCj4gaW5jcmVhc2luZyBmcm9tIHRoZSBzdGFydCBvZiB0aGUg YnVmZmVycywgYW5kIHJlbG9jYXRpb25zIGRlY3JlYXNpbmcKPiBmcm9tIHRoZSBlbmQuIEhvd2V2 ZXIgdGhlIG1ham9yaXR5IG9mIGNvbnNlY3V0aXZlIGxvb2t1cHMgd2lsbCBzdGlsbCBiZQo+IGlu IHRoZSBzYW1lIHBhZ2UuIFdlIGNvdWxkIGNhY2hlIHRoZSBzdGFydCBvZiB0aGUgbGFzdCBzZyBj aGFpbiwgaG93ZXZlcgo+IGZvciBtb3N0IGNhbGxlcnMsIHRoZSBlbnRpcmUgc2dsIGlzIGluc2lk ZSBhIHNpbmdsZSBjaGFpbiBhbmQgc28gd2Ugc2VlCj4gbm8gaW1wcm92ZSBmcm9tIHRoZSBleHRy YSBsYXllciBvZiBjYWNoaW5nLgo+Cj4gUmVmZXJlbmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNr dG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgzMDgKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmggfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgIDQgKysrKwo+ICAgMiBmaWxlcyBjaGFu Z2VkLCAzMCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oCj4gaW5kZXggNjZmMGM2MDdkYmVmLi4wNGE3ZDU5NGQ5MzMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjAwNSw2ICsyMDA1LDEwIEBAIHN0cnVjdCBkcm1faTkxNV9n ZW1fb2JqZWN0IHsKPiAgIAo+ICAgCXN0cnVjdCBzZ190YWJsZSAqcGFnZXM7Cj4gICAJaW50IHBh Z2VzX3Bpbl9jb3VudDsKPiArCXN0cnVjdCBnZXRfcGFnZSB7Cj4gKwkJc3RydWN0IHNjYXR0ZXJs aXN0ICpzZzsKPiArCQlpbnQgbGFzdDsKPiArCX0gZ2V0X3BhZ2U7Cj4gICAKPiAgIAkvKiBwcmlt ZSBkbWEtYnVmIHN1cHBvcnQgKi8KPiAgIAl2b2lkICpkbWFfYnVmX3ZtYXBwaW5nOwo+IEBAIC0y NjEyLDE1ICsyNjE2LDMyIEBAIGludCBpOTE1X2dlbV9vYmpfcHJlcGFyZV9zaG1lbV9yZWFkKHN0 cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gICAJCQkJICAgIGludCAqbmVlZHNfY2xm bHVzaCk7Cj4gICAKPiAgIGludCBfX211c3RfY2hlY2sgaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdl cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKTsKPiAtc3RhdGljIGlubGluZSBzdHJ1 Y3QgcGFnZSAqaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKHN0cnVjdCBkcm1faTkxNV9nZW1fb2Jq ZWN0ICpvYmosIGludCBuKQo+ICsKPiArc3RhdGljIGlubGluZSBpbnQgc2dfcGFnZV9jb3VudChz dHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnKQo+ICt7Cj4gKwlyZXR1cm4gUEFHRV9BTElHTihzZy0+b2Zm c2V0ICsgc2ctPmxlbmd0aCkgPj4gUEFHRV9TSElGVDsKPiArfQo+ICsKPiArc3RhdGljIGlubGlu ZSBzdHJ1Y3QgcGFnZSAqCj4gK2k5MTVfZ2VtX29iamVjdF9nZXRfcGFnZShzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdCAqb2JqLCBpbnQgbikKPiAgIHsKPiAtCXN0cnVjdCBzZ19wYWdlX2l0ZXIg c2dfaXRlcjsKPiArCWlmIChXQVJOX09OKG4gPj0gb2JqLT5iYXNlLnNpemUgPj4gUEFHRV9TSElG VCkpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gICAKPiAtCWZvcl9lYWNoX3NnX3BhZ2Uob2JqLT5wYWdl cy0+c2dsLCAmc2dfaXRlciwgb2JqLT5wYWdlcy0+bmVudHMsIG4pCj4gLQkJcmV0dXJuIHNnX3Bh Z2VfaXRlcl9wYWdlKCZzZ19pdGVyKTsKPiArCWlmIChuIDwgb2JqLT5nZXRfcGFnZS5sYXN0KSB7 Cj4gKwkJb2JqLT5nZXRfcGFnZS5zZyA9IG9iai0+cGFnZXMtPnNnbDsKPiArCQlvYmotPmdldF9w YWdlLmxhc3QgPSAwOwo+ICsJfQo+ICsKPiArCXdoaWxlIChvYmotPmdldF9wYWdlLmxhc3QgKyBz Z19wYWdlX2NvdW50KG9iai0+Z2V0X3BhZ2Uuc2cpIDw9IG4pIHsKPiArCQlvYmotPmdldF9wYWdl Lmxhc3QgKz0gc2dfcGFnZV9jb3VudChvYmotPmdldF9wYWdlLnNnKTsKPiArCQlpZiAodW5saWtl bHkoc2dfaXNfY2hhaW4oKytvYmotPmdldF9wYWdlLnNnKSkpCklzIGl0IHNhZmUgdG8gZG8gdGhl ICsrIGluc2lkZSBhIG5lc3RlZCBwYWlyIG9mIG1hY3Jvcz8gVGhlcmUgaXMgYXQgCmxlYXN0IG9u ZSBkZWZpbml0aW9uIG9mICd1bmxpa2VseScgaW4gdGhlIGxpbnV4IHNvdXJjZSB0aGF0IHdvdWxk IGNhdXNlIAptdWx0aXBsZSBldmFsdWF0aW9ucy4KPiArCQkJb2JqLT5nZXRfcGFnZS5zZyA9IHNn X2NoYWluX3B0cihvYmotPmdldF9wYWdlLnNnKTsKPiArCX0KPiAgIAo+IC0JcmV0dXJuIE5VTEw7 Cj4gKwlyZXR1cm4gbnRoX3BhZ2Uoc2dfcGFnZShvYmotPmdldF9wYWdlLnNnKSwgbiAtIG9iai0+ Z2V0X3BhZ2UubGFzdCk7Cj4gICB9Cj4gKwo+ICAgc3RhdGljIGlubGluZSB2b2lkIGk5MTVfZ2Vt X29iamVjdF9waW5fcGFnZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiAgIHsK PiAgIAlCVUdfT04ob2JqLT5wYWdlcyA9PSBOVUxMKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK PiBpbmRleCA2YzQwMzY1NGUzM2EuLmQ3MTBkYTA5OWJkYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+IEBAIC0yMjYwLDYgKzIyNjAsMTAgQEAgaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdl cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgCQlyZXR1cm4gcmV0Owo+ICAg Cj4gICAJbGlzdF9hZGRfdGFpbCgmb2JqLT5nbG9iYWxfbGlzdCwgJmRldl9wcml2LT5tbS51bmJv dW5kX2xpc3QpOwo+ICsKPiArCW9iai0+Z2V0X3BhZ2Uuc2cgPSBvYmotPnBhZ2VzLT5zZ2w7Cj4g KwlvYmotPmdldF9wYWdlLmxhc3QgPSAwOwo+ICsKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiAgIAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK