From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH 4/5] drm/i915: Cache last obj->pages location for i915_gem_object_get_page() Date: Fri, 13 Feb 2015 13:35:26 +0000 Message-ID: <54DDFD9E.8070100@Intel.com> References: <1421234459-21424-1-git-send-email-chris@chris-wilson.co.uk> <1421234459-21424-4-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AFF26E05F for ; Fri, 13 Feb 2015 05:35:29 -0800 (PST) In-Reply-To: <1421234459-21424-4-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org QWNjaWRlbnRhbGx5IGhpdCBzZW5kIHRvbyBlYXJseSwgaWdub3JlIHRoZSBvdGhlciByZXBseSEK Ck9uIDE0LzAxLzIwMTUgMTE6MjAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgYmlnZ2VzdCB1 c2VyIG9mIGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZSgpIGlzIHRoZSByZWxvY2F0aW9uCj4gcHJv Y2Vzc2luZyBkdXJpbmcgZXhlY2J1ZmZlci4gVHlwaWNhbGx5IHVzZXJzcGFjZSBwYXNzZXMgaW4g YSBzZXQgb2YKPiByZWxvY2F0aW9ucyBpbiBzb3J0ZWQgb3JkZXIuIFNhZGx5LCB3ZSBhbHRlcm5h dGUgYmV0d2VlbiByZWxvY2F0aW9ucwo+IGluY3JlYXNpbmcgZnJvbSB0aGUgc3RhcnQgb2YgdGhl IGJ1ZmZlcnMsIGFuZCByZWxvY2F0aW9ucyBkZWNyZWFzaW5nCj4gZnJvbSB0aGUgZW5kLiBIb3dl dmVyIHRoZSBtYWpvcml0eSBvZiBjb25zZWN1dGl2ZSBsb29rdXBzIHdpbGwgc3RpbGwgYmUKPiBp biB0aGUgc2FtZSBwYWdlLiBXZSBjb3VsZCBjYWNoZSB0aGUgc3RhcnQgb2YgdGhlIGxhc3Qgc2cg Y2hhaW4sIGhvd2V2ZXIKPiBmb3IgbW9zdCBjYWxsZXJzLCB0aGUgZW50aXJlIHNnbCBpcyBpbnNp ZGUgYSBzaW5nbGUgY2hhaW4gYW5kIHNvIHdlIHNlZQo+IG5vIGltcHJvdmUgZnJvbSB0aGUgZXh0 cmEgbGF5ZXIgb2YgY2FjaGluZy4KPgo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVz a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MzA4Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2ls c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8ICA0ICsrKysKPiAgIDIgZmlsZXMgY2hh bmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+IGluZGV4IDY2ZjBjNjA3ZGJlZi4uMDRhN2Q1OTRkOTMzIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4gQEAgLTIwMDUsNiArMjAwNSwxMCBAQCBzdHJ1Y3QgZHJtX2k5MTVf Z2VtX29iamVjdCB7Cj4gICAKPiAgIAlzdHJ1Y3Qgc2dfdGFibGUgKnBhZ2VzOwo+ICAgCWludCBw YWdlc19waW5fY291bnQ7Cj4gKwlzdHJ1Y3QgZ2V0X3BhZ2Ugewo+ICsJCXN0cnVjdCBzY2F0dGVy bGlzdCAqc2c7Cj4gKwkJaW50IGxhc3Q7Cj4gKwl9IGdldF9wYWdlOwo+ICAgCj4gICAJLyogcHJp bWUgZG1hLWJ1ZiBzdXBwb3J0ICovCj4gICAJdm9pZCAqZG1hX2J1Zl92bWFwcGluZzsKPiBAQCAt MjYxMiwxNSArMjYxNiwzMiBAQCBpbnQgaTkxNV9nZW1fb2JqX3ByZXBhcmVfc2htZW1fcmVhZChz dHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgCQkJCSAgICBpbnQgKm5lZWRzX2Ns Zmx1c2gpOwo+ICAgCj4gICBpbnQgX19tdXN0X2NoZWNrIGk5MTVfZ2VtX29iamVjdF9nZXRfcGFn ZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaik7Cj4gLXN0YXRpYyBpbmxpbmUgc3Ry dWN0IHBhZ2UgKmk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29i amVjdCAqb2JqLCBpbnQgbikKPiArCj4gK3N0YXRpYyBpbmxpbmUgaW50IHNnX3BhZ2VfY291bnQo c3RydWN0IHNjYXR0ZXJsaXN0ICpzZykKPiArewo+ICsJcmV0dXJuIFBBR0VfQUxJR04oc2ctPm9m ZnNldCArIHNnLT5sZW5ndGgpID4+IFBBR0VfU0hJRlQ7CkRvZXMgdGhpcyBuZWVkIHRvIGJlIHJv dW5kZWQgdXAgb3IgYXJlIHNnLT5vZmZzZXQgYW5kIHNnLT5sZW5ndGggCmd1YXJhbnRlZWQgdG8g YWx3YXlzIGJlIGEgbXVsdGlwbGUgb2YgdGhlIHBhZ2Ugc2l6ZT8KCj4gK30KPiArCj4gK3N0YXRp YyBpbmxpbmUgc3RydWN0IHBhZ2UgKgo+ICtpOTE1X2dlbV9vYmplY3RfZ2V0X3BhZ2Uoc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgaW50IG4pCj4gICB7Cj4gLQlzdHJ1Y3Qgc2dfcGFn ZV9pdGVyIHNnX2l0ZXI7Cj4gKwlpZiAoV0FSTl9PTihuID49IG9iai0+YmFzZS5zaXplID4+IFBB R0VfU0hJRlQpKQo+ICsJCXJldHVybiBOVUxMOwo+ICAgCj4gLQlmb3JfZWFjaF9zZ19wYWdlKG9i ai0+cGFnZXMtPnNnbCwgJnNnX2l0ZXIsIG9iai0+cGFnZXMtPm5lbnRzLCBuKQo+IC0JCXJldHVy biBzZ19wYWdlX2l0ZXJfcGFnZSgmc2dfaXRlcik7Cj4gKwlpZiAobiA8IG9iai0+Z2V0X3BhZ2Uu bGFzdCkgewo+ICsJCW9iai0+Z2V0X3BhZ2Uuc2cgPSBvYmotPnBhZ2VzLT5zZ2w7Cj4gKwkJb2Jq LT5nZXRfcGFnZS5sYXN0ID0gMDsKPiArCX0KPiArCj4gKwl3aGlsZSAob2JqLT5nZXRfcGFnZS5s YXN0ICsgc2dfcGFnZV9jb3VudChvYmotPmdldF9wYWdlLnNnKSA8PSBuKSB7Cj4gKwkJb2JqLT5n ZXRfcGFnZS5sYXN0ICs9IHNnX3BhZ2VfY291bnQob2JqLT5nZXRfcGFnZS5zZyk7Cj4gKwkJaWYg KHVubGlrZWx5KHNnX2lzX2NoYWluKCsrb2JqLT5nZXRfcGFnZS5zZykpKQpJcyBpdCBzYWZlIHRv IGRvIHRoZSArKyBpbnNpZGUgYSBuZXN0ZWQgcGFpciBvZiBtYWNyb3M/IFRoZXJlIGlzIGF0IAps ZWFzdCBvbmUgZGVmaW5pdGlvbiBvZiAndW5saWtlbHknIGluIHRoZSBsaW51eCBzb3VyY2UgdGhh dCB3b3VsZCBjYXVzZSAKbXVsdGlwbGUgZXZhbHVhdGlvbnMuCgo+ICsJCQlvYmotPmdldF9wYWdl LnNnID0gc2dfY2hhaW5fcHRyKG9iai0+Z2V0X3BhZ2Uuc2cpOwo+ICsJfQo+ICAgCj4gLQlyZXR1 cm4gTlVMTDsKPiArCXJldHVybiBudGhfcGFnZShzZ19wYWdlKG9iai0+Z2V0X3BhZ2Uuc2cpLCBu IC0gb2JqLT5nZXRfcGFnZS5sYXN0KTsKPiAgIH0KPiArCj4gICBzdGF0aWMgaW5saW5lIHZvaWQg aTkxNV9nZW1fb2JqZWN0X3Bpbl9wYWdlcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq KQo+ICAgewo+ICAgCUJVR19PTihvYmotPnBhZ2VzID09IE5VTEwpOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+IGluZGV4IDZjNDAzNjU0ZTMzYS4uZDcxMGRhMDk5YmRiIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jCj4gQEAgLTIyNjAsNiArMjI2MCwxMCBAQCBpOTE1X2dlbV9vYmplY3Rf Z2V0X3BhZ2VzKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gICAJCXJldHVybiBy ZXQ7Cj4gICAKPiAgIAlsaXN0X2FkZF90YWlsKCZvYmotPmdsb2JhbF9saXN0LCAmZGV2X3ByaXYt Pm1tLnVuYm91bmRfbGlzdCk7Cj4gKwo+ICsJb2JqLT5nZXRfcGFnZS5zZyA9IG9iai0+cGFnZXMt PnNnbDsKPiArCW9iai0+Z2V0X3BhZ2UubGFzdCA9IDA7Cj4gKwo+ICAgCXJldHVybiAwOwo+ICAg fQo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=