From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH 49/51] drm/i915: Update intel_logical_ring_begin() to take a request structure Date: Fri, 13 Feb 2015 17:04:55 +0000 Message-ID: <54DE2EB7.70109@Intel.com> References: <1423828140-10653-1-git-send-email-John.C.Harrison@Intel.com> <1423828140-10653-50-git-send-email-John.C.Harrison@Intel.com> <20150213121701.GK2749@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1599447793==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CE2516E08A for ; Fri, 13 Feb 2015 09:04:58 -0800 (PST) In-Reply-To: <20150213121701.GK2749@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1599447793== Content-Type: multipart/alternative; boundary="------------020209090907090105030801" This is a multi-part message in MIME format. --------------020209090907090105030801 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 13/02/2015 12:17, Chris Wilson wrote: > On Fri, Feb 13, 2015 at 11:48:58AM +0000, John.C.Harrison@Intel.com wrote: >> From: John Harrison >> >> Now that everything above has been converted to use requests, >> intel_logical_ring_begin() can be updated to take a request instead of a >> ringbuf/context pair. This also means that it no longer needs to lazily allocate >> a request if no-one happens to have done it earlier. >> >> Note that this change makes the execlist signature the same as the legacy >> version. Thus the two functions could be merged into a ring->begin() wrapper if >> required. > It should be noted that you don't even need to virtualise the > function... Please kill all the duplicated code. > -Chris > As noted in the cover letter, quite a lot of the execlist vs legacy duplication could be resolved back to a single code path. However, that was quite a large war discussion first time around. So I would rather leave that for another patch series once people actually decide what the best direction really is. --------------020209090907090105030801 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit On 13/02/2015 12:17, Chris Wilson wrote:
On Fri, Feb 13, 2015 at 11:48:58AM +0000, John.C.Harrison@Intel.com wrote:

From: John Harrison <John.C.Harrison@Intel.com>

Now that everything above has been converted to use requests,
intel_logical_ring_begin() can be updated to take a request instead of a
ringbuf/context pair. This also means that it no longer needs to lazily allocate
a request if no-one happens to have done it earlier.

Note that this change makes the execlist signature the same as the legacy
version. Thus the two functions could be merged into a ring->begin() wrapper if
required.

It should be noted that you don't even need to virtualise the
function... Please kill all the duplicated code.
-Chris
As noted in the cover letter, quite a lot of the execlist vs legacy duplication could be resolved back to a single code path. However, that was quite a large war discussion first time around. So I would rather leave that for another patch series once people actually decide what the best direction really is.

--------------020209090907090105030801-- --===============1599447793== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1599447793==--