From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [KERNEL] Regression bug in drm/i915, Wrong assumption in commit e11aa36 breaks suspend on at least lenovo x61 Date: Thu, 19 Feb 2015 10:47:53 +0000 Message-ID: <54E5BF59.4020208@intel.com> References: <20150211113919.GA5672@ikki.ethgen.ch> <20150216221142.GB14602@ikki.ethgen.ch> <20150217082937.GA27873@ikki.ethgen.ch> <87mw4bw7o7.fsf@intel.com> <1424276692.27236.1.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1424276692.27236.1.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com, Jani Nikula Cc: Klaus Ethgen , "intel-gfx@lists.freedesktop.org" , linux-kernel@vger.kernel.org, dri-devel List-Id: intel-gfx@lists.freedesktop.org T24gMTgvMDIvMTUgMTY6MjQsIEltcmUgRGVhayB3cm90ZToKPiBPbiBrZSwgMjAxNS0wMi0xOCBh dCAxNzozOSArMDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFR1ZSwgMTcgRmViIDIwMTUs IEtsYXVzIEV0aGdlbiA8S2xhdXMrbGttbEBldGhnZW4uZGU+IHdyb3RlOgo+Pj4gQWZ0ZXIgc29s dmluZyAgdGhlIGNvbmZsaWN0cywgSSBhcHBsaWVkIHRoZSByZXZlcnQgKHNlZSBhdHRhY2htZW50 KSB0bwo+Pj4gdjMuMTguNy4gSSB0aGluayBpdCBzaG91bGQgYWxzbyBhcHBseSB0byB0aGUgY3Vy cmVudCBoZWFkLiBXaXRoIHRoYXQKPj4+IHBhdGNoLCBzdXNwZW5kIGlzIHdvcmtpbmcgYWdhaW4g b24gdGhhdCB2ZXJzaW9uLgo+Pj4KPj4+IEhvd2V2ZXIsIEkgaGF2ZSBub3QgdG8gZGVlcCBrbm93 bGVkZ2Ugb2YgdGhhdCBzdWJzeXN0ZW0sIHNvIHBsZWFzZSwKPj4+IHNvbWVvbmUgd2hvIGhhdmUs IGhhdmUgYSBkZWVwZXIgbG9vayBpbnRvIGl0LiBJIGVzcGVjaWFsbHkgZG8gbm90IGtub3cKPj4+ IGlmIHRoZSBsaW5lcyBpbiAuLi4vaW50ZWxfcG0uYyBhcmUgY29ycmVjdCBvciBiZXR0ZXIgbGVh dmluZyB0aGVtIGFzCj4+PiB0aGV5IGFyZSBpbiB2My4xOC43Lgo+Pj4KPj4+IEkgd2FudCB0byBo YXZlIGl0IHdvcmtpbmcgb24gYSB2ZXJzaW9uIHRoYXQgSSBrbm93IGlzIHN0YWJsZSBiZWZvcmUK Pj4+IGFza2luZyB0byBwdWxsIGl0IHRvIGhlYWQuCj4+Cj4+IEhpIEtsYXVzLCB3ZSBmZWFyIHRo aXMgcGF0Y2ggbWF5IGhpZGUgdGhlIGFjdHVhbCBjYXVzZS4gV291bGQgYmUgdXNlZnVsCj4+IHRv IGdldCBhIGJldHRlciBkZXNjcmlwdGlvbiBvZiB3aGF0IGhhcHBlbnMsIGFsb25nIHdpdGggYSBk bWVzZyB3aXRoCj4+IGRybS5kZWJ1Zz0xNCBtb2R1bGUgcGFyYW1ldGVyIHNldC4gVGhpcyBtaWdo dCBjbHV0dGVyIHRoZSBtYWlsaW5nIGxpc3QsCj4+IHdvdWxkIHlvdSBtaW5kIGZpbGluZyBhIGJ1 ZyBhdCBbMV0gYW5kIGF0dGFjaCB0aGUgaW5mbyB0aGVyZT8KPj4KPj4gVGhhbmtzLAo+PiBKYW5p Lgo+Pgo+PiBbMV0gaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9lbnRlcl9idWcuY2dpP3By b2R1Y3Q9RFJJJmNvbXBvbmVudD1EUk0vSW50ZWwKPiAKPiBJbiBhZGRpdGlvbiB0byB0aGUgYWJv dmUgY291bGQgeW91IGFsc28gdHJ5IHRoZSBmb2xsb3dpbmcgcGF0Y2ggYW5kCj4gcHJvdmlkZSBh IGRtZXNnIGxvZyBvbiB0aGUgYnVnemlsbGEgdGlja2V0IC0gYXQgdGhpcyBwb2ludCBvbmx5IHRv IHRyeQo+IHRvIG5hcnJvdyBkb3duIHRoZSBpc3N1ZT86Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2ly cS5jCj4gaW5kZXggZDM1OGNlOC4uMDJjNjVmNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEu Ywo+IEBAIC00NDY2LDYgKzQ0NjYsMTQgQEAgc3RhdGljIGlycXJldHVybl90IGk5NjVfaXJxX2hh bmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ICAJCUk5MTVfRElTUExBWV9QTEFORV9BX0ZMSVBf UEVORElOR19JTlRFUlJVUFQgfAo+ICAJCUk5MTVfRElTUExBWV9QTEFORV9CX0ZMSVBfUEVORElO R19JTlRFUlJVUFQ7Cj4gIAo+ICsJaWYgKCFpbnRlbF9pcnFzX2VuYWJsZWQoZGV2X3ByaXYpKSB7 Cj4gKwkJaWYgKHByaW50a19yYXRlbGltaXQoKSkKPiArCQkJRFJNX0VSUk9SKCJzcHVyaW91cy9z aGFyZWQgaW50ZXJydXB0IGlpciAlMDh4IGltciAlMDh4IGllciAlMDh4XG4iLAo+ICsJCQkJICBJ OTE1X1JFQUQoSUlSKSwgSTkxNV9SRUFEKElNUiksIEk5MTVfUkVBRChJRVIpKTsKPiArCj4gKwkJ cmV0dXJuIElSUV9OT05FOwo+ICsJfQo+ICsKPiAgCWlpciA9IEk5MTVfUkVBRChJSVIpOwo+ICAK PiAgCWZvciAoOzspIHsKPiBAQCAtNDc2Niw3ICs0Nzc0LDEwIEBAIHZvaWQgaW50ZWxfcnVudGlt ZV9wbV9kaXNhYmxlX2ludGVycnVwdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAo+ICAJ ZGV2LT5kcml2ZXItPmlycV91bmluc3RhbGwoZGV2KTsKPiArCj4gKwlzcGluX2xvY2tfaXJxKCZk ZXZfcHJpdi0+aXJxX2xvY2spOwo+ICAJZGV2X3ByaXYtPnBtLl9pcnFzX2Rpc2FibGVkID0gdHJ1 ZTsKPiArCXNwaW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiAgfQo+ICAKPiAg LyogUmVzdG9yZSBpbnRlcnJ1cHRzIHNvIHdlIGNhbiByZWNvdmVyIGZyb20gcnVudGltZSBQTS4g Ki8KPiBAQCAtNDc3NCw3ICs0Nzg1LDEwIEBAIHZvaWQgaW50ZWxfcnVudGltZV9wbV9yZXN0b3Jl X2ludGVycnVwdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCj4gKwlzcGluX2xv Y2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ICAJZGV2X3ByaXYtPnBtLl9pcnFzX2Rpc2Fi bGVkID0gZmFsc2U7Cj4gKwlzcGluX3VubG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4g Kwo+ICAJZGV2LT5kcml2ZXItPmlycV9wcmVpbnN0YWxsKGRldik7Cj4gIAlkZXYtPmRyaXZlci0+ aXJxX3Bvc3RpbnN0YWxsKGRldik7Cj4gIH0KClN1cmVseSBzdXJyb3VuZGluZyAod2hhdCBvdWdo dCB0byBiZSkgYW4gYXRvbWljIGFzc2lnbm1lbnQgdG8gYSBzaW5nbGUKdmFyaWFibGUgY2Fubm90 IG1ha2UgYSBkaWZmZXJlbmNlPyBVbmxlc3MgaXQncyB0aGUgbWVtb3J5IGJhcnJpZXIKc2VtYW50 aWNzIHRoYXQgaGF2ZSBzb21lIGVmZmVjdD8gSXQgc2VlbXMgdW5saWtlbHkgdGhhdCB0aGUgY29t cGlsZXIgaGFzCmRlZmVycmVkIHRoZSB3cml0ZSB0byB0aGUgdmFyaWFibGUgcGFzdCB0aGUgcHJl L3Bvc3RpbnN0YWxsIGNhbGxzIHRoYXQKYWN0dWFsbHkgZW5hYmxlIHRoZSBoL3cgaW50ZXJydXB0 cywgYnV0IG1heWJlIHdlIHNob3VsZCBhZGQgInZvbGF0aWxlIgpqdXN0IGluIGNhc2U/CgouRGF2 ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK