From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [KERNEL] Regression bug in drm/i915, Wrong assumption in commit e11aa36 breaks suspend on at least lenovo x61 Date: Thu, 19 Feb 2015 15:42:08 +0000 Message-ID: <54E60450.9010605@intel.com> References: <20150211113919.GA5672@ikki.ethgen.ch> <20150216221142.GB14602@ikki.ethgen.ch> <20150217082937.GA27873@ikki.ethgen.ch> <87mw4bw7o7.fsf@intel.com> <1424276692.27236.1.camel@intel.com> <54E5BF59.4020208@intel.com> <1424344107.3496.10.camel@ideak-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1424344107.3496.10.camel@ideak-mobl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Deak, Imre" Cc: dri-devel , Klaus Ethgen , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTkvMDIvMTUgMTE6MDgsIERlYWssIEltcmUgd3JvdGU6Cj4gT24gVGh1LCAyMDE1LTAyLTE5 IGF0IDEwOjQ3ICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gT24gMTgvMDIvMTUgMTY6MjQs IEltcmUgRGVhayB3cm90ZToKPj4+IE9uIGtlLCAyMDE1LTAyLTE4IGF0IDE3OjM5ICswMjAwLCBK YW5pIE5pa3VsYSB3cm90ZToKPj4+PiBPbiBUdWUsIDE3IEZlYiAyMDE1LCBLbGF1cyBFdGhnZW4g PEtsYXVzK2xrbWxAZXRoZ2VuLmRlPiB3cm90ZToKPj4+Pj4gQWZ0ZXIgc29sdmluZyAgdGhlIGNv bmZsaWN0cywgSSBhcHBsaWVkIHRoZSByZXZlcnQgKHNlZSBhdHRhY2htZW50KSB0bwo+Pj4+PiB2 My4xOC43LiBJIHRoaW5rIGl0IHNob3VsZCBhbHNvIGFwcGx5IHRvIHRoZSBjdXJyZW50IGhlYWQu IFdpdGggdGhhdAo+Pj4+PiBwYXRjaCwgc3VzcGVuZCBpcyB3b3JraW5nIGFnYWluIG9uIHRoYXQg dmVyc2lvbi4KPj4+Pj4KPj4+Pj4gSG93ZXZlciwgSSBoYXZlIG5vdCB0byBkZWVwIGtub3dsZWRn ZSBvZiB0aGF0IHN1YnN5c3RlbSwgc28gcGxlYXNlLAo+Pj4+PiBzb21lb25lIHdobyBoYXZlLCBo YXZlIGEgZGVlcGVyIGxvb2sgaW50byBpdC4gSSBlc3BlY2lhbGx5IGRvIG5vdCBrbm93Cj4+Pj4+ IGlmIHRoZSBsaW5lcyBpbiAuLi4vaW50ZWxfcG0uYyBhcmUgY29ycmVjdCBvciBiZXR0ZXIgbGVh dmluZyB0aGVtIGFzCj4+Pj4+IHRoZXkgYXJlIGluIHYzLjE4LjcuCj4+Pj4+Cj4+Pj4+IEkgd2Fu dCB0byBoYXZlIGl0IHdvcmtpbmcgb24gYSB2ZXJzaW9uIHRoYXQgSSBrbm93IGlzIHN0YWJsZSBi ZWZvcmUKPj4+Pj4gYXNraW5nIHRvIHB1bGwgaXQgdG8gaGVhZC4KPj4+Pgo+Pj4+IEhpIEtsYXVz LCB3ZSBmZWFyIHRoaXMgcGF0Y2ggbWF5IGhpZGUgdGhlIGFjdHVhbCBjYXVzZS4gV291bGQgYmUg dXNlZnVsCj4+Pj4gdG8gZ2V0IGEgYmV0dGVyIGRlc2NyaXB0aW9uIG9mIHdoYXQgaGFwcGVucywg YWxvbmcgd2l0aCBhIGRtZXNnIHdpdGgKPj4+PiBkcm0uZGVidWc9MTQgbW9kdWxlIHBhcmFtZXRl ciBzZXQuIFRoaXMgbWlnaHQgY2x1dHRlciB0aGUgbWFpbGluZyBsaXN0LAo+Pj4+IHdvdWxkIHlv dSBtaW5kIGZpbGluZyBhIGJ1ZyBhdCBbMV0gYW5kIGF0dGFjaCB0aGUgaW5mbyB0aGVyZT8KPj4+ Pgo+Pj4+IFRoYW5rcywKPj4+PiBKYW5pLgo+Pj4+Cj4+Pj4gWzFdIGh0dHBzOi8vYnVncy5mcmVl ZGVza3RvcC5vcmcvZW50ZXJfYnVnLmNnaT9wcm9kdWN0PURSSSZjb21wb25lbnQ9RFJNL0ludGVs Cj4+Pgo+Pj4gSW4gYWRkaXRpb24gdG8gdGhlIGFib3ZlIGNvdWxkIHlvdSBhbHNvIHRyeSB0aGUg Zm9sbG93aW5nIHBhdGNoIGFuZAo+Pj4gcHJvdmlkZSBhIGRtZXNnIGxvZyBvbiB0aGUgYnVnemls bGEgdGlja2V0IC0gYXQgdGhpcyBwb2ludCBvbmx5IHRvIHRyeQo+Pj4gdG8gbmFycm93IGRvd24g dGhlIGlzc3VlPzoKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPj4+IGluZGV4IGQzNThj ZTguLjAyYzY1ZjQgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2ly cS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+PiBAQCAtNDQ2 Niw2ICs0NDY2LDE0IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBpOTY1X2lycV9oYW5kbGVyKGludCBp cnEsIHZvaWQgKmFyZykKPj4+ICAJCUk5MTVfRElTUExBWV9QTEFORV9BX0ZMSVBfUEVORElOR19J TlRFUlJVUFQgfAo+Pj4gIAkJSTkxNV9ESVNQTEFZX1BMQU5FX0JfRkxJUF9QRU5ESU5HX0lOVEVS UlVQVDsKPj4+ICAKPj4+ICsJaWYgKCFpbnRlbF9pcnFzX2VuYWJsZWQoZGV2X3ByaXYpKSB7Cj4+ PiArCQlpZiAocHJpbnRrX3JhdGVsaW1pdCgpKQo+Pj4gKwkJCURSTV9FUlJPUigic3B1cmlvdXMv c2hhcmVkIGludGVycnVwdCBpaXIgJTA4eCBpbXIgJTA4eCBpZXIgJTA4eFxuIiwKPj4+ICsJCQkJ ICBJOTE1X1JFQUQoSUlSKSwgSTkxNV9SRUFEKElNUiksIEk5MTVfUkVBRChJRVIpKTsKPj4+ICsK Pj4+ICsJCXJldHVybiBJUlFfTk9ORTsKPj4+ICsJfQo+Pj4gKwo+Pj4gIAlpaXIgPSBJOTE1X1JF QUQoSUlSKTsKPj4+ICAKPj4+ICAJZm9yICg7Oykgewo+Pj4gQEAgLTQ3NjYsNyArNDc3NCwxMCBA QCB2b2lkIGludGVsX3J1bnRpbWVfcG1fZGlzYWJsZV9pbnRlcnJ1cHRzKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ ZGV2X3ByaXZhdGU7Cj4+PiAgCj4+PiAgCWRldi0+ZHJpdmVyLT5pcnFfdW5pbnN0YWxsKGRldik7 Cj4+PiArCj4+PiArCXNwaW5fbG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4+PiAgCWRl dl9wcml2LT5wbS5faXJxc19kaXNhYmxlZCA9IHRydWU7Cj4+PiArCXNwaW5fdW5sb2NrX2lycSgm ZGV2X3ByaXYtPmlycV9sb2NrKTsKPj4+ICB9Cj4+PiAgCj4+PiAgLyogUmVzdG9yZSBpbnRlcnJ1 cHRzIHNvIHdlIGNhbiByZWNvdmVyIGZyb20gcnVudGltZSBQTS4gKi8KPj4+IEBAIC00Nzc0LDcg KzQ3ODUsMTAgQEAgdm9pZCBpbnRlbF9ydW50aW1lX3BtX3Jlc3RvcmVfaW50ZXJydXB0cyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQo+Pj4gIHsKPj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4+ICAKPj4+ICsJc3Bpbl9sb2NrX2lycSgm ZGV2X3ByaXYtPmlycV9sb2NrKTsKPj4+ICAJZGV2X3ByaXYtPnBtLl9pcnFzX2Rpc2FibGVkID0g ZmFsc2U7Cj4+PiArCXNwaW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPj4+ICsK Pj4+ICAJZGV2LT5kcml2ZXItPmlycV9wcmVpbnN0YWxsKGRldik7Cj4+PiAgCWRldi0+ZHJpdmVy LT5pcnFfcG9zdGluc3RhbGwoZGV2KTsKPj4+ICB9Cj4+Cj4+IFN1cmVseSBzdXJyb3VuZGluZyAo d2hhdCBvdWdodCB0byBiZSkgYW4gYXRvbWljIGFzc2lnbm1lbnQgdG8gYSBzaW5nbGUKPj4gdmFy aWFibGUgY2Fubm90IG1ha2UgYSBkaWZmZXJlbmNlPyBVbmxlc3MgaXQncyB0aGUgbWVtb3J5IGJh cnJpZXIKPj4gc2VtYW50aWNzIHRoYXQgaGF2ZSBzb21lIGVmZmVjdD8gSXQgc2VlbXMgdW5saWtl bHkgdGhhdCB0aGUgY29tcGlsZXIgaGFzCj4+IGRlZmVycmVkIHRoZSB3cml0ZSB0byB0aGUgdmFy aWFibGUgcGFzdCB0aGUgcHJlL3Bvc3RpbnN0YWxsIGNhbGxzIHRoYXQKPj4gYWN0dWFsbHkgZW5h YmxlIHRoZSBoL3cgaW50ZXJydXB0cywgYnV0IG1heWJlIHdlIHNob3VsZCBhZGQgInZvbGF0aWxl Igo+PiBqdXN0IGluIGNhc2U/Cj4gCj4gc3BpbmxvY2tzIGFsc28gc2VydmUgYXMgYSBtZW1vcnkg YmFycmllci4gdm9sYXRpbGUgd291bGQgZ3VhcmFudGVlIG9ubHkKPiB0aGF0IHRoZSBjb21waWxl ciBkb2Vzbid0IHJlb3JkZXIgdGhlIHdyaXRlLCBzbyBpdCB3b3VsZG4ndCBiZSBlbm91Z2gKPiBh bG9uZS4gT3RvaCwgd2UgbWF5IGFsc28gbmVlZCB0byBhZGQgc3BpbmxvY2tpbmcgdG8gdGhlIGlu dGVycnVwdAo+IGhhbmRsZXIgaWYgdGhlIGlzc3VlIHR1cm5zIG91dCB0byBiZSB0aGF0IHdlIGNh bid0IGFjY2VzcyBzb21lIHJlZ2lzdGVyCj4gcGFzdC9iZWZvcmUgaW50ZWxfcnVudGltZV9wbV97 ZGlzYWJsZSxlbmFibGV9X2ludGVycnVwdHMuCj4gCj4gLS1JbXJlCgpJZiB3ZSB3ZXJlIGdldHRp bmcgaW50ZXJydXB0cyBkdXJpbmcgdGhlIGVuYWJsaW5nIHNlcXVlbmNlLCB0aGVyZSB3b3VsZApi ZSB0aHJlZSBwb3NzaWJpbGl0aWVzOgoxLgljb21waWxlciBoYXMgZGVsYXllZCB3cml0ZWJhY2su IFRoaXMgd291bGQgYmUgYSBjb21waWxlciBidWcKCShJTUhPKSBidXQgJ3ZvbGF0aWxlJyBtaWdo dCBmaXggaXQuCjIuCXRoZSAncmVzdG9yZScgdGhyZWFkIGhhcyB3cml0dGVuIHRoZSB2YWx1ZSwg YnV0IGl0IGlzbid0IHNlZW4KCWJ5IHRoZSB0aHJlYWQgaGFuZGxpbmcgdGhlIGludGVycnVwdCAo b24gYSBkaWZmZXJlbnQgY3B1PykuCglUaGlzIHdvdWxkIGJlIGEgY29oZXJlbmN5IGlzc3VlLCBh bmQgYSBtZW1vcnkgYmFycmllciBzaG91bGQKCWZpeCBpdC4gQnV0IEkgd291bGQgaGF2ZSBleHBl Y3RlZCB0aGUgdmFyaWFibGUgdG8gYmUgaW4KCWNvaGVyZW50IG1lbW9yeSBhbnl3YXkuCjMuCXRo ZSBHUFUgaC93IHNlbmRpbmcgaW50ZXJydXB0cyBiZWZvcmUgdGhleSdyZSBlbmFibGVkIDooCgpC dXQgSSBzdXNwZWN0IHRoaXMgbWlnaHQgYmUgZHVyaW5nICpkaXNhYmxpbmcqIHRoZSBpbnRlcnJ1 cHQuIFBvc3NpYmx5IGEKcmFjZSBjb25kaXRpb24gaW4gd2hpY2ggdGhlIGgvdyBoYXMgYWxyZWFk eSBnZW5lcmF0ZWQgYW4gaW50ZXJydXB0CmJlZm9yZSBpdCdzIGRpc2FibGVkLCBidXQgdGhhdCBp bnRlcnJ1cHQgaGFzIG5vdCB5ZXQgYmVlbiBmaWVsZGVkOyBzbwp0aGF0IGJ5IHRoZSB0aW1lIHRo ZSBpbnRlcnJ1cHQgaGFuZGxlciBydW5zIChvbiBhIGRpZmZlcmVudCBDUFUgZnJvbSB0aGUKJ3N1 c3BlbmQnIHRocmVhZCksIHRoZSB3cml0ZSB0byB0aGUgdmFyaWFibGUgY2FuIGhhdmUgaGFwcGVu ZWQgYW5kIHRoZW4KdGhlIG5ldyB2YWx1ZSBpcyBzZWVuIGJ5IHRoZSBpbnRlcnJ1cHQgaGFuZGxl ci4KCkluIHdoaWNoIGNhc2UgdGhlIHR3ZWFrIGFib3ZlIHdpbGwgcmVkdWNlIGJ1dCBub3QgbmVj ZXNzYXJpbHkgZWxpbWluYXRlCnRoZSB3aW5kb3c7IGl0IHdpbGwgZW5zdXJlIHRoYXQgaWYgdGhl IGhhbmRsZXIgaGFzIGdvdCBhdCBsZWFzdCBhcyBmYXIKYXMgdGFraW5nIHRoZSBzcGlubG9jayBi ZWZvcmUgdGhlIHN1c3BlbmQgdGhyZWFkLCB0aGVuIHRoZSB3cml0ZSB3aWxsIGJlCmRlbGF5ZWQg dW50aWwgdGhlIGhhbmRsZXIgaGFzIGZpbmlzaGVkLiBPVE9IIGlmIHRoZSBpbnRlcnJ1cHQgd2Vy ZQpkZWxheWVkIGEgbGl0dGxlIGJpdCBtb3JlLCB0aGlzIGNvZGUgbWlnaHQgc3RpbGwgZ2V0IHRv IHRha2UgdGhlCnNwaW5sb2NrIGJlZm9yZSB0aGUgaGFuZGxlciwgc28gdGhlIHVuZXhwZWN0ZWQg dmFsdWUgd291bGQgc3RpbGwgYmUgc2VlbiA6KAoKTWF5YmUgeW91IG5lZWQgYSB0d28tcGhhc2Ug dW5pbnN0YWxsPwoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==