From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH 1/2] drm/i915: Split adding request to smaller functions Date: Thu, 19 Feb 2015 16:54:33 +0000 Message-ID: <54E61549.504@Intel.com> References: <1424362735-10569-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 96A236E600 for ; Thu, 19 Feb 2015 08:54:44 -0800 (PST) In-Reply-To: <1424362735-10569-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UGxlYXNlIG5vdGUgdGhhdCBhIGxvdCBvZiB0aGUgaXNzdWVzIHdpdGggX2k5MTVfYWRkX3JlcXVl c3QgYXJlIGNsZWFuZWQgCnVwIGJ5IG15IHBhdGNoIHNlcmllcyB0byByZW1vdmUgdGhlIG91dHN0 YW5kaW5nX2xhenlfcmVxdWVzdC4gVGhlIGFkZCB0byAKY2xpZW50IGluIHNvbWUgcmFuZG9tIGNs aWVudCBjb250ZXh0IGlzIGZpeGVkLCB0aGUgbWVzc3kgZXhlY2xpc3QgdnMgCmxlZ2FjeSByaW5n YnVmIGRlY2lzaW9ucyBhcmUgcmVtb3ZlZCwgdGhlIGV4ZWNsaXN0IHZzIGxlZ2FjeSBvbmUtc2lk ZWQgCmNvbnRleHQgcmVmZXJlbmNlIGlzIHJlbW92ZWQsIC4uLgoKQWxzbywgSSBhbSBpbiB0aGUg cHJvY2VzcyBvZiBjb252ZXJ0aW5nIHRoZSByZXF1ZXN0IHN0cnVjdHVyZSB0byB1c2UgCnN0cnVj dCBmZW5jZSB3aGljaCB3aWxsIHBvc3NpYmx5IGFuc3dlciBzb21lIG9mIHlvdXIgbG9ja2luZyBj b25jZXJucyBpbiAKdGhlIHN1YnNlcXVlbnQgcGF0Y2guCgpTbyBjYW4geW91IGhvbGQgb2Ygb24g bWVyZ2luZyB0aGVzZSB0d28gcGF0Y2hlcyBhdCBsZWFzdCB1bnRpbCB0aGUgZHVzdCAKaGFzIHNl dHRsZWQgb24gdGhlIGFudGktT0xSIHNlcmllcz8KClRoYW5rcy4KCgpPbiAxOS8wMi8yMDE1IDE2 OjE4LCBNaWthIEt1b3BwYWxhIHdyb3RlOgo+IENsZWFuIF9faTkxNV9hZGRfcmVxdWVzdCBieSBz cGxpdHRpbmcgcmVxdWVzdCBzdWJtaXNzaW9uIHRvCj4gcHJlcGFyYXRpb24sIGFjdHVhbCBzdWJt aXNzaW9uIGFuZCBhZGRpbmcgdG8gY2xpZW50Lgo+Cj4gV2hpbGUgZG9pbmcgdGhpcyB3ZSBjYW4g cmVtb3ZlIHRoZSByZXF1ZXN0LT5zdGFydCB3aGljaAo+IHdhcyBub3QgdXNlZC4KPgo+IENjOiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBTaWduZWQtb2ZmLWJ5OiBN aWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAxMTYgKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDc4IGluc2VydGlvbnMoKyksIDM4IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggNjExMzRhYi4uMDYy NjVlNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0yNDA3LDI2ICsyNDA3LDM0 IEBAIGk5MTVfZ2VtX2dldF9zZXFubyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1MzIgKnNlcW5v KQo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gLWludCBfX2k5MTVfYWRkX3JlcXVlc3Qoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiAtCQkgICAgICAgc3RydWN0IGRybV9maWxlICpm aWxlLAo+IC0JCSAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICtzdGF0 aWMgc3RydWN0IGludGVsX3JpbmdidWZmZXIgKgo+ICtfX3JlcXVlc3RfdG9fcmluZ2J1ZihzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gK3sKPiArCWlmIChpOTE1LmVuYWJs ZV9leGVjbGlzdHMpCj4gKwkJcmV0dXJuIHJlcXVlc3QtPmN0eC0+ZW5naW5lW3JlcXVlc3QtPnJp bmctPmlkXS5yaW5nYnVmOwo+ICsKPiArCXJldHVybiByZXF1ZXN0LT5yaW5nLT5idWZmZXI7Cj4g K30KPiArCj4gK3N0YXRpYyBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKgo+ICtpOTE1X2dl bV9yZXF1ZXN0X3ByZXBhcmUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywgc3RydWN0IGRy bV9maWxlICpmaWxlKQo+ICAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gcmluZy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVl c3QgKnJlcXVlc3Q7Cj4gICAJc3RydWN0IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWY7Cj4gLQl1 MzIgcmVxdWVzdF9zdGFydDsKPiAgIAlpbnQgcmV0Owo+ICAgCj4gICAJcmVxdWVzdCA9IHJpbmct Pm91dHN0YW5kaW5nX2xhenlfcmVxdWVzdDsKPiAgIAlpZiAoV0FSTl9PTihyZXF1ZXN0ID09IE5V TEwpKQo+IC0JCXJldHVybiAtRU5PTUVNOwo+ICsJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwo+ ICAgCj4gLQlpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4gLQkJcmluZ2J1ZiA9IHJlcXVl c3QtPmN0eC0+ZW5naW5lW3JpbmctPmlkXS5yaW5nYnVmOwo+IC0JfSBlbHNlCj4gLQkJcmluZ2J1 ZiA9IHJpbmctPmJ1ZmZlcjsKPiArCS8qIGV4ZWNsaXN0IHN1Ym1pc3Npb24gaGFzIHRoaXMgYWxy ZWFkeSBzZXQgKi8KPiArCWlmICghcmVxdWVzdC0+Y3R4KQo+ICsJCXJlcXVlc3QtPmN0eCA9IHJp bmctPmxhc3RfY29udGV4dDsKPiArCj4gKwlyaW5nYnVmID0gX19yZXF1ZXN0X3RvX3JpbmdidWYo cmVxdWVzdCk7Cj4gKwlpZiAoV0FSTl9PTihyaW5nYnVmID09IE5VTEwpKQo+ICsJCXJldHVybiBF UlJfUFRSKC1FSU8pOwo+ICAgCj4gLQlyZXF1ZXN0X3N0YXJ0ID0gaW50ZWxfcmluZ19nZXRfdGFp bChyaW5nYnVmKTsKPiAgIAkvKgo+ICAgCSAqIEVtaXQgYW55IG91dHN0YW5kaW5nIGZsdXNoZXMg LSBleGVjYnVmIGNhbiBmYWlsIHRvIGVtaXQgdGhlIGZsdXNoCj4gICAJICogYWZ0ZXIgaGF2aW5n IGVtaXR0ZWQgdGhlIGJhdGNoYnVmZmVyIGNvbW1hbmQuIEhlbmNlIHdlIG5lZWQgdG8gZml4Cj4g QEAgLTI0MzQsMjEgKzI0NDIsMzAgQEAgaW50IF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICpyaW5nLAo+ICAgCSAqIGlzIHRoYXQgdGhlIGZsdXNoIF9tdXN0XyBoYXBw ZW4gYmVmb3JlIHRoZSBuZXh0IHJlcXVlc3QsIG5vIG1hdHRlcgo+ICAgCSAqIHdoYXQuCj4gICAJ ICovCj4gLQlpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4gKwlpZiAoaTkxNS5lbmFibGVf ZXhlY2xpc3RzKQo+ICAgCQlyZXQgPSBsb2dpY2FsX3JpbmdfZmx1c2hfYWxsX2NhY2hlcyhyaW5n YnVmLCByZXF1ZXN0LT5jdHgpOwo+IC0JCWlmIChyZXQpCj4gLQkJCXJldHVybiByZXQ7Cj4gLQl9 IGVsc2Ugewo+ICsJZWxzZQo+ICAgCQlyZXQgPSBpbnRlbF9yaW5nX2ZsdXNoX2FsbF9jYWNoZXMo cmluZyk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0dXJuIHJldDsKPiAtCX0KPiArCj4gKwlpZiAo cmV0KQo+ICsJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gKwo+ICsJcmV0dXJuIHJlcXVlc3Q7Cj4g K30KPiArCj4gK3N0YXRpYyBpbnQgaTkxNV9nZW1fcmVxdWVzdF9zdWJtaXQoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LAo+ICsJCQkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKmJhdGNoKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZiA9 IF9fcmVxdWVzdF90b19yaW5nYnVmKHJlcXVlc3QpOwo+ICsJc3RydWN0IGludGVsX2VuZ2luZV9j cyAqcmluZyA9IHJlcXVlc3QtPnJpbmc7Cj4gKwlpbnQgcmV0Owo+ICAgCj4gICAJLyogUmVjb3Jk IHRoZSBwb3NpdGlvbiBvZiB0aGUgc3RhcnQgb2YgdGhlIHJlcXVlc3Qgc28gdGhhdAo+ICAgCSAq IHNob3VsZCB3ZSBkZXRlY3QgdGhlIHVwZGF0ZWQgc2Vxbm8gcGFydC13YXkgdGhyb3VnaCB0aGUK PiAgIAkgKiBHUFUgcHJvY2Vzc2luZyB0aGUgcmVxdWVzdCwgd2UgbmV2ZXIgb3Zlci1lc3RpbWF0 ZSB0aGUKPiAgIAkgKiBwb3NpdGlvbiBvZiB0aGUgaGVhZC4KPiAgIAkgKi8KPiArCXJlcXVlc3Qt PmJhdGNoX29iaiA9IGJhdGNoOwo+ICAgCXJlcXVlc3QtPnBvc3RmaXggPSBpbnRlbF9yaW5nX2dl dF90YWlsKHJpbmdidWYpOwo+ICAgCj4gICAJaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykgewo+ IEBAIC0yNDYxLDcgKzI0NzgsNiBAQCBpbnQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKnJpbmcsCj4gICAJCQlyZXR1cm4gcmV0Owo+ICAgCX0KPiAgIAo+IC0JcmVx dWVzdC0+aGVhZCA9IHJlcXVlc3Rfc3RhcnQ7Cj4gICAJcmVxdWVzdC0+dGFpbCA9IGludGVsX3Jp bmdfZ2V0X3RhaWwocmluZ2J1Zik7Cj4gICAKPiAgIAkvKiBXaGlsc3QgdGhpcyByZXF1ZXN0IGV4 aXN0cywgYmF0Y2hfb2JqIHdpbGwgYmUgb24gdGhlCj4gQEAgLTI0NzAsMzUgKzI0ODYsNTkgQEAg aW50IF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+ICAg CSAqIGluYWN0aXZlX2xpc3QgYW5kIGxvc2UgaXRzIGFjdGl2ZSByZWZlcmVuY2UuIEhlbmNlIHdl IGRvIG5vdCBuZWVkCj4gICAJICogdG8gZXhwbGljaXRseSBob2xkIGFub3RoZXIgcmVmZXJlbmNl IGhlcmUuCj4gICAJICovCj4gLQlyZXF1ZXN0LT5iYXRjaF9vYmogPSBvYmo7Cj4gICAKPiAtCWlm ICghaTkxNS5lbmFibGVfZXhlY2xpc3RzKSB7Cj4gLQkJLyogSG9sZCBhIHJlZmVyZW5jZSB0byB0 aGUgY3VycmVudCBjb250ZXh0IHNvIHRoYXQgd2UgY2FuIGluc3BlY3QKPiAtCQkgKiBpdCBsYXRl ciBpbiBjYXNlIGEgaGFuZ2NoZWNrIGVycm9yIGV2ZW50IGZpcmVzLgo+ICsJaWYgKCFpOTE1LmVu YWJsZV9leGVjbGlzdHMgJiYgcmVxdWVzdC0+Y3R4KSB7Cj4gKwkJLyogSG9sZCBhIHJlZmVyZW5j ZSB0byB0aGUgY3VycmVudCBjb250ZXh0IHNvIHRoYXQgd2UgY2FuCj4gKwkJICogaW5zcGVjdCBp dCBsYXRlciBpbiBjYXNlIGEgaGFuZ2NoZWNrIGVycm9yIGV2ZW50IGZpcmVzLgo+ICAgCQkgKi8K PiAtCQlyZXF1ZXN0LT5jdHggPSByaW5nLT5sYXN0X2NvbnRleHQ7Cj4gLQkJaWYgKHJlcXVlc3Qt PmN0eCkKPiAtCQkJaTkxNV9nZW1fY29udGV4dF9yZWZlcmVuY2UocmVxdWVzdC0+Y3R4KTsKPiAr CQlpOTE1X2dlbV9jb250ZXh0X3JlZmVyZW5jZShyZXF1ZXN0LT5jdHgpOwo+ICAgCX0KPiAgIAo+ ICAgCXJlcXVlc3QtPmVtaXR0ZWRfamlmZmllcyA9IGppZmZpZXM7Cj4gKwo+ICAgCWxpc3RfYWRk X3RhaWwoJnJlcXVlc3QtPmxpc3QsICZyaW5nLT5yZXF1ZXN0X2xpc3QpOwo+IC0JcmVxdWVzdC0+ ZmlsZV9wcml2ID0gTlVMTDsKPiArCXJpbmctPm91dHN0YW5kaW5nX2xhenlfcmVxdWVzdCA9IE5V TEw7Cj4gICAKPiAtCWlmIChmaWxlKSB7Cj4gLQkJc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0 ZSAqZmlsZV9wcml2ID0gZmlsZS0+ZHJpdmVyX3ByaXY7Cj4gKwl0cmFjZV9pOTE1X2dlbV9yZXF1 ZXN0X2FkZChyZXF1ZXN0KTsKPiAgIAo+IC0JCXNwaW5fbG9jaygmZmlsZV9wcml2LT5tbS5sb2Nr KTsKPiAtCQlyZXF1ZXN0LT5maWxlX3ByaXYgPSBmaWxlX3ByaXY7Cj4gLQkJbGlzdF9hZGRfdGFp bCgmcmVxdWVzdC0+Y2xpZW50X2xpc3QsCj4gLQkJCSAgICAgICZmaWxlX3ByaXYtPm1tLnJlcXVl c3RfbGlzdCk7Cj4gLQkJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gKwlyZXR1 cm4gMDsKPiArfQo+ICAgCj4gLQkJcmVxdWVzdC0+cGlkID0gZ2V0X3BpZCh0YXNrX3BpZChjdXJy ZW50KSk7Cj4gLQl9Cj4gK3N0YXRpYyB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfYWRkX3RvX2NsaWVu dChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gK3sKPiArCXN0cnVjdCBk cm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdjsKPiAgIAo+IC0JdHJhY2VfaTkxNV9nZW1f cmVxdWVzdF9hZGQocmVxdWVzdCk7Cj4gLQlyaW5nLT5vdXRzdGFuZGluZ19sYXp5X3JlcXVlc3Qg PSBOVUxMOwo+ICsJaWYgKCFyZXF1ZXN0LT5maWxlX3ByaXYpCj4gKwkJcmV0dXJuOwo+ICsKPiAr CWZpbGVfcHJpdiA9IHJlcXVlc3QtPmZpbGVfcHJpdjsKPiArCj4gKwlzcGluX2xvY2soJmZpbGVf cHJpdi0+bW0ubG9jayk7Cj4gKwlyZXF1ZXN0LT5maWxlX3ByaXYgPSBmaWxlX3ByaXY7Cj4gKwls aXN0X2FkZF90YWlsKCZyZXF1ZXN0LT5jbGllbnRfbGlzdCwKPiArCQkgICAgICAmZmlsZV9wcml2 LT5tbS5yZXF1ZXN0X2xpc3QpOwo+ICsJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7 Cj4gKwo+ICsJcmVxdWVzdC0+cGlkID0gZ2V0X3BpZCh0YXNrX3BpZChjdXJyZW50KSk7Cj4gK30K PiArCj4gK2ludCBfX2k5MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmlu ZywKPiArCQkgICAgICAgc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICsJCSAgICAgICBzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqYmF0Y2gpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHJpbmctPmRldi0+ZGV2X3ByaXZhdGU7Cj4gKwlzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3Q7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXJlcXVlc3QgPSBp OTE1X2dlbV9yZXF1ZXN0X3ByZXBhcmUocmluZywgZmlsZSk7Cj4gKwlpZiAoSVNfRVJSKHJlcXVl c3QpKQo+ICsJCXJldHVybiBQVFJfRVJSKHJlcXVlc3QpOwo+ICsKPiArCXJldCA9IGk5MTVfZ2Vt X3JlcXVlc3Rfc3VibWl0KHJlcXVlc3QsIGJhdGNoKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJu IHJldDsKPiArCj4gKwlpOTE1X2dlbV9yZXF1ZXN0X2FkZF90b19jbGllbnQocmVxdWVzdCk7Cj4g ICAKPiAgIAlpOTE1X3F1ZXVlX2hhbmdjaGVjayhyaW5nLT5kZXYpOwo+ICAgCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=