From mboxrd@z Thu Jan 1 00:00:00 1970 From: Todd Previte Subject: Re: [PATCH] drm/i915: DP link training optimization Date: Thu, 26 Feb 2015 18:29:45 -0700 Message-ID: <54EFC889.5000504@gmail.com> References: <1424942770-14493-1-git-send-email-mika.kahola@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A2DB6E831 for ; Thu, 26 Feb 2015 17:29:46 -0800 (PST) Received: by pabli10 with SMTP id li10so2459024pab.0 for ; Thu, 26 Feb 2015 17:29:45 -0800 (PST) Received: from [192.168.0.30] (ip70-162-72-208.ph.ph.cox.net. [70.162.72.208]) by mx.google.com with ESMTPSA id br14sm2190312pdb.38.2015.02.26.17.29.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2015 17:29:45 -0800 (PST) In-Reply-To: <1424942770-14493-1-git-send-email-mika.kahola@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWlrYSwKCk9uIDIvMjYvMjAxNSAyOjI2IEFNLCBNaWthIEthaG9sYSB3cm90ZToKPiBJbiBh IGNhc2Ugd2hlbiBEUCBsaW5rIGhhcyBiZWVuIG9uY2UgdHJhaW5lZCB3ZSBjYW4gcmV1c2UKPiB0 aGUgZXhpc3RpbmcgbGluayB0cmFpbmluZyBwYXJhbWV0ZXJzIGkuZS4gdm9sdGFnZSBzd2luZwo+ IGFuZCBwcmUtZW1waGFzaXMgbGV2ZWxzIGZyb20gY2FjaGUgd2hlbiB0aGVyZSBpcyBhIG5lZWQg dG8KPiByZXN0YXJ0IGxpbmsgdHJhaW5pbmcuIEluIGEgY2FzZSBvZiBlRFAgd2UgaW5pdGlhbGx5 IHRyeQo+IHRvIHRyYWluIHRoZSBsaW5rIGJ5IHVzaW5nIHRoZSBwYXJhbWV0ZXIgc2V0IHRoYXQg d2UgY2FuIGZpbmQKPiBmcm9tIFZCVC4gVGhlIGZhbGxiYWNrIG9uIGJvdGggY2FzZXMgaXMgdG8g cmVzZXQgdGhlIGxpbmsKPiB0cmFpbmluZyBwYXJhbWV0ZXJzIGFuZCByZXN0YXJ0LgpJIHRoaW5r IHlvdSBoYXZlIGEgZ29vZCBpZGVhIGhlcmUgZm9yIHRoZSBlRFAgY2FzZS4gQnV0IHRoZSB3YXkg aXQncyAKY29kZWQsIHRoZXJlIGFwcGVhciB0byBiZSBjYXNlcyB3aGVyZSB0aGUgY29kZSB3aWxs IHRyeSB0byByZXVzZSB0aGUgCnNhbWUgdHJhaW5pbmcgc2V0dGluZ3MgZm9yIHJlZ3VsYXIgRFAg YXMgd2VsbC4gVGhhdCB3aWxsIGxpa2VseSBoYXZlIApzb21lIHVuZm9ydHVuYXRlIHJlc3VsdHMs IGFzIHRoZXJlJ3Mgbm8gZ3VhcmFudGVlIGZvciBhIG5vcm1hbCBleHRlcm5hbCAKRGlzcGxheXBv cnQgY29ubmVjdGlvbiB0aGF0IHRyYWluaW5nIHNldHRpbmdzIHdoaWNoIHdvcmtlZCBvbmNlIHdp bGwgCndvcmsgdGhlIG5leHQgdGltZS4gVGhpcyB3b3VsZCBiZSBvZiBwYXJ0aWN1bGFyIGNvbmNl cm4gd2hlbiAKZGlzY29ubmVjdGluZyBhbmQgcmVjb25uZWN0aW5nIERpc3BsYXlwb3J0IHNpbmsg ZGV2aWNlcywgYXMgaXQgYXBwZWFycyAKYXMgdGhvdWdoIGl0IHdvdWxkIHRyeSB0byByZXRyYWlu IHRoZSBuZXdseSBjb25uZWN0ZWQgZGV2aWNlIHVzaW5nIHRoZSAKcHJldmlvdXNseSB2YWxpZCBz ZXR0aW5ncyBmb3IgdGhlIG9sZCBkZXZpY2UuCgpJTUhPLCB0aGlzIHJlYWxseSBuZWVkcyB0byBi ZSB3cml0dGVuIGFzIGVEUCBvbmx5IGFuZCBzdWNoIHRoYXQgaXQgY2FuIApuZXZlciBvY2N1ciBv biBhbiBleHRlcm5hbCBEaXNwbGF5cG9ydCBkZXZpY2UuIE90aGVyd2lzZSwgaXQgc2VlbXMgbGlr ZSAKdGhlcmUncyBhIGdvb2QgY2hhbmNlIG9mIGVuZGluZyB1cCB3aXRoIGEgYmxhY2sgc2NyZWVu IHdoZW4geW91IHBsdWcgaW4gCmEgRGlzcGxheXBvcnQgbW9uaXRvci4KCj4gU2lnbmVkLW9mZi1i eTogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgOTMgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggfCAgMSAr Cj4gICAyIGZpbGVzIGNoYW5nZWQsIDg0IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggZDExNDFkMy4uODQ4MmY1OCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0zMjg4LDggKzMyODgsMzkgQEAgc3RhdGljIGJv b2wKPiAgIGludGVsX2RwX3Jlc2V0X2xpbmtfdHJhaW4oc3RydWN0IGludGVsX2RwICppbnRlbF9k cCwgdWludDMyX3QgKkRQLAo+ICAgCQkJdWludDhfdCBkcF90cmFpbl9wYXQpCj4gICB7Cj4gLQlt ZW1zZXQoaW50ZWxfZHAtPnRyYWluX3NldCwgMCwgc2l6ZW9mKGludGVsX2RwLT50cmFpbl9zZXQp KTsKPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9f ZGlnX3BvcnQoaW50ZWxfZHApOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2Rp Z19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCWludCBpOwo+ICsKPiArCS8qIGluIGNhc2Ugb2Yg ZURQLCBnZXQgbGluayB0cmFpbmluZyBwYXJhbWV0ZXJzIGZyb20gVkJUICovCj4gKwlpZiAoaXNf ZWRwKGludGVsX2RwKSkgewo+ICsJCWZvciAoaT0wOyBpPGludGVsX2RwLT5sYW5lX2NvdW50OyBp KyspCj4gKwkJCWludGVsX2RwLT50cmFpbl9zZXRbaV0gPSAgZGV2X3ByaXYtPnZidC5lZHBfdnN3 aW5nIHwgZGV2X3ByaXYtPnZidC5lZHBfcHJlZW1waGFzaXM7Cj4gKwl9Cj4gKwllbHNlCj4gKwkJ bWVtc2V0KGludGVsX2RwLT50cmFpbl9zZXQsIDAsIHNpemVvZihpbnRlbF9kcC0+dHJhaW5fc2V0 KSk7Cj4gKwo+ICsJaW50ZWxfZHBfc2V0X3NpZ25hbF9sZXZlbHMoaW50ZWxfZHAsIERQKTsKPiAr CXJldHVybiBpbnRlbF9kcF9zZXRfbGlua190cmFpbihpbnRlbF9kcCwgRFAsIGRwX3RyYWluX3Bh dCk7Cj4gK30KPiArCj4gK3N0YXRpYyBib29sCj4gK2ludGVsX2RwX3JldXNlX2xpbmtfdHJhaW4o c3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdWludDMyX3QgKkRQLAo+ICsJCQkgIHVpbnQ4X3Qg ZHBfdHJhaW5fcGF0KQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9k aWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRldjsKPiArCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwo+ICAgCWludGVsX2Rw X3NldF9zaWduYWxfbGV2ZWxzKGludGVsX2RwLCBEUCk7Cj4gKwo+ICsJSTkxNV9XUklURShpbnRl bF9kcC0+b3V0cHV0X3JlZywgKkRQKTsKPiArCVBPU1RJTkdfUkVBRChpbnRlbF9kcC0+b3V0cHV0 X3JlZyk7Cj4gKwo+ICsJZHJtX2RwX2RwY2Rfd3JpdGUoJmludGVsX2RwLT5hdXgsIERQX1RSQUlO SU5HX0xBTkUwX1NFVCwKPiArCQkJICBpbnRlbF9kcC0+dHJhaW5fc2V0LCBpbnRlbF9kcC0+bGFu ZV9jb3VudCk7Cj4gKwo+ICAgCXJldHVybiBpbnRlbF9kcF9zZXRfbGlua190cmFpbihpbnRlbF9k cCwgRFAsIGRwX3RyYWluX3BhdCk7Cj4gICB9Cj4gICAKSSdtIG5vdCBzdXJlIHlvdSB3YW50IHRv IGJlIHVwZGF0aW5nIHRoZSBzaW5rIGRldmljZSBhdCB0aGlzIHBvaW50LiBUaGlzIApzaG91bGQg YmUgY2hlY2tlZCBhZ2FpbnN0IHRoZSBzcGVjIHRvIGJlIHN1cmUgaXQncyBub3Qgb3V0IG9mIHNl cXVlbmNlLgoKPiBAQCAtMzM1Niw2ICszMzg3LDggQEAgaW50ZWxfZHBfc3RhcnRfbGlua190cmFp bihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAgCWludCB2b2x0YWdlX3RyaWVzLCBsb29w X3RyaWVzOwo+ICAgCXVpbnQzMl90IERQID0gaW50ZWxfZHAtPkRQOwo+ICAgCXVpbnQ4X3QgbGlu a19jb25maWdbMl07Cj4gKwl1aW50OF90IGxpbmtfc3RhdHVzW0RQX0xJTktfU1RBVFVTX1NJWkVd Owo+ICsJYm9vbCByZXVzZV90cmFpbl9zZXQgPSBmYWxzZTsKPiAgIAo+ICAgCWlmIChIQVNfRERJ KGRldikpCj4gICAJCWludGVsX2RkaV9wcmVwYXJlX2xpbmtfcmV0cmFpbihlbmNvZGVyKTsKPiBA QCAtMzM3MywyMCArMzQwNiw0NCBAQCBpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApCj4gICAKPiAgIAlEUCB8PSBEUF9QT1JUX0VOOwo+ICAgCj4gLQkv KiBjbG9jayByZWNvdmVyeSAqLwo+IC0JaWYgKCFpbnRlbF9kcF9yZXNldF9saW5rX3RyYWluKGlu dGVsX2RwLCAmRFAsCj4gLQkJCQkgICAgICAgRFBfVFJBSU5JTkdfUEFUVEVSTl8xIHwKPiAtCQkJ CSAgICAgICBEUF9MSU5LX1NDUkFNQkxJTkdfRElTQUJMRSkpIHsKPiAtCQlEUk1fRVJST1IoImZh aWxlZCB0byBlbmFibGUgbGluayB0cmFpbmluZ1xuIik7Cj4gLQkJcmV0dXJuOwo+ICsJLyoKPiAr CSAqIGNoZWNrIGlmIERQIGhhcyBhbHJlYWR5IHRyYWluZWQuIFJlc2V0IHZvbHRhZ2Ugc3dpbmcg YW5kCj4gKwkgKiBwcmUtZW1waGFzaXMgbGV2ZWxzIGlmIHRoYXQncyBub3QgdGhlIGNhc2UuCj4g KwkgKi8KPiArCWlmIChpbnRlbF9kcC0+bGlua190cmFpbmVkKSB7Cj4gKwkJaWYgKCFpbnRlbF9k cF9yZXVzZV9saW5rX3RyYWluKGludGVsX2RwLCAmRFAsCj4gKwkJCQkJICAgICAgIERQX1RSQUlO SU5HX1BBVFRFUk5fMSB8Cj4gKwkJCQkJICAgICAgIERQX0xJTktfU0NSQU1CTElOR19ESVNBQkxF KSkgewo+ICsJCQlEUk1fREVCVUdfS01TKCJ1bmFibGUgdG8gc2V0IGtub3duIGxpbmsgdHJhaW5p bmcgdmFsdWVzXG4iKTsKPiArCQkJcmV0dXJuOwo+ICsJCX0KPiArCQlEUk1fREVCVUdfS01TKCJy ZXVzZSBjdXJyZW50IGxpbmsgdHJhaW4gc2V0XG4iKTsKPiArCQlyZXVzZV90cmFpbl9zZXQgPSB0 cnVlOwo+ICsJfQo+ICsJZWxzZSB7Cj4gKwkJLyogcmVzZXQgbGluayB0cmFpbmluZyB2YWx1ZXMg Ki8KPiArCQlpZiAoIWludGVsX2RwX3Jlc2V0X2xpbmtfdHJhaW4oaW50ZWxfZHAsICZEUCwKPiAr CQkJCQkgICAgICAgRFBfVFJBSU5JTkdfUEFUVEVSTl8xIHwKPiArCQkJCQkgICAgICAgRFBfTElO S19TQ1JBTUJMSU5HX0RJU0FCTEUpKSB7Cj4gKwkJCURSTV9FUlJPUigiZmFpbGVkIHRvIGVuYWJs ZSBsaW5rIHRyYWluaW5nXG4iKTsKPiArCQkJcmV0dXJuOwo+ICsJCX0KPiArCQlEUk1fREVCVUdf S01TKCJyZXNldCBsaW5rIHRyYWluIHNldFxuIik7Cj4gKwo+ICsJCS8qCj4gKwkJICogaW4gY2Fz ZSBvZiBlRFAsIGFsbG93IGZhbGxiYWNrIHRvIHJlc2V0IGxpbmsgdHJhaW5pbmcgc2V0Cj4gKwkJ ICogaWYgVkJUIHBhcmFtZXRlcnMgZG9lc24ndCBhcHBseQo+ICsJCSAqLwo+ICsJCWlmIChpc19l ZHAoaW50ZWxfZHApKQo+ICsJCQlyZXVzZV90cmFpbl9zZXQgPSB0cnVlOwo+ICsJCWVsc2UKPiAr CQkJcmV1c2VfdHJhaW5fc2V0ID0gZmFsc2U7Cj4gICAJfQo+ICAgCj4gICAJdm9sdGFnZSA9IDB4 ZmY7Cj4gICAJdm9sdGFnZV90cmllcyA9IDA7Cj4gICAJbG9vcF90cmllcyA9IDA7Cj4gICAJZm9y ICg7Oykgewo+IC0JCXVpbnQ4X3QgbGlua19zdGF0dXNbRFBfTElOS19TVEFUVVNfU0laRV07Cj4g LQo+ICAgCQlkcm1fZHBfbGlua190cmFpbl9jbG9ja19yZWNvdmVyeV9kZWxheShpbnRlbF9kcC0+ ZHBjZCk7Cj4gICAJCWlmICghaW50ZWxfZHBfZ2V0X2xpbmtfc3RhdHVzKGludGVsX2RwLCBsaW5r X3N0YXR1cykpIHsKPiAgIAkJCURSTV9FUlJPUigiZmFpbGVkIHRvIGdldCBsaW5rIHN0YXR1c1xu Iik7Cj4gQEAgLTMzOTcsNiArMzQ1NCwyMCBAQCBpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gICAJCQlEUk1fREVCVUdfS01TKCJjbG9jayByZWNv dmVyeSBPS1xuIik7Cj4gICAJCQlicmVhazsKPiAgIAkJfQo+ICsJCS8qCj4gKwkJICogaWYgd2Ug dXNlZCBwcmV2aW91c2x5IHRyYWluZWQgdm9sdGFnZSBhbmQgcHJlLWVtcGhhc2lzIHZhbHVlcwo+ ICsJCSAqIGFuZCB3ZSBkb24ndCBnZXQgY2xvY2sgcmVjb3ZlcnksIHJlc2V0IGxpbmsgdHJhaW5p bmcgdmFsdWVzCj4gKwkJICovCj4gKwkJaWYgKHJldXNlX3RyYWluX3NldCkgewo+ICsJCQlEUk1f REVCVUdfS01TKCJjbG9jayByZWNvdmVyeSBub3Qgb2ssIHJlc2V0dGluZyBEUCB0cmFpbiBzZXRc biIpOwo+ICsJCQlpZiAoIWludGVsX2RwX3Jlc2V0X2xpbmtfdHJhaW4oaW50ZWxfZHAsICZEUCwK PiArCQkJCQkJICAgICAgIERQX1RSQUlOSU5HX1BBVFRFUk5fMSB8Cj4gKwkJCQkJCSAgICAgICBE UF9MSU5LX1NDUkFNQkxJTkdfRElTQUJMRSkpIHsKPiArCQkJCURSTV9FUlJPUigiZmFpbGVkIHRv IGVuYWJsZSBsaW5rIHRyYWluaW5nXG4iKTsKPiArCQkJCXJldHVybjsKPiArCQkJfQo+ICsJCQly ZXVzZV90cmFpbl9zZXQgPSBmYWxzZTsKPiArCQl9Cj4gICAKPiAgIAkJLyogQ2hlY2sgdG8gc2Vl IGlmIHdlJ3ZlIHRyaWVkIHRoZSBtYXggdm9sdGFnZSAqLwo+ICAgCQlmb3IgKGkgPSAwOyBpIDwg aW50ZWxfZHAtPmxhbmVfY291bnQ7IGkrKykKPiBAQCAtMzUxMSw4ICszNTgyLDEwIEBAIGludGVs X2RwX2NvbXBsZXRlX2xpbmtfdHJhaW4oc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgIAo+ ICAgCWludGVsX2RwLT5EUCA9IERQOwo+ICAgCj4gLQlpZiAoY2hhbm5lbF9lcSkKPiArCWlmIChj aGFubmVsX2VxKSB7Cj4gICAJCURSTV9ERUJVR19LTVMoIkNoYW5uZWwgRVEgZG9uZS4gRFAgVHJh aW5pbmcgc3VjY2Vzc2Z1bFxuIik7Cj4gKwkJaW50ZWxfZHAtPmxpbmtfdHJhaW5lZCA9IHRydWU7 ClRoZSBsaW5rX3RyYWluZWQgZmxhZyBpcyBzZXQgaGVyZSBidXQgbmV2ZXIgaW5pdGlhbGl6ZWQg b3IgY2xlYXJlZCAKYW55d2hlcmUgZWxzZS4gU28gaXQgbG9va3MgbGlrZSBvbmNlIGl0J3Mgc2V0 LCBpdCdzIHRoZXJlIGZvcmV2ZXIuIFRoYXQgCmJlaW5nIHRoZSBjYXNlLCB0aGlzIGNvZGUgd291 bGQgbmV2ZXIgaGl0IHRoZSBlbHNlKCkgY2FzZSB3aGVyZSAKaW50ZWxfZHAtPmxpbmtfdHJhaW5l ZCBpcyBjaGVja2VkIGZ1cnRoZXIgdXAuIEknbSBwcmV0dHkgc3VyZSB0aGF0J3Mgbm90IAp3aGF0 IHlvdSBpbnRlbmRlZC4uLiA6KQoKPiArCX0KPiAgIAo+ICAgfQo+ICAgCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmgKPiBpbmRleCAxZmIxNTI5Li4zMmVjZTBkIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmgKPiBAQCAtNjY4LDYgKzY2OCw3IEBAIHN0cnVjdCBpbnRlbF9kcCB7Cj4gICAJ CQkJICAgICBib29sIGhhc19hdXhfaXJxLAo+ICAgCQkJCSAgICAgaW50IHNlbmRfYnl0ZXMsCj4g ICAJCQkJICAgICB1aW50MzJfdCBhdXhfY2xvY2tfZGl2aWRlcik7Cj4gKwlib29sIGxpbmtfdHJh aW5lZDsgLyogZmxhZyB0byBpbmRpY2F0ZSBpZiBEUCBsaW5rIGhhcyBiZWVuIHRyYWluZWQgb3Ig bm90ICovCj4gICB9Owo+ICAgCj4gICBzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0IHsKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==