From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 6/8] drm/i915/skl: Updated watermark programming Date: Fri, 27 Feb 2015 09:34:19 +0000 Message-ID: <54F03A1B.3080506@linux.intel.com> References: <1424882844-19444-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1424882844-19444-7-git-send-email-tvrtko.ursulin@linux.intel.com> <20150226164512.GB2053@strange.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C9C36E194 for ; Fri, 27 Feb 2015 01:34:22 -0800 (PST) In-Reply-To: <20150226164512.GB2053@strange.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzI2LzIwMTUgMDQ6NDUgUE0sIERhbWllbiBMZXNwaWF1IHdyb3RlOgo+IE9uIFdlZCwg RmViIDI1LCAyMDE1IGF0IDA0OjQ3OjIyUE0gKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+ PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBS ZWNlbnQgQlNwZWN0IHVwZGF0ZXMgaGF2ZSBjaGFuZ2VkIHRoZSB3YXRlcm1hcmsgY2FsY3VsYXRp b24gdG8gYXZvaWQKPj4gZGlzcGxheSBmbGlja2VyaW5nIGluIHNvbWUgY2FzZXMuCj4+Cj4+IFNp Z25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+ IC0tLQo+Cj4gVGhlcmUgYXJlIHJlYWxseSBzZXZlcmFsIGNoYW5nZXMgaW4gdGhpcyBwYXRjaCwg aXQgd291bGQgaGF2ZSBiZWVuCj4gZWFzaWVyIGZvciB0aGUgcmV2aWV3IHRvIHNwbGl0IHRoZW0g KGFuZCB0aGF0J3MgdXN1YWxseSBob3cgd2UgYXJlCj4gc3VwcG9zZWQgdG8gc3BsaXQgcGF0Y2hl cykuCgogRnJvbSBteSBwb2ludCBvZiB2aWV3IC0gdGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBjb21w dXRhdGlvbiBmcm9tIHdoYXQgaXQgCndhcyBkb2N1bWVudGVkIHR3byB3ZWVrcyBhZ28sIHRvIHdo YXQgd2FzIGRvY3VtZW50ZWQgb25lIHdlZWsgYWdvLiBJIApkb24ndCBzZWUgdGhhdCBpdCB3b3Vs ZCBiZSBuYXR1cmFsIHRvIGJlIHNvIGludmVudGl2ZSB0byBzdGFydCBzcGxpdHRpbmcgCnRoYXQu Cgo+ICAgIC0gQ29udmVydCB0aGUgaW5uZXIgY29tcHV0YXRpb25zIHRvIG51bWJlciBvZiBibG9j a3MKPiAgICAtIFcvQSB0byBpbmNyZWFzZSB0aGUgbmIgb2YgYmxvY2tzIGZvciBsZXZlbCAxLTcg YnkgMQo+ICAgIC0gTW92ZSBtYXggYmxvY2sgdGVzdCB0byA+PSBpbnN0ZWFkIG9mID4KPgo+IEFu eXdheSwgd2hpY2ggdGhlIGNvdXBsZSBvZiBjb21tZW50cyBiZWxvdyBhZGRyZXNzZCAob2Ygd2hp Y2ggb25seSB0aGUKPiAnPj0nIGlzIGEgcmVhbCBwcm9ibGVtKSwgdGhpcyBpczoKPgo+IFJldmll d2VkLWJ5OiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVuLmxlc3BpYXVAaW50ZWwuY29tPgoKV2lsbCBm aXggdXAgdGhlIGRldGFpbHMgYW5kIHRhZyBpdCB0aGVuLCB0aGFua3MhCgo+PiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCA1MiArKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAyMCBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+IGluZGV4IGY3Yzk5Mzgu LjYyNmMzYzIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiBAQCAtMjU5NSw3ICsy NTk1LDcgQEAgc3RhdGljIHVpbnQzMl90IHNrbF93bV9tZXRob2QxKHVpbnQzMl90IHBpeGVsX3Jh dGUsIHVpbnQ4X3QgYnl0ZXNfcGVyX3BpeGVsLAo+PiAgIAlpZiAobGF0ZW5jeSA9PSAwKQo+PiAg IAkJcmV0dXJuIFVJTlRfTUFYOwo+Pgo+PiAtCXdtX2ludGVybWVkaWF0ZV92YWwgPSBsYXRlbmN5 ICogcGl4ZWxfcmF0ZSAqIGJ5dGVzX3Blcl9waXhlbDsKPj4gKwl3bV9pbnRlcm1lZGlhdGVfdmFs ID0gbGF0ZW5jeSAqIHBpeGVsX3JhdGUgKiBieXRlc19wZXJfcGl4ZWwgLyA1MTI7Cj4+ICAgCXJl dCA9IERJVl9ST1VORF9VUCh3bV9pbnRlcm1lZGlhdGVfdmFsLCAxMDAwKTsKPj4KPj4gICAJcmV0 dXJuIHJldDsKPj4gQEAgLTI2MDUsMTUgKzI2MDUsMTggQEAgc3RhdGljIHVpbnQzMl90IHNrbF93 bV9tZXRob2QyKHVpbnQzMl90IHBpeGVsX3JhdGUsIHVpbnQzMl90IHBpcGVfaHRvdGFsLAo+PiAg IAkJCSAgICAgICB1aW50MzJfdCBob3Jpel9waXhlbHMsIHVpbnQ4X3QgYnl0ZXNfcGVyX3BpeGVs LAo+PiAgIAkJCSAgICAgICB1aW50MzJfdCBsYXRlbmN5KQo+PiAgIHsKPj4gLQl1aW50MzJfdCBy ZXQsIHBsYW5lX2J5dGVzX3Blcl9saW5lLCB3bV9pbnRlcm1lZGlhdGVfdmFsOwo+PiArCXVpbnQz Ml90IHJldDsKPj4gKwl1aW50MzJfdCBwbGFuZV9ieXRlc19wZXJfbGluZSwgcGxhbmVfYmxvY2tz X3Blcl9saW5lOwo+PiArCXVpbnQzMl90IHdtX2ludGVybWVkaWF0ZV92YWw7Cj4+Cj4+ICAgCWlm IChsYXRlbmN5ID09IDApCj4+ICAgCQlyZXR1cm4gVUlOVF9NQVg7Cj4+Cj4+ICAgCXBsYW5lX2J5 dGVzX3Blcl9saW5lID0gaG9yaXpfcGl4ZWxzICogYnl0ZXNfcGVyX3BpeGVsOwo+PiArCXBsYW5l X2Jsb2Nrc19wZXJfbGluZSA9IERJVl9ST1VORF9VUChwbGFuZV9ieXRlc19wZXJfbGluZSwgNTEy KTsKPj4gICAJd21faW50ZXJtZWRpYXRlX3ZhbCA9IGxhdGVuY3kgKiBwaXhlbF9yYXRlOwo+PiAg IAlyZXQgPSBESVZfUk9VTkRfVVAod21faW50ZXJtZWRpYXRlX3ZhbCwgcGlwZV9odG90YWwgKiAx MDAwKSAqCj4+IC0JCQkJcGxhbmVfYnl0ZXNfcGVyX2xpbmU7Cj4+ICsJCQkJcGxhbmVfYmxvY2tz X3Blcl9saW5lOwo+Pgo+PiAgIAlyZXR1cm4gcmV0Owo+PiAgIH0KPj4gQEAgLTI2OTMsMzkgKzI2 OTYsNDcgQEAgc3RhdGljIHZvaWQgc2tsX2NvbXB1dGVfd21fcGlwZV9wYXJhbWV0ZXJzKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPj4gICAJfQo+PiAgIH0KPj4KPj4gLXN0YXRpYyBib29sIHNrbF9j b21wdXRlX3BsYW5lX3dtKHN0cnVjdCBza2xfcGlwZV93bV9wYXJhbWV0ZXJzICpwLAo+PiArc3Rh dGljIGJvb2wgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+PiArCQkJCSBzdHJ1Y3Qgc2tsX3BpcGVfd21fcGFyYW1ldGVycyAqcCwK Pj4gICAJCQkJIHN0cnVjdCBpbnRlbF9wbGFuZV93bV9wYXJhbWV0ZXJzICpwX3BhcmFtcywKPj4g ICAJCQkJIHVpbnQxNl90IGRkYl9hbGxvY2F0aW9uLAo+PiAtCQkJCSB1aW50MzJfdCBtZW1fdmFs dWUsCj4+ICsJCQkJIGludCBsZXZlbCwKPj4gICAJCQkJIHVpbnQxNl90ICpvdXRfYmxvY2tzLCAv KiBvdXQgKi8KPj4gICAJCQkJIHVpbnQ4X3QgKm91dF9saW5lcyAvKiBvdXQgKi8pCj4+ICAgewo+ PiAtCXVpbnQzMl90IG1ldGhvZDEsIG1ldGhvZDIsIHBsYW5lX2J5dGVzX3Blcl9saW5lLCByZXNf YmxvY2tzLCByZXNfbGluZXM7Cj4+IC0JdWludDMyX3QgcmVzdWx0X2J5dGVzOwo+PiArCXVpbnQz Ml90IGxhdGVuY3kgPSBkZXZfcHJpdi0+d20uc2tsX2xhdGVuY3lbbGV2ZWxdOwo+PiArCXVpbnQz Ml90IG1ldGhvZDEsIG1ldGhvZDI7Cj4+ICsJdWludDMyX3QgcGxhbmVfYnl0ZXNfcGVyX2xpbmUs IHBsYW5lX2Jsb2Nrc19wZXJfbGluZTsKPj4gKwl1aW50MzJfdCByZXNfYmxvY2tzLCByZXNfbGlu ZXM7Cj4+ICsJdWludDMyX3QgcmVzdWx0X2Jsb2NrczsKPgo+IHdlIG5vdyBoYXZlIHJlc19ibG9j a3MgYW5kIHJlc3VsdF9ibG9ja3MsIGEgYml0IGNvbmZ1c2luZy4gTWF5YmUgcmVuYW1lCj4gcmVz dWx0X2Jsb2NrcyB0byBzZWxlY3RlZF9yZXN1bHQgKHdoaWNoIGhhcHBlbnMgdG8gYmUgaW4gYmxv Y2tzKQoKV2lsbCBjaGFuZ2UuCgo+Pgo+PiAtCWlmIChtZW1fdmFsdWUgPT0gMCB8fCAhcC0+YWN0 aXZlIHx8ICFwX3BhcmFtcy0+ZW5hYmxlZCkKPj4gKwlpZiAobGF0ZW5jeSA9PSAwIHx8ICFwLT5h Y3RpdmUgfHwgIXBfcGFyYW1zLT5lbmFibGVkKQo+PiAgIAkJcmV0dXJuIGZhbHNlOwo+Pgo+PiAg IAltZXRob2QxID0gc2tsX3dtX21ldGhvZDEocC0+cGl4ZWxfcmF0ZSwKPj4gICAJCQkJIHBfcGFy YW1zLT5ieXRlc19wZXJfcGl4ZWwsCj4+IC0JCQkJIG1lbV92YWx1ZSk7Cj4+ICsJCQkJIGxhdGVu Y3kpOwo+PiAgIAltZXRob2QyID0gc2tsX3dtX21ldGhvZDIocC0+cGl4ZWxfcmF0ZSwKPj4gICAJ CQkJIHAtPnBpcGVfaHRvdGFsLAo+PiAgIAkJCQkgcF9wYXJhbXMtPmhvcml6X3BpeGVscywKPj4g ICAJCQkJIHBfcGFyYW1zLT5ieXRlc19wZXJfcGl4ZWwsCj4+IC0JCQkJIG1lbV92YWx1ZSk7Cj4+ ICsJCQkJIGxhdGVuY3kpOwo+Pgo+PiAgIAlwbGFuZV9ieXRlc19wZXJfbGluZSA9IHBfcGFyYW1z LT5ob3Jpel9waXhlbHMgKgo+PiAgIAkJCQkJcF9wYXJhbXMtPmJ5dGVzX3Blcl9waXhlbDsKPj4g KwlwbGFuZV9ibG9ja3NfcGVyX2xpbmUgPSBESVZfUk9VTkRfVVAocGxhbmVfYnl0ZXNfcGVyX2xp bmUsIDUxMik7Cj4+Cj4+ICAgCS8qIEZvciBub3cgeHRpbGUgYW5kIGxpbmVhciAqLwo+PiAtCWlm ICgoKGRkYl9hbGxvY2F0aW9uICogNTEyKSAvIHBsYW5lX2J5dGVzX3Blcl9saW5lKSA+PSAxKQo+ PiAtCQlyZXN1bHRfYnl0ZXMgPSBtaW4obWV0aG9kMSwgbWV0aG9kMik7Cj4+ICsJaWYgKChkZGJf YWxsb2NhdGlvbiAvIHBsYW5lX2Jsb2Nrc19wZXJfbGluZSkgPj0gMSkKPj4gKwkJcmVzdWx0X2Js b2NrcyA9IG1pbihtZXRob2QxLCBtZXRob2QyKTsKPj4gICAJZWxzZQo+PiAtCQlyZXN1bHRfYnl0 ZXMgPSBtZXRob2QxOwo+PiArCQlyZXN1bHRfYmxvY2tzID0gbWV0aG9kMTsKPj4gKwo+PiArCXJl c19ibG9ja3MgPSByZXN1bHRfYmxvY2tzICsgMTsKPj4gKwlyZXNfbGluZXMgPSBESVZfUk9VTkRf VVAocmVzdWx0X2Jsb2NrcywgcGxhbmVfYmxvY2tzX3Blcl9saW5lKTsKPj4KPj4gLQlyZXNfYmxv Y2tzID0gRElWX1JPVU5EX1VQKHJlc3VsdF9ieXRlcywgNTEyKSArIDE7Cj4+IC0JcmVzX2xpbmVz ID0gRElWX1JPVU5EX1VQKHJlc3VsdF9ieXRlcywgcGxhbmVfYnl0ZXNfcGVyX2xpbmUpOwo+PiAr CWlmIChsZXZlbCA+PTEgJiYgbGV2ZWwgPD0gNykKPgo+IGEgc3BhY2UgaXMgbWlzc2luZyBiZWZv cmUgdGhlIDEgOikKCldlaXJkLCBvay4gOikKCj4+ICsJCXJlc19ibG9ja3MrKzsKPj4KPj4gICAJ aWYgKHJlc19ibG9ja3MgPiBkZGJfYWxsb2NhdGlvbiB8fCByZXNfbGluZXMgPiAzMSkKPgo+IHJl c19ibG9ja3MgPj0gZGRiX2FsbG9jYXRpb24KCldlbGwgc3BvdHRlZC4KClJlZ2FyZHMsCgpUdnJ0 a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK