Re: [PATCH 51/53] drm/i915: Remove the now obsolete intel_ring_get_request()

Tomas Elf
2015-03-09T23:35:33Z

On 19/02/2015 17:18, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Much of the driver has now been converted to passing requests around instead of
> rings/ringbufs/contexts. Thus the function for retreiving the request from a
> ring (i.e. the OLR) is no longer used and can be removed.
>
> For: VIZ-5115
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index e83fbbb..3b0261f 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -431,11 +431,4 @@ static inline u32 intel_ring_get_tail(struct intel_ringbuffer *ringbuf)
> return ringbuf->tail;
> }
>
> -static inline struct drm_i915_gem_request *
> -intel_ring_get_request(struct intel_engine_cs *ring)
> -{
> - BUG_ON(ring->outstanding_lazy_request == NULL);
> - return ring->outstanding_lazy_request;
> -}
> -
> #endif /* _INTEL_RINGBUFFER_H_ */
>

Reviewed-by: Tomas Elf <tomas.elf@intel.com>

Thanks,
Tomas