Re: [PATCH 47/51] drm/i915: Update ironlake_enable_rc6() to do explicit request management

John Harrison
2015-02-13T16:58:27Z

On 13/02/2015 12:19, Chris Wilson wrote:
> On Fri, Feb 13, 2015 at 11:48:56AM +0000, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> Updated ironlake_enable_rc6() to do explicit request creation and submission.
> If you merged the context here with the common context switching code,
> we don't even need to touch the ring here.
> -Chris
>
It would certainly be preferable to not have any ring commands written
from deep within the power management code. However, I didn't want to
change anything I didn't really need to, especially in code that I'm not
at all sure about. Plus I don't have an ironlake to test any significant
change on.