Re: [PATCH 02/12] drm/i915: Kill DRAIN_LATENCY_PRECISION_* defines

Ville Syrjälä
2015-02-27T18:06:19Z

On Fri, Feb 27, 2015 at 09:38:10AM -0800, Jesse Barnes wrote:
> On 02/10/2015 05:28 AM, ville.syrjala@linux.intel.com wrote:
> > @@ -957,8 +954,7 @@ static void valleyview_update_sprite_wm(struct
> drm_plane *plane,
> > int plane_prec;
> > int sprite_dl;
> > int prec_mult;
> > - const int high_precision = IS_CHERRYVIEW(dev) ?
> > - DRAIN_LATENCY_PRECISION_32 : DRAIN_LATENCY_PRECISION_64;
> > + const int high_precision = IS_CHERRYVIEW(dev) ? 16 : 64;
> >
> > sprite_dl = I915_READ(VLV_DDL(pipe)) & ~(DDL_SPRITE_PRECISION_HIGH(sprite) |
> > (DRAIN_LATENCY_MASK << DDL_SPRITE_SHIFT(sprite)));
> >
>
> This hunk changes things; did it belong in the earlier patch?

Yeah that should have been part of patch 1 already. I'll respin.

>
> With that explained:
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

--
Ville Syrjälä
Intel OTC