From: Michel Thierry <michel.thierry@intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/gen8: The WA BB framework is enabled.
Date: Fri, 27 Feb 2015 18:04:37 +0000 [thread overview]
Message-ID: <54F0B1B5.3040400@intel.com> (raw)
In-Reply-To: <54F0AA46.8000805@intel.com>
On 27/02/15 17:32, Michel Thierry wrote:
>
>
> On 25/02/15 17:54, Arun Siluvery wrote:
>> From: Namrta <namrta.salonie@intel.com>
>>
>> This can be used to enable WA BB infrastructure for features like
>> RC6, SSEU and in between context save/restore etc.
>> The patch which would need WA BB will have to declare the wa_bb obj
>> utilizing the function here. Update the WA BB with required commands
>> and update the address of the WA BB at appropriate place.
>>
>> Change-Id: I9cc49ae7426560215e7b6a6d10ba411caeb9321b
>> Signed-off-by: Namrta <namrta.salonie@intel.com>
>> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_lrc.c | 32 ++++++++++++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_lrc.c
>> b/drivers/gpu/drm/i915/intel_lrc.c
>> index 9c851d8..47473e5 100644
>>
> Maybe add an extra line between the 2 paragraphs in the commit message.
>
> Reviewed-by: Michel Thierry <michel.thierry@intel.com>
Also, your next patch moves the function around, it'd be nice to add it
in the right place since here, so the diffs are clearer.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-27 18:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 17:54 [PATCH 0/2] Gen8: Per-context workarounds using W/A batch buffers Arun Siluvery
2015-02-25 17:54 ` [PATCH 1/2] drm/i915/gen8: The WA BB framework is enabled Arun Siluvery
2015-02-27 17:32 ` Michel Thierry
2015-02-27 18:04 ` Michel Thierry [this message]
2015-03-02 11:06 ` [PATCH v2 " Arun Siluvery
2015-02-25 17:54 ` [PATCH 2/2] drm/i915/gen8: Apply Per-context workarounds using W/A batch buffers Arun Siluvery
2015-02-26 20:24 ` shuang.he
2015-03-02 10:10 ` Michel Thierry
2015-03-02 10:23 ` Siluvery, Arun
2015-03-02 11:07 ` [PATCH v2 " Arun Siluvery
2015-03-02 17:43 ` Daniel Vetter
2015-03-02 18:08 ` Siluvery, Arun
2015-03-02 11:02 ` [PATCH v2 1/2] drm/i915/gen8: The WA BB framework is enabled Arun Siluvery
2015-03-02 11:10 ` Siluvery, Arun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F0B1B5.3040400@intel.com \
--to=michel.thierry@intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox