From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH 05/51] drm/i915: Add return code check to i915_gem_execbuffer_retire_commands() Date: Thu, 05 Mar 2015 13:06:10 +0000 Message-ID: <54F854C2.7010208@Intel.com> References: <1423828140-10653-1-git-send-email-John.C.Harrison@Intel.com> <1423828140-10653-6-git-send-email-John.C.Harrison@Intel.com> <20150225221700.GE24485@phenom.ffwll.local> <20150226022651.GJ24485@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id F0F206E7AF for ; Thu, 5 Mar 2015 05:06:12 -0800 (PST) In-Reply-To: <20150226022651.GJ24485@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gMjYvMDIvMjAxNSAwMjoyNiwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBXZWQsIEZlYiAy NSwgMjAxNSBhdCAxMToxNzowMFBNICswMTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+PiBPbiBG cmksIEZlYiAxMywgMjAxNSBhdCAxMTo0ODoxNEFNICswMDAwLCBKb2huLkMuSGFycmlzb25ASW50 ZWwuY29tIHdyb3RlOgo+Pj4gRnJvbTogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQElu dGVsLmNvbT4KPj4+Cj4+PiBGb3Igc29tZSByZWFzb24sIHRoZSBpOTE1X2FkZF9yZXF1ZXN0KCkg Y2FsbCBpbgo+Pj4gaTkxNV9nZW1fZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFuZHMoKSB3YXMgZXhw bGljaXRseSBoYXZpbmcgaXRzIHJldHVybiBjb2RlCj4+PiBpZ25vcmVkLiBUaGUgX3JldGlyZV9j b21tYW5kcygpIGZ1bmN0aW9uIGl0c2VsZiB3YXMgJ3ZvaWQnLiBHaXZlbiB0aGF0Cj4+PiBfYWRk X3JlcXVlc3QoKSBjYW4gZmFpbCB3aXRob3V0IGRpc3BhdGNoaW5nIHRoZSBiYXRjaCBidWZmZXIs IHRoaXMgc2VlbXMgb2RkLgo+PiBJIHdhcyBzbyBjb252aW5jZWQgd2UndmUgaGFkIGEgY29tbWl0 IHNvbWV3aGVyZSBleHBsYWluaW5nIHRoaXMsIGJ1dAo+PiBhcHBhcmVudGx5IG5vdC4KPj4KPj4g VGhlIGRlYWwgaXMgdGhhdCBhZnRlciB0aGUgZGlzcGF0Y2ggY2FsbCB3ZSBoYXZlIHRoZSBiYXRj aCBjb21taXQgYW5kCj4+IHRoZXJlJ3Mgbm8gZ29pbmcgYmFjayBhbnkgbW9yZSwgd2hpY2ggYWxz byBtZWFucyB3ZSBjYW4ndCByZXR1cm4gYW4gZXJyb3IKPj4gY29kZSBmcm9tIHRoZSBpb2N0bC4g U28gaWYgeW91IHJldHVybiAtRUlPIG9yIC1FTk9NRU0gdGhhdCdzIGEgcHJldHR5IGJhZAo+PiBs aWUgYW5kIHlvdSByZWFsbHkgaGF2ZSB0byBpZ25vcmUgdGhhdCBlcnJvciBjb2RlLgo+Pgo+PiBB Z2FpbiBJJ3ZlIHRyaWVkIHRvIGRpZyB1cCB0aGUgY29tbWl0IGZvciB0aGF0IGJ1dCB0aGF0IHdh cyBsb3N0IGluIHRoZQo+PiBtYXplIG9mIHRoZSBwYXN0IDUgeWVhcnMgb2YgY2hhbmdlcy4gV2Un dmUgaGFkIHBpbGVzIG9mIG9sZGVyIGFwcHJvYWNoZXMKPj4gdG8gZGVhbCB3aXRoIHRoaXMgaXNz dWU6Cj4+IC0gRG9uJ3QgZXZlbiBlbWl0IGEgcmVxdWVzdCwganVzdCBtYXJrIG9iamVjdHMgYXMg Z3B1IGRpcnR5LiBPbmx5IHdoZW4KPj4gICAgd2FpdGluZyBkaWQgd2UgZW1pdCBmbHVzaGVzIGFu ZCByZXF1ZXN0cywgd2hpY2ggYWdhaW4gYWdhaW4gZ2F2ZSB1cyBhCj4+ICAgIGNvbnRleHQgdG8g cmV0dXJuIHRoZSBlcnJvci4gVGhpcyByZXN1bHRlZCBpbiBob3JyaWJsZSBsYXRlbmN5IHNpbmNl Cj4+ICAgIGZsdXNoZXMgd2hlcmUgd2FpdCB0b28gbGF0ZSBhbmQgYWxzbyBhbGwgdGhhdCBib29r LWtlZXBpbmcgd2FzIG5vdCB3b3J0aAo+PiAgICBpdCBhdCBhbGwuIERvbid0IGFzayA7LSkKPj4g LSBFbWl0IGZsdXNoZXMgcmlnaHQgYXdheSwgYnV0IGlmIHdlIGZhaWwgdG8gYWxsb2MgdGhlIHJl cXVlc3Qgc2V0IHRoZQo+PiAgICBvdXRzdGFuZGluZyBsYXp5IHJlcXVlc3QgYml0LiBUaGUgam9i IG9mIHRoZSBjaGVja19vbHIgZnVuY3Rpb24gdXNlZCBpbgo+PiAgICB3YWl0cyB3YXMgdG8gbm90 aWNlIHRoYXQgYW5kIHJldHJ5IHRoZSBhbGxvY2F0aW9uLgo+PiAtIFByZWFsbG9jYXRlIHRoZSBy ZXF1ZXN0LCBidXQgdGhhdCBzdGlsbCBsZWF2ZXMgdGhlIHBvc3NpYmlsaXR5IHRoYXQgdGhlCj4+ ICAgIGdwdSBkaWVzLiBCdXQgc2luY2Ugd2UndmUgY29tbWl0dGVkIGhhbmdjaGVjayB3aWxsIGNs ZWFuIHRoaXMgdXAgYW5kIHdlCj4+ICAgIGNhbiBqdXN0IGlnbm9yZSB0aGUgLUVJTy4KPj4KPj4g R2l2ZW4gYWxsIHRoYXQgYmFja3N0b3J5OiBXaHkgZG9lcyBhZGRfcmVxdWVzdC9yZXRpcmVfY29t bWFuZHMgc3VkZGVubHkKPj4gbmVlZCB0byBmYWlsPwpUaGUgcHJvYmxlbSBpcyB0aGF0IGlmIGFk ZF9yZXF1ZXN0KCkgZmFpbHMgYW5kIHRoZSByZXF1ZXN0IGlzIG5vdCBhZGRlZCAKdG8gcmluZy0+ cmVxdWVzdF9saXN0IHRoZW4gaXQgd2lsbCBiZSBsb3N0LiBBcyBzb29uIGFzIHRoZSBleGVjYnVm ZiBjb2RlIApyZXR1cm5zLCB0aGVyZSBpcyBubyBsb25nZXIgYSByZXF1ZXN0IHBvaW50ZXIgZmxv YXRpbmcgYXJvdW5kIHNvIGl0IGNhbiAKY2FuJ3QgaGF2ZSBhZGRfcmVxdWVzdCgpIGNhbGxlZCBv biBpdCBsYXRlci4gVGh1cyB0aGUgcmVxdWVzdCB3aWxsIG5ldmVyIApiZSByZXRpcmVkLCB0aGUg b2JqZWN0cywgY29udGV4dCwgZXRjIG5ldmVyIGRlcmVmZXJlbmNlZCwgYW5kIGJhc2ljYWxseSAK bG90cyBvZiBzdHVmZiB3aWxsIGJlIGxlYWtlZC4gV2l0aG91dCB0aGUgT0xSIHRvIGhvb3ZlciB1 cCB0aGUgZmFpbHVyZXMsIAp0aGUgYWRkX3JlcXVlc3QoKSBjYWxsIHJlYWxseSBtdXN0IG5vdCBi ZSBhbGxvd2VkIHRvIGdpdmUgdXAuCgo+IEl0J3MgYWN0dWFsbHkgd29yc2Ugc2luY2UgaXQncyBu b3QganVzdCAtRUlPIGJ1dCBhbHNvIC1FSU5UUiwgcmV0dXJuZWQgYnkKPiBpbnRlbF9yaW5nX2Jl Z2luIHdoZW4gd2UncmUgdGhyYXNoaW5nIHRoZSBncHUgYSBiaXQgdG9vIGJhZGx5IHdpdGgKPiBy ZXF1ZXN0cy4gV2hpY2ggbWVhbnMgd2UgcmVhbGx5IG5lZWQgdG8gZ3VhcmFudGVlIHRoYXQgdGhl IHJlcXVlc3QgaXMKPiBjb21wbGV0ZWQgcHJvcGVybHksIGV2ZW50dWFsbHkgc2luY2UgaXQncyBu b3QganVzdCBmb3IgZmF0YWwgZ3B1IGhhbmdzLgo+Cj4gQXRtIHRoYXQncyBkb25lIGJ5IG9ubHkg Y2xlYXJpbmcgb3V0c3RhbmRpbmdfbGF6eV9yZXF1ZXN0IGFmdGVyIHdlJ3ZlCj4gcmVhbGx5IGVt aXR0ZWQgdGhlIHJlcXVlc3QgZnVsbHkuIFRoYXQgZ3VhcmFudGVlcyB0aGF0IGV2ZW4gd2hlbiBw YXJ0cyBvZgo+IHRoZSByZXF1ZXN0IGVtaXNzaW9uIHRvIHRoZSByaW5nYnVmIGZhaWxzIHdlJ2xs IHJldHJ5IG9uIHRoZSBuZXh0IHdhaXQgaWYKPiBuZWVkZWQuCj4KPiBBIHBvc3NpYmxlIGZpeCB0 byBtYWtlIHRoaXMgaW5mYWxsaWJsZSB3b3VsZCBiZSB0byByZXNlcnZlIHNvbWUgZml4ZWQKPiBh bW91bnQgb2YgcmluZ2J1ZiBjcmVkaXQgYXQgcmVxdWVzdCBjcmVhdGlvbiB0aW1lIGFuZCB0aGVu IGNvbnN1bWUgaXQKPiBoZXJlLiBPZiBjb3Vyc2Ugd2UnZCBuZWVkIGNoZWNrcyB0byBtYWtlIHN1 cmUgd2UgbmV2ZXIgdXNlIG1vcmUgcmluZ3NwYWNlCj4gdGhhbiB3aGF0IHdlIHJlc2VydmUuIFRv IGF2b2lkIG1hc3NpdmUgY2h1cm4gd2UgY291bGQgY29udmVydAo+IEk5MTVfUklOR19GUkVFX1NQ QUNFIGludG8gYSB2YXJpYWJsZSBhbmQgaW5jcmVhc2UgaXQgZW5vdWdoIHdoZW4KPiBhbGxvY2F0 aW5nIHRoZSByZXF1ZXN0LiBBbmQgdGhlbiByZWR1Y2UgaXQgYWdhaW4gYXQgdGhlIHN0YXJ0IG9m Cj4gYWRkX3JlcXVlc3QuCj4gLURhbmllbAoKSSBkb24ndCB0aGluayB5b3UgY2FuIGd1YXJhbnRl ZSB0byByZXNlcnZlIGVub3VnaCBzcGFjZSBhdCByZXF1ZXN0IApjcmVhdGlvbiB0aW1lLiBZb3Ug aGF2ZSBubyBpZGVhIGhvdyBtdWNoIHNwYWNlIHdpbGwgYmUgcmVxdWlyZWQgYnkgd2hhdCAKZXZl ciBwaWVjZSBvZiBjb2RlIGlzIHdhbnRpbmcgdGhlIHJlcXVlc3QuIEl0IGNvdWxkIGJlIGEgZmV3 IHdvcmRzIG9yIGl0IAptaWdodCBiZSByZWFtcyBhbmQgcmVhbXMgb2Ygd29ya2Fyb3VuZCBnb28u IE9uZSBvZiB0aGUgc2NoZWR1bGVyIHBhdGNoZXMgCmRvZXMgaW1wcm92ZSB0aGlzIGFuZCBkbyBh ICdsYXJnZSBlbm91Z2gnIHJpbmdfYmVnaW4oKSBhdCB0aGUgc3RhcnQgb2YgCnRoZSBleGVjYnVm ZmVyIHN1Ym1pc3Npb24gcGF0aCBpbiBvcmRlciB0byBwcmV2ZW50IG91dCBvZiBzcGFjZSBpc3N1 ZXMgCmFuZCBvdGhlciBzdWNoIHByb2JsZW1zIGhhbGYgd2F5IHRocm91Z2ggdGhhdCBjb3VsZCBs ZWFkIHRvIGEgcGFydGlhbCAKc3VibWlzc2lvbi4gSG93ZXZlciwgZXZlbiB0aGF0IGlzIG5vdCBh YnNvbHVldGVseSBndWFyYW50ZWVkIDEwMCUgCmZhaWx1cmUgcHJvb2YuCgpIb3cgYWJvdXQgY2hh bmdpbmcgYWRkX3JlcXVlc3QoKSBzbyB0aGF0IGl0IGNhbid0IGZhaWwuIEFzIGluLCB0aGUgY2Fj aGUgCmZsdXNoIGNhbGwgYW5kIHRoZSBlbWl0IHJlcXVlc3QgY2FsbCBjYW4gc3RpbGwgZmFpbHVy ZSBkdWUgdG8gcnVubmluZyAKb3V0IG9mIHJpbmcgc3BhY2UsIGJ1dCBhZGRfcmVxdWVzdCgpIGp1 c3QgaWdub3JlcyB0aGF0IGFuZCBrZWVwcyBnb2luZyAKYW55d2F5LiBUaGF0IHdheSB0aGUgcmVx dWVzdCBpcyBzdGlsbCBjb3JyZWN0bHkgdHJhY2tlZCBhbmQgd2lsbCBiZSAKcmV0aXJlZCBldmVu dHVhbGx5LiBUaGUgb25seSBpc3N1ZXMgYXJlIHVuZmx1c2hlZCBjYWNoZXMgYW5kIG5vIHNlcW5v IAppbnRlcnJ1cHQgYmVpbmcgZ2VuZXJhdGVkLiBIb3dldmVyLCBpZiB0aGUgYXNzdW1wdGlvbiBp cyB0aGF0IGFub3RoZXIgCnJlcXVlc3Qgd2lsbCBiZSBzdWJtaXR0ZWQgc2hvcnRseSAod2hpY2gg aXMgZXh0cmVtZWx5IGxpa2VseSBpZiB0aGUgCnN5c3RlbSBpcyBidXN5IGVub3VnaCB0byBjYXVz ZSBhIGZhaWx1cmUgZHVyaW5nIGFkZF9yZXF1ZXN0ISkgdGhlbiB0aGlzIAp3aWxsIGJlIGZpbmUu IFRoZSBmb2xsb3dpbmcgcmVxdWVzdCB3aWxsIGZsdXNoIHRoZSBjYWNoZXMgYW5kIHdyaXRlIHRo ZSAKbmV4dCBzZXFubyBhbG9uZyB0byB0aGUgcmluZ2J1ZmZlci4gV2hlbiB0aGF0IHBvcHMgb3V0 LCBib3RoIHRoZSBicm9rZW4gCnJlcXVlc3QgYW5kIHRoZSBuZXcgb25lIHdpbGwgYmUgY29uc2lk ZXJlZCBjb21wbGV0ZSBhbmQgY2FuIGJlIHJldGlyZWQuIApUaGUgb25seSBpc3N1ZSBpcyBpZiB0 aGUgYnJva2VuIHJlcXVlc3QgaXMgdGhhdCBsYXN0IG9uZSB0byBiZSBzdWJtaXR0ZWQgCmFuZCBp cyB0aGVuIHdhaXRlZCBvbi4gSW4gdGhhdCBjYXNlLCB5b3Ugd2lsbCBnZXQgYSB0aW1lb3V0L2hh bmcgYXMgdGhlIApyZXF1ZXN0IHdpbGwgbmV2ZXIgY29tcGxldGUuIEFsdGhvdWdoIHRoYXQgY291 bGQgYmUgd29ya2VkIGFyb3VuZCBieSAKc2V0dGluZyBhICdmYWlsZWQgcmVxdWVzdCcgZmxhZyBp biB0aGUgcmluZyBhbmQgaGF2aW5nIHRoZSB3YWl0IGNvZGUgKG9yIApldmVuIHRoZSBjdXJyZW50 bHkgcmVkdW5kYW50IGNoZWNrX29sciBmdW5jdGlvbikgbG9vayBhdCB0aGF0IGFuZCAKYXR0ZW1w dCBhIGJyYW5kIG5ldyAoYnV0IGVtcHR5KSByZXF1ZXN0IHN1Ym1pc3Npb24uCgpPciBtYXliZSBh IHNpbXBsZXIgc29sdXRpb24gaXMgdG8ganVzdCBrZWVwIGEgJ2xhc3QgZmFpbGVkIHJlcXVlc3Qn IApwb2ludGVyIGluIHRoZSByaW5nLiBTb3J0IG9mIGEgbm90LXF1aXRlLU9MUi4gSWYgYWRkX3Jl cXVlc3QoKSBmYWlscywgaXQgCnNhdmVzIHRoZSByZXF1ZXN0IHBvaW50ZXIgaGVyZSBpbnN0ZWFk IG9mIGFkZGluZyBpdCB0byB0aGUgcmVxdWVzdCBsaXN0LiAKQSBzdWJzZXF1ZW50IHJlcXVlc3Qg YWxsb2NhdGlvbiBjYWxsIHN0YXJ0cyBieSBjaGVja2luZyB0aGUgJ2xhc3QgCmZhaWxlZCcgdmFs dWUgYW5kIHJldHJpZXMgdGhlIGFkZF9yZXF1ZXN0KCkgY2FsbCBpZiBwcmVzZW50LiBBdCB0aGF0 IApwb2ludCBpdCBpcyBhbGxvd2VkIHRvIGZhaWwuIEkgZ3Vlc3MgaXQgc3RpbGwgbmVlZHMgdG8g YmUgZG9uZSBieSAKY2hlY2tfb2xyIGFzIHdlbGwgdG8gcHJldmVudCBhIHdhaXQgZnJvbSBzdGFs bGluZyBpZiBubyBvdGhlciByZXF1ZXN0cyAKYXJlIHN1Ym1pdHRlZC4KCkpvaG4uCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=