From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active() Date: Thu, 05 Mar 2015 15:07:52 +0000 Message-ID: <54F87148.2010104@linux.intel.com> References: <1425435313-31711-1-git-send-email-matthew.d.roper@intel.com> <54F7404C.8030201@linux.intel.com> <20150304174213.GB23780@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C1C3B6E7D6 for ; Thu, 5 Mar 2015 07:07:54 -0800 (PST) In-Reply-To: <20150304174213.GB23780@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzA0LzIwMTUgMDU6NDIgUE0sIE1hdHQgUm9wZXIgd3JvdGU6Cj4gT24gV2VkLCBNYXIg MDQsIDIwMTUgYXQgMDU6MjY6MzZQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+ IE9uIDAzLzA0LzIwMTUgMDI6MTUgQU0sIE1hdHQgUm9wZXIgd3JvdGU6Cj4+PiBVbml2ZXJzYWwg cGxhbmVzIGFsbG93IHVzIHRvIGhhdmUgYW4gYWN0aXZlIENSVEMgd2l0aG91dCBhIHByaW1hcnkg cGxhbmUKPj4+IGZyYW1lYnVmZmVyIGJvdW5kLiAgRHJvcCB0aGUgdGVzdCBmb3IgcHJpbWFyeS0+ ZmIgZnJvbQo+Pj4gaW50ZWxfY3J0Y19hY3RpdmUoKSBzaW5jZSB3ZSBjYW4gY2xlYXJseSBoYXZl IGFjdGl2ZSBDUlRDJ3Mgd2l0aG91dCBhCj4+PiBmcmFtZWJ1ZmZlciwgYW5kIHRoaXMgY2hlY2sg aXMgbm93IGludGVyZmVyaW5nIHdpdGggd2F0ZXJtYXJrCj4+PiBjYWxjdWxhdGlvbnMgd2hlbiB3 ZSB0cnkgdG8gcmUtZW5hYmxlIHRoZSBwcmltYXJ5IHBsYW5lLgo+Pj4KPj4+IE5vdGUgdGhhdCBj b21taXQKPj4+Cj4+PiAgICAgICAgICBjb21taXQgMGZkYTY1NjgwZTkyNTQ1Y2FlYTViZTc4MDVh N2YwYTYxN2ZiNmMyMAo+Pj4gICAgICAgICAgQXV0aG9yOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4gICAgICAgICAgRGF0ZTogICBGcmkgRmViIDI3IDE1OjEy OjM1IDIwMTUgKzAwMDAKPj4+Cj4+PiAgICAgICAgICAgICAgZHJtL2k5MTUvc2tsOiBVcGRhdGUg d2F0ZXJtYXJrcyBmb3IgWSB0aWxpbmcKPj4+Cj4+PiBhZGRzIGEgdGVzdCBmb3IgcHJpbWFyeSBw bGFuZSBlbmFibGUvZGlzYWJsZSB0byB0cmlnZ2VyIGEgd2F0ZXJtYXJrCj4+PiB1cGRhdGUgKHBy ZXZpb3VzbHkgd2UgaWdub3JlZCB1cGRhdGVzIHRvIHByaW1hcnkgcGxhbmVzLCB3aGljaCB3YXNu J3QKPj4+IHJlYWxseSBjb3JyZWN0LCBidXQgd2UgZ290IGx1Y2t5IHNpbmNlIHdlIGFsd2F5cyBw cmV0ZW5kZWQgdGhlIHByaW1hcnkKPj4+IHBsYW5lIHdhcyBvbikuICBUdnJ0a28ncyBwYXRjaCB0 cmllcyB0byB1cGRhdGUgd2F0ZXJtYXJrcyB3aGVuIHdlCj4+PiByZS1lbmFibGUgdGhlIHByaW1h cnkgcGxhbmUsIGJ1dCB0aGF0IHdhdGVybWFyayBjb21wdXRhdGlvbiBnZXRzIGFib3J0ZWQKPj4+ IGVhcmx5IGJlY2F1c2UgaW50ZWxfY3J0Y19hY3RpdmUoKSBhbHdheXMgcmV0dXJucyBmYWxzZSB3 aGVuIHRoZSBwcmltYXJ5Cj4+PiBwbGFuZSBpcyBkaXNhYmxlZDsgdGhpcyBsZWFkcyB0byB3YXRl cm1hcmsgdW5kZXJydW5zIChhdCBsZWFzdCBvbgo+Pj4gcGxhdGZvcm1zIHdpdGggSUxLLXN0eWxl IHdhdGVybWFyayBjb2RlKS4KPj4+Cj4+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1 bGluQGludGVsLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5y b3BlckBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIHwgNSArLS0tLQo+Pj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDQgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ Pj4gaW5kZXggNTg5YWRkZi4uOTJjYjJmZiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4+PiBAQCAtODkzLDExICs4OTMsOCBAQCBib29sIGludGVsX2NydGNfYWN0 aXZlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4+ICAgCSAqCj4+PiAgIAkgKiBXZSBjYW4gZGl0 Y2ggdGhlIGFkanVzdGVkX21vZGUuY3J0Y19jbG9jayBjaGVjayBhcyBzb29uCj4+PiAgIAkgKiBh cyBIYXN3ZWxsIGhhcyBnYWluZWQgY2xvY2sgcmVhZG91dC9mYXN0Ym9vdCBzdXBwb3J0Lgo+Pj4g LQkgKgo+Pj4gLQkgKiBXZSBjYW4gZGl0Y2ggdGhlIGNydGMtPnByaW1hcnktPmZiIGNoZWNrIGFz IHNvb24gYXMgd2UgY2FuCj4+PiAtCSAqIHByb3Blcmx5IHJlY29uc3RydWN0IGZyYW1lYnVmZmVy cy4KPj4+ICAgCSAqLwo+Pj4gLQlyZXR1cm4gaW50ZWxfY3J0Yy0+YWN0aXZlICYmIGNydGMtPnBy aW1hcnktPmZiICYmCj4+PiArCXJldHVybiBpbnRlbF9jcnRjLT5hY3RpdmUgJiYKPj4+ICAgCQlp bnRlbF9jcnRjLT5jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrOwo+Pgo+PiBT dHJ1Z2dsaW5nIHRvIHBhaW50IHRoZSB3aG9sZSBwaWN0dXJlIGhlcmUuLgo+Pgo+PiBXaHkgaXQg d2FzIGNvcnJlY3QgdG8gcmVwbGFjZSBwcmltYXJ5LT5mYiB3aXRoIHByaW1hcnktPnN0YXRlLT5m Ygo+PiBlbHNld2hlcmUsIGJ1dCBub3QgaGVyZT8KPj4KPj4gRG9lcyB0aGUgY29tbWl0IG1lc3Nh Z2UgbWVhbiB0aGVyZSBjYW4gYmUgYW4gYWN0aXZlIGNydGMgd2l0aCBhbgo+PiBhY3RpdmUgcGxh bmUsIGJ1dCBjcnRjLT5wcmltYXJ5LT5mYiA9PSBOVUxMIHNvIHRoZSB3bSByZWNvbXB1dGUKPj4g aW5jb3JyZWN0bHkgY29uZmlndXJlcyBmb3IgZGlzYWJsZWQgcGxhbmU/Cj4KPiBCYWNrIHdoZW4g dGhpcyBjb2RlIHdhcyBmaXJzdCB3cml0dGVuLCB3ZSBkaWRuJ3QgaGF2ZSB1bml2ZXJzYWwgcGxh bmVzCj4geWV0IGFuZCB0aGUgZmIgcG9pbnRlciB3YXMgZGlyZWN0bHkgaW4gdGhlIENSVEMuICAg U28gYXQgdGhhdCB0aW1lLAo+IChjcnRjLT5mYiA9PSBOVUxMKSBtZWFudCB0aGF0IHRoZSBlbnRp cmUgQ1JUQyB3YXMgb2ZmLgo+Cj4gV2hlbiBJIGFkZGVkIHVuaXZlcnNhbCBwbGFuZSBzdXBwb3J0 LCBJIHVzZWQgQ29jY2luZWxsZSB0byBnbG9iYWxseSBkbyBhCj4gcy9jcnRjLT5mYi9jcnRjLT5w cmltYXJ5LT5mYi8sIHNvIHRoYXQgY2hhbmdlIGRpZG4ndCByZWFsbHkgaGF2ZSBhbnkKPiBzcGVj aWFsIHRob3VnaHQgZ29pbmcgaW50byBpdC4gIEhvd2V2ZXIgYXQgdGhhdCBwb2ludCB3ZSBzdGFy dGVkCj4gYWxsb3dpbmcgeW91IHRvIGhhdmUgYW4gZXhwbGljaXRseSBkaXNhYmxlZCBwcmltYXJ5 IHBsYW5lIHdpdGggYW4gYWN0aXZlCj4gQ1JUQyAoc29tZXRoaW5nIHRoYXQgaGFkIG5ldmVyIGJl ZW4gcG9zc2libGUgYmVmb3JlIHdpdGggdGhlIGxlZ2FjeQo+IEFQSSdzKS4gIEluIHRoaXMgY2Fz ZSwgY3J0Yy0+cHJpbWFyeS0+ZmIgPSBOVUxMLCBidXQgdGhlIENSVEMgaXMgc3RpbGwKPiBydW5u aW5nLgo+Cj4gU28gb25seSBjb25zaWRlcmluZyBhIENSVEMgdG8gYmUgYWN0aXZlIGlmIGl0cyBw cmltYXJ5IHBsYW5lIGhhcyBhCj4gZnJhbWVidWZmZXIgaXNuJ3QgcmVhbGx5IGNvcnJlY3QgaW4g dGhlIHVuaXZlcnNhbCBwbGFuZSBhbmQgYXRvbWljCj4gd29ybGQuICBXaGV0aGVyIHdlIHVzZSBw cmltYXJ5LT5mYiBvciBwcmltYXJ5LT5zdGF0ZS0+ZmIgZG9lc24ndCByZWFsbHkKPiBtYXR0ZXIg aW4gdGhpcyBjYXNlLgo+Cj4gTXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0IHRoZSByZWFzb24gd2Ug YWxzbyBjaGVja2VkIGZiIGFuZCBtb2RlIGluCj4gYWRkaXRpb24gdG8gaW50ZWxfY3J0Yy0+YWN0 aXZlIGhhZCB0byBkbyB3aXRoIHF1aWNrYm9vdCBsb2dpYyBhbmQgdGhlCj4gZHJpdmVyJ3MgYWJp bGl0eSB0byBpbmhlcml0IHN0YXRlIHNldHVwIGJ5IHRoZSBib290IGZpcm13YXJlLiAgSSB0aGlu awo+IEplc3NlIG9yIFZpbGxlIG1pZ2h0IGJlIGFibGUgdG8gZXhwbGFpbiB0aGF0IHBhcnQgYmV0 dGVyIGFuZCBkZXNjcmliZQo+IGFueSBxdWlja2Jvb3QgcHJvYmxlbXMgdGhhdCB0aGlzIGNoYW5n ZSBtaWdodCBjYXVzZS4KPgo+IFRoaXMgcGF0Y2ggaXMgc3RpbGwgc29ydCBvZiBhIGJhbmRhaWQ7 IHVsdGltYXRlbHkgb3VyIHdhdGVybWFyayBjb2RlCj4gc2hvdWxkIGFsbCBiZSBzdGF0ZS1iYXNl ZCBhbmQgd2UnbGwgYmUgbG9va2luZyBhdCBjcnRjLT5zdGF0ZS0+YWN0aXZlCj4gYW5kIHBsYW5l LT5zdGF0ZS0+Rk9PIGFuZCBzdWNoIHRvIGZpZ3VyZSBvdXQgaG93L3doZW4gdG8gdXBkYXRlIG91 cgo+IHdhdGVybWFya3MuICBCdXQgdGhlIHdhdGVybWFyayByZXdvcmsgaXNuJ3QgZG9uZSB5ZXQg YW5kIHdlJ3JlIGFsc28gc29ydAo+IG9mIGluIGEgd2VpcmQgbGltYm8gc3RhZ2Ugd2hlcmUgcGxh bmVzIGFyZSBwcmV0dHkgbXVjaCBjb252ZXJ0ZWQgdG8KPiBhdG9taWMsIGJ1dCBDUlRDJ3MgYXJl IHN0aWxsIGJlaW5nIHdvcmtlZCBvbi4KClllYWguLiB3ZWxsLCBJIGRvbid0IHNlZSB0aGF0IGFu eXRoaW5nIHdpbGwgZ28gYmFkIHdpdGggdGhpcywgYnV0IHRoaXMgCmlzIHdpdGggbGlrZSA1MCUg Y29uZmlkZW5jZS4KCkFuZCB0aGUgY29tbWVudCBzYWlkIGNoZWNrIGNhbiBiZSByZW1vdmVkIHdo ZW4gd2UgY2FuICJwcm9wZXJseSAKcmVjb25zdHJ1Y3QgdGhlIGZyYW1lYnVmZmVyIiBhbnl3YXku CgpCdXQgd2hhdCBkb2VzICJwcm9wZXJseSIgbWVhbiB0aGVyZT8gRmlybXdhcmUgdGFrZSBvdmVy IGxvb2tzIHRoZXJlIHRvIAptZS4gU28gbWF5YmUgaXQgY291bGQgcmVhbGx5IGhhZCBiZWVuIHJl bW92ZWQgZXZlbiByZWdhcmRsZXNzIG9mIHRoaXMgCmZhbGxvdXQ/CgpSZWdhcmRzLAoKVHZydGtv Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==