From: Ian Romanick <idr@freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 00/12] Introduce drm_intel_device and use i915_pciid.h
Date: Thu, 05 Mar 2015 10:44:57 -0800 [thread overview]
Message-ID: <54F8A429.5090506@freedesktop.org> (raw)
In-Reply-To: <1425572420-10067-1-git-send-email-damien.lespiau@intel.com>
Based on light reading, patches 1, 5, 6, 7, 8, 10, and 11 are
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
I sent a comment on patch 9. I'll try to look at the others in the next
few days... assuming nobody beats me to it.
I'm also going to send some similar Mesa patches that I'll CC you on.
On 03/05/2015 08:20 AM, Damien Lespiau wrote:
> A couple of things I wanted to do for the longest time:
>
> - Have (intel's) libdrm use the kernel i915_pciids.h so we can just copy the
> file when updating
> - Start a new object, struct drm_intel_device where we could put common code
> across several userspace projects. For instance it could be where we put
> the "number of threads" logic we need to use in several 3d/gpgpu
> states/instructions (that's a bit fiddly starting with CHV: we can't use
> static tables anymore and need a runtime query to the kernel)
>
> I tested it a bit so it can't be totally wrong:
>
> - I ran with this series on a couple of machines with no noticeable problem
> - I check that the INTEL_DEVID_OVERRIDE env variable was still working (to
> dump AUB files)
> - make check, which exercises changes in the decoder path, still passes
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-05 18:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 16:20 [PATCH libdrm 00/12] Introduce drm_intel_device and use i915_pciid.h Damien Lespiau
2015-03-05 16:20 ` [PATCH 01/12] intel: Remove unused define IS_MOBILE() Damien Lespiau
2015-03-05 16:20 ` [PATCH 02/12] intel: Introduce an drm_intel_device object Damien Lespiau
2015-03-05 16:20 ` [PATCH 03/12] intel: Use drm_intel_device in the gem buffer manager Damien Lespiau
2015-03-05 16:20 ` [PATCH 04/12] intel: Make drm_intel_decode use a drm_intel_device Damien Lespiau
2015-03-05 16:20 ` [PATCH 05/12] intel: Use '||' for the boolean or Damien Lespiau
2015-03-05 16:20 ` [PATCH 06/12] intel: Kill the IS_9XX() macro Damien Lespiau
2015-03-05 16:20 ` [PATCH 07/12] intel: Kill the IS_GEN4() macro Damien Lespiau
2015-03-05 16:20 ` [PATCH 08/12] intel: Remove direct usage of IS_915() Damien Lespiau
2015-03-05 16:20 ` [PATCH 09/12] intel: Provide IS_GENX() macros taking a drm_intel_device as argument Damien Lespiau
2015-03-05 18:41 ` Ian Romanick
2015-03-05 18:45 ` Damien Lespiau
2015-03-05 16:20 ` [PATCH 10/12] intel: Make test_decode fail gracefully the decode context is NULL Damien Lespiau
2015-03-05 16:20 ` [PATCH 11/12] intel: Make test_decode not depend on intel_chipset.h Damien Lespiau
2015-03-05 16:20 ` [PATCH 12/12] intel: Remove intel_chipset.h Damien Lespiau
2015-03-05 18:44 ` Ian Romanick [this message]
2015-03-06 14:10 ` [PATCH libdrm 00/12] Introduce drm_intel_device and use i915_pciid.h Emil Velikov
2015-03-06 14:35 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F8A429.5090506@freedesktop.org \
--to=idr@freedesktop.org \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox