Re: [PATCH v2 09/12] drm/i915: Rewrite VLV/CHV watermark code

Daniel Vetter
2015-03-06T17:39:00Z

On Fri, Mar 06, 2015 at 09:31:20AM -0800, Jesse Barnes wrote:
> I wonder if we should be warning if the wm values we end up with exceed
> the mask size (the fact that you write them with a shift and mask made
> me think of it), but that could be a follow on, or even put into the
> calc code instead. Anyway that's something we can do later after all
> the atomic changes hit.

Hm, I've thought the overall plan for wm computation code is that we
calculate the wm lines we need and then the magic atomic consolidation
step meshes it all together appropriately. But hey I actually about
something approaching 0 clue on this topic, it's really all magic here ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch