Re: [PATCH 48/51] drm/i915: Update intel_ring_begin() to take a request structure

Chris Wilson
2015-02-13T12:20:43Z

On Fri, Feb 13, 2015 at 11:48:57AM +0000, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Now that everything above has been converted to use requests, intel_ring_begin()
> can be updated to take a request instead of a ring. This also means that it no
> longer needs to lazily allocate a request if no-one happens to have done it
> earlier.

Hmm, you missed out on returning @ring@ from intel_ring_begin() to make it
explicit that accessing @ring@ through any other means is verboten.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre