Re: [PATCH 49/51] drm/i915: Update intel_logical_ring_begin() to take a request structure

Chris Wilson
2015-02-13T12:17:04Z

On Fri, Feb 13, 2015 at 11:48:58AM +0000, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Now that everything above has been converted to use requests,
> intel_logical_ring_begin() can be updated to take a request instead of a
> ringbuf/context pair. This also means that it no longer needs to lazily allocate
> a request if no-one happens to have done it earlier.
>
> Note that this change makes the execlist signature the same as the legacy
> version. Thus the two functions could be merged into a ring->begin() wrapper if
> required.

It should be noted that you don't even need to virtualise the
function... Please kill all the duplicated code.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre