From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/9] drm/i915: Reduce clutter by using the local plane pointer
Date: Tue, 10 Mar 2015 09:00:45 -0700 [thread overview]
Message-ID: <54FF152D.1070202@virtuousgeek.org> (raw)
In-Reply-To: <1425986129-15547-3-git-send-email-ville.syrjala@linux.intel.com>
On 03/10/2015 04:15 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> No need to go dig throguh intel_crtc->base.cursor when we already have
> the same thing as 'plane' local variable.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1d5107e..0da3abf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12299,7 +12299,7 @@ intel_check_cursor_plane(struct drm_plane *plane,
>
> finish:
> if (intel_crtc->active) {
> - if (intel_crtc->base.cursor->state->crtc_w != state->base.crtc_w)
> + if (plane->state->crtc_w != state->base.crtc_w)
> intel_crtc->atomic.update_wm = true;
>
> intel_crtc->atomic.fb_bits |=
>
At least it looks like we'll always get the right plane obj here. :)
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-10 15:59 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 11:15 [PATCH 0/9] drm/i915: Update derived plane state at crtc enable/disable ville.syrjala
2015-03-10 11:15 ` [PATCH 1/9] drm/i915: Remove debug prints from primary plane update funcs ville.syrjala
2015-03-10 15:55 ` Jesse Barnes
2015-03-10 11:15 ` [PATCH 2/9] drm/i915: Reduce clutter by using the local plane pointer ville.syrjala
2015-03-10 16:00 ` Jesse Barnes [this message]
2015-03-10 11:15 ` [PATCH 3/9] drm/i915: Use plane->state->fb instead of plane->fb in intel_plane_restore() ville.syrjala
2015-03-10 17:01 ` Matt Roper
2015-03-10 17:48 ` Ville Syrjälä
2015-03-11 9:41 ` Daniel Vetter
2015-03-11 10:04 ` Daniel Vetter
2015-03-10 11:15 ` [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable ville.syrjala
2015-03-10 17:01 ` Matt Roper
2015-03-10 17:57 ` Ville Syrjälä
2015-03-11 9:52 ` Daniel Vetter
2015-03-11 10:03 ` Daniel Vetter
2015-03-11 10:05 ` Ville Syrjälä
2015-03-11 10:24 ` Daniel Vetter
2015-03-11 12:19 ` Ville Syrjälä
2015-03-11 16:23 ` Daniel Vetter
2015-03-11 16:40 ` Ville Syrjälä
2015-03-10 11:15 ` [PATCH 5/9] drm/i915: Pass primary plane size to .update_primary_plane() ville.syrjala
2015-03-10 17:10 ` Matt Roper
2015-03-10 17:59 ` Ville Syrjälä
2015-03-10 20:57 ` Matt Roper
2015-03-11 9:42 ` Ville Syrjälä
2015-03-11 9:57 ` Daniel Vetter
2015-03-11 5:09 ` sonika
2015-03-11 9:27 ` Ville Syrjälä
2015-03-11 9:26 ` sonika
2015-03-19 14:28 ` [PATCH v2 " ville.syrjala
2015-03-20 9:49 ` Jindal, Sonika
2015-03-20 10:04 ` Ville Syrjälä
2015-03-20 10:53 ` Jindal, Sonika
2015-03-20 14:26 ` Ville Syrjälä
2015-03-23 4:11 ` sonika
2015-03-10 11:15 ` [PATCH 6/9] drm/i915: Pass the primary plane position " ville.syrjala
2015-03-19 14:29 ` [PATCH v2 " ville.syrjala
2015-03-20 11:22 ` Jindal, Sonika
2015-03-10 11:15 ` [PATCH 7/9] drm/i915: Update watermarks after the derived plane state is uptodate ville.syrjala
2015-03-10 17:13 ` Matt Roper
2015-03-11 9:59 ` Daniel Vetter
2015-03-10 11:15 ` [PATCH 8/9] drm/i915: Use state->visible in wm calculation ville.syrjala
2015-03-10 17:19 ` Matt Roper
2015-03-10 18:01 ` Ville Syrjälä
2015-03-19 14:31 ` [PATCH v2 " ville.syrjala
2015-03-10 11:15 ` [PATCH 9/9] drm/i915: Don't re-enable an explicitly disabled primary plane due to sprite coverage changes ville.syrjala
2015-03-10 17:58 ` shuang.he
2015-03-11 10:00 ` Daniel Vetter
2015-03-11 10:09 ` Ville Syrjälä
2015-03-11 10:28 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF152D.1070202@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox