From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Remove temporary allocation of dma addresses when rotating Date: Mon, 27 Feb 2017 09:55:10 +0000 Message-ID: <54ae3e3a-61f7-0471-d44a-bf4c78f23a32@linux.intel.com> References: <20170217151008.29657-1-chris@chris-wilson.co.uk> <1487689281.3137.23.camel@linux.intel.com> <20170222084417.GE10557@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29D556E330 for ; Mon, 27 Feb 2017 09:55:14 +0000 (UTC) In-Reply-To: <20170222084417.GE10557@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Joonas Lahtinen , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzAyLzIwMTcgMDg6NDQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBXZWQsIEZlYiAy MiwgMjAxNyBhdCAwODoyOTowNkFNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4KPj4g T24gMjEvMDIvMjAxNyAxNTowMSwgSm9vbmFzIExhaHRpbmVuIHdyb3RlOgo+Pj4gT24gcGUsIDIw MTctMDItMTcgYXQgMTU6MTAgKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4+PiBUaGUgb2Jq ZWN0IGFscmVhZHkgc3RvcmVzIChjb21wdXRlZCBvbiB0aGUgZmx5KSB0aGUgaW5kZXggdG8gZG1h IGFkZHJlc3MKPj4+PiBzbyB1c2UgaXQgaW5zdGVhZCBvZiByZWFsbG9jYXRpbmcgYSBsYXJnZSB0 ZW1wb3JhcnkgYXJyYXkgZXZlcnkgdGltZSB3ZQo+Pj4+IGJpbmQgYSByb3RhdGVkIGZyYW1lYnVm ZmVyLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13 aWxzb24uY28udWs+Cj4+Pj4gQ2M6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy53aWxsaWFtLmF1bGRA Z21haWwuY29tPgo+Pj4+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51 eC5pbnRlbC5jb20+Cj4+Pj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRl bC5jb20+Cj4+Pgo+Pj4gPFNOSVA+Cj4+Pgo+Pj4+ICtyb3RhdGVfcGFnZXMoc3RydWN0IGRybV9p OTE1X2dlbV9vYmplY3QgKm9iaiwKPj4+PiArCSAgICAgY29uc3Qgc3RydWN0IGludGVsX3JvdGF0 aW9uX3BsYW5lX2luZm8gKnAsCj4+Pj4gCSAgICAgc3RydWN0IHNnX3RhYmxlICpzdCwgc3RydWN0 IHNjYXR0ZXJsaXN0ICpzZykKPj4+PiB7Cj4+Pj4gCXVuc2lnbmVkIGludCBjb2x1bW4sIHJvdzsK Pj4+PiAtCXVuc2lnbmVkIGludCBzcmNfaWR4Owo+Pj4+Cj4+Pj4gLQlmb3IgKGNvbHVtbiA9IDA7 IGNvbHVtbiA8IHdpZHRoOyBjb2x1bW4rKykgewo+Pj4+IC0JCXNyY19pZHggPSBzdHJpZGUgKiAo aGVpZ2h0IC0gMSkgKyBjb2x1bW47Cj4+Pj4gLQkJZm9yIChyb3cgPSAwOyByb3cgPCBoZWlnaHQ7 IHJvdysrKSB7Cj4+Pj4gLQkJCXN0LT5uZW50cysrOwo+Pj4+ICsJZm9yIChjb2x1bW4gPSAwOyBj b2x1bW4gPCBwLT53aWR0aDsgY29sdW1uKyspIHsKPj4+PiArCQl1bnNpZ25lZCBsb25nIHNyY19p ZHggPQo+Pj4+ICsJCQlwLT5zdHJpZGUgKiAocC0+aGVpZ2h0IC0gMSkgKyBjb2x1bW4gKyBwLT5v ZmZzZXQ7Cj4+Pj4gKwkJZm9yIChyb3cgPSAwOyByb3cgPCBwLT5oZWlnaHQ7IHJvdysrKSB7Cj4+ Pj4gKwkJCXN0cnVjdCBzY2F0dGVybGlzdCAqc3JjOwo+Pj4+ICsJCQl1bnNpZ25lZCBpbnQgbjsK Pj4+PiArCj4+Pj4gKwkJCXNyYyA9IGk5MTVfZ2VtX29iamVjdF9nZXRfc2cob2JqLCBzcmNfaWR4 LCAmbik7Cj4+Pgo+Pj4gaTkxNV9nZW1fb2JqZWN0X2dldF9zZyBoYXMgdmFyaWFibGUgbmFtZXMg b2JqLCBuLCAqb2Zmc2V0LCBzbyBJJ2QgYmUKPj4+IGxpdHRsZSBjb25jZXJuZWQgb2Ygc2lkZXRy YWNraW5nIHJlYWRlci4gUmVuYW1lIG4gaW50byBvZmZzZXQ/CgpPciB1c2UgaTkxNV9nZW1fb2Jq ZWN0X2dldF9kbWFfYWRkcmVzcyBpbiB0aGUgc2dfZG1hX2FkcmVzc19hc3NpZ25tZW50IApkaXJl Y3RseS4KCj4+Pgo+Pj4+ICsJCQlzcmNfaWR4IC09IHAtPnN0cmlkZTsKPj4+PiArCj4+Pj4gCQkJ LyogV2UgZG9uJ3QgbmVlZCB0aGUgcGFnZXMsIGJ1dCBuZWVkIHRvIGluaXRpYWxpemUKPj4+PiAJ CQkgKiB0aGUgZW50cmllcyBzbyB0aGUgc2cgbGlzdCBjYW4gYmUgaGFwcGlseSB0cmF2ZXJzZWQu Cj4+Pj4gCQkJICogVGhlIG9ubHkgdGhpbmcgd2UgbmVlZCBhcmUgRE1BIGFkZHJlc3Nlcy4KPj4+ PiAJCQkgKi8KPj4+PiAJCQlzZ19zZXRfcGFnZShzZywgTlVMTCwgUEFHRV9TSVpFLCAwKTsKPj4+ PiAtCQkJc2dfZG1hX2FkZHJlc3Moc2cpID0gaW5bb2Zmc2V0ICsgc3JjX2lkeF07Cj4+Pj4gKwkJ CXNnX2RtYV9hZGRyZXNzKHNnKSA9IHNnX2RtYV9hZGRyZXNzKHNyYykgKyBuKlBBR0VfU0laRTsK Pj4+PiAJCQlzZ19kbWFfbGVuKHNnKSA9IFBBR0VfU0laRTsKPj4+PiAtCQkJc2cgPSBzZ19uZXh0 KHNnKTsKPj4+PiAtCQkJc3JjX2lkeCAtPSBzdHJpZGU7Cj4+Pgo+Pj4gSSdtIG5vdCBzdXJlIHdo eSBtb3ZpbmcgdGhpcyBsaW5lLCBtaWdodCBhcyB3ZWxsIGhvaXN0IGFsbCB0aGVzZSB0byB0aGUK Pj4+IGZvcigpIGxpbmUuCj4+Pgo+Pj4+ICsJCQlzZyA9IF9fc2dfbmV4dChzZyk7Cj4+Pj4gKwo+ Pj4+ICsJCQlzdC0+bmVudHMrKzsKPj4+PiAJCX0KPj4+PiAJfQo+Pj4+Cj4+Pj4gQEAgLTMwNzQs NjIgKzMwNzksMzAgQEAgc3RhdGljIG5vaW5saW5lIHN0cnVjdCBzZ190YWJsZSAqCj4+Pj4gaW50 ZWxfcm90YXRlX3BhZ2VzKHN0cnVjdCBpbnRlbF9yb3RhdGlvbl9pbmZvICpyb3RfaW5mbywKPj4+ PiAJCSAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4+Pj4gewo+Pj4+IC0JY29u c3QgdW5zaWduZWQgbG9uZyBuX3BhZ2VzID0gb2JqLT5iYXNlLnNpemUgLyBQQUdFX1NJWkU7Cj4+ Pj4gLQl1bnNpZ25lZCBpbnQgc2l6ZSA9IGludGVsX3JvdGF0aW9uX2luZm9fc2l6ZShyb3RfaW5m byk7Cj4+Pj4gLQlzdHJ1Y3Qgc2d0X2l0ZXIgc2d0X2l0ZXI7Cj4+Pj4gLQlkbWFfYWRkcl90IGRt YV9hZGRyOwo+Pj4+IC0JdW5zaWduZWQgbG9uZyBpOwo+Pj4+IC0JZG1hX2FkZHJfdCAqcGFnZV9h ZGRyX2xpc3Q7Cj4+Pj4gLQlzdHJ1Y3Qgc2dfdGFibGUgKnN0Owo+Pj4+ICsJY29uc3QgdW5zaWdu ZWQgaW50IHNpemUgPSBpbnRlbF9yb3RhdGlvbl9pbmZvX3NpemUocm90X2luZm8pOwo+Pj4KPj4+ IFRoaXMgaXMgb25seSB1c2VkIG9uY2UsIGp1c3QgaW5saW5lIGl0Lgo+Pj4KPj4+IFJldmlld2Vk LWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4+ Pgo+Pj4gQ291bGQgdXNlIGFuIEEtYiBmcm9tIFR2cnRrby4KPj4KPj4gSSBkaWQgbm90IGxpa2Ug aXQgaW4gYW5vdGhlciB0aHJlYWQsIHdlbGwsIGJldHRlciBzYXkgSSB3YXMKPj4gY29uY2VybmVk IGFib3V0IHRoZSBpbmNyZWFzZWQgbWVtb3J5IHVzZSBieSB0aGUgcmFkaXggdHJlZSB3aGljaAo+ PiB3b3VsZCB0aGVuIHN0aWNrIGFyb3VuZCBmb3IgdGhlIG9iai0+cGFnZXMgbGlmZXRpbWUgKGxv bmcgdGltZSBmb3IgYQo+PiBmcmFtZWJ1ZmZlciBJIHRob3VnaHQpLiBXaGlsZSB0aGUgdGVtcG9y YXJ5IGFycmF5IGFsbG9jYXRpb25zIGhlcmUKPj4gYXJlIG5vdCB0aGF0IGJpZyBhbmQgdmVyeSB0 ZW1wb3JhcnkuCj4+Cj4+IEkgZ3Vlc3Mgc29tZW9uZSBuZWVkcyB0byBiaXRlIHRoZSBidWxsZXQg YW5kIHRyeSBhbmQgZmlndXJlIG91dCBob3cKPj4gZXhhY3RseSBiaWcgaXMgdGhlIHJhZGl4IHRy ZWUgZm9yIHNvbWUgbWl4ZXMgb2YgbW9yZSBvciBsZXNzCj4+IGNvYWxlc2NlZCBzZyBlbnRyaWVz Lgo+Cj4gSSBhbHNvIHRoaW5rIHRoYXQncyBhbiBhcmd1bWVudCBmb3IgaW1wcm92aW5nIHRoZSBn ZW5lcmFsIGNhY2hlIHJhdGhlcgo+IHRoYW4gYXJndWluZyBhZ2FpbnN0IHVzaW5nIGl0LgoKV2Vs bCBJIHdhc24ndCBjb25jZXJuZWQgYWJvdXQgdGhlIGNhY2hlIHBlciBzZSwgYnV0IGFib3V0IHdo ZXRoZXIgaXQgaXMgCmNvbXBsZXRlbHkgYXBwcm9wcmlhdGUgKGJlc3QgY2hvaWNlKSB0byB1c2Ug aXQgaW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UuCgpCZWNhdXNlIGFzIEkgc2FpZCBiZWZvcmUsIGZv ciAxOTIweDEwODB4MzIgd2UgYXJlIHRhbGtpbmcgYWJvdXQgYSAxNktpQiAKZXh0cmVtZWx5IHNo b3J0IGxpdmVkIHRlbXBvcmFyeSBhbGxvY2F0aW9uLCB2cyB0aGUgc2ltaWxhciBzaXplIGZvciB0 aGUgCnNnIHJhZGl4IGNhY2hlLiBCdXQgcmFkaXggY2FjaGUgc3RpY2tzIGFyb3VuZCB0aGUgdGhl IGxpZmV0aW1lIG9mIApvYmotPm1tLnBhZ2VzIGFuZCBpdCB3b3VsZG4ndCBvdGhlcndpc2UgYmUg dGhlcmUgc2luY2UgQUZBSUNTIGluIApwcmFjdGljZSBubyBvbmUgcmVhbGx5IHRvdWNoZXMgZnJh bWUgYnVmZmVycyBpbiBhIHdheSB0byB0cmlnZ2VyIGl0cyAKY3JlYXRpb24uCgpUaG9zZSBhbW91 bnRzIG9mIG1lbW9yeSBhcmUgbm90IGEgY29uY2VybiwgYnV0IGFnYWluLCBpcyB0aGUgCnNpbXBs aWZpY2F0aW9uIG9mIHRoZSBjb2RlIHdvcnRoIHRoZSBjb25jZXB0dWFsIGRvd25zaWRlcyBtZW50 aW9uZWQgCmFib3ZlPyBFdmVuIGlmIHdlIGNvbnNpZGVyZWQgNEsgZnJhbWUgYnVmZmVycywgd2hl biBib3RoIGFsbG9jYXRpb25zIGdvIAp0byB+NjRLaUIsIHdvdWxkIHRoYXQgY2hhbmdlIGFueXRo aW5nPyBJIGFtIG5vdCBzdXJlLCBwcm9iYWJseSBub3QgZm9yIG1lLgoKU28gSSBhbSBzdGlsbCB1 bnN1cmUgdGhhdCB3ZSBzaG91bGQgZ28gd2l0aCB0aGlzIGNoYW5nZS4KClJlZ2FyZHMsCgpUdnJ0 a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==