Re: [PATCH 2/5] drm/i915: Re-adjusting rc6 promotional timer for chv

Deepak S
2015-03-24T03:08:49Z

On Tuesday 24 March 2015 01:13 AM, Paulo Zanoni wrote:
> 2015-02-26 12:16 GMT-03:00 <deepak.s@linux.intel.com>:
>> From: Deepak S <deepak.s@linux.intel.com>
>>
>> After feedback from the hardware team we are changing the RC6
>> promotional timer to increase the power saving without
>> changing performance.
> I can't really say whether this is really what we want since I didn't
> do any measurements, but the patch seems to do what it says, so:
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Hi Paulo,

Measurements was done by hardware team :)

Thanks
Deepak

>> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 7dcb5b6..90cb6c9 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -4799,8 +4799,8 @@ static void cherryview_enable_rps(struct drm_device *dev)
>> I915_WRITE(RING_MAX_IDLE(ring->mmio_base), 10);
>> I915_WRITE(GEN6_RC_SLEEP, 0);
>>
>> - /* TO threshold set to 1750 us ( 0x557 * 1.28 us) */
>> - I915_WRITE(GEN6_RC6_THRESHOLD, 0x557);
>> + /* TO threshold set to 500 us ( 0x186 * 1.28 us) */
>> + I915_WRITE(GEN6_RC6_THRESHOLD, 0x186);
>>
>> /* allows RC6 residency counter to work */
>> I915_WRITE(VLV_COUNTER_CONTROL,
>> --
>> 1.9.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx