Re: [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 03/09/2015 09:55 AM, Chris Wilson wrote:
> Since we use obj->active as a hint in many places throughout the code,
> knowing its state in debugfs is extremely useful.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 042ad2fec484..809f6eadc10c 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -123,8 +123,9 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
>   	struct i915_vma *vma;
>   	int pin_count = 0;
>
> -	seq_printf(m, "%pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s",
> +	seq_printf(m, "%pK: %s%s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s",
>   		   &obj->base,
> +		   obj->active ? "*" : " ",

%c etc would maybe be more compact code? (Hey I have to earn my 
bike-shedding badge somehow! ;) Anyway,

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

This now completes the series apart from I think two respins - rebase 
for possible extra unpin and missing lrc destructor.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx