From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915: Split batch pool into size buckets
Date: Fri, 20 Mar 2015 09:25:31 +0000 [thread overview]
Message-ID: <550BE78B.9010706@linux.intel.com> (raw)
In-Reply-To: <20150319210937.GA10812@nuc-i3427.alporthouse.com>
On 03/19/2015 09:09 PM, Chris Wilson wrote:
> On Thu, Mar 19, 2015 at 05:35:35PM +0000, Tvrtko Ursulin wrote:
>>> - list_for_each_entry_safe(tmp, next,
>>> - &pool->cache_list, batch_pool_list) {
>>> + n = fls(size >> PAGE_SHIFT) - 1;
>>
>> Is this better in some way that size / PAGE_SIZE - 1? Or I went from
>> trusting compiler smartness to little to too much? :)
>
> The month has 31 days in it, we use >> PAGE_SHIFT, otherwise /
> PAGE_SIZE. Note the fls() puts these into power-of-two buckets not pure
> page-count buckets.
Yeah silly me.. was thinking about 1-2 page buckets form the commit
message only. Perhaps add a comment about bucket sizes above n = fls
line if you feel like it. Shouldn't harm.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-20 9:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 9:55 [PATCH 1/6] drm/i915: Split i915_gem_batch_pool into its own header Chris Wilson
2015-03-09 9:55 ` [PATCH 2/6] drm/i915: Tidy batch pool logic Chris Wilson
2015-03-17 17:42 ` Tvrtko Ursulin
2015-03-17 20:53 ` Chris Wilson
2015-03-09 9:55 ` [PATCH 3/6] drm/i915: Split the batch pool by engine Chris Wilson
2015-03-18 16:51 ` Tvrtko Ursulin
2015-03-18 17:27 ` Chris Wilson
2015-03-18 17:33 ` Tvrtko Ursulin
2015-03-19 9:36 ` Tvrtko Ursulin
2015-03-19 10:06 ` Chris Wilson
2015-03-19 11:39 ` Tvrtko Ursulin
2015-03-19 11:46 ` Chris Wilson
2015-03-19 11:58 ` Tvrtko Ursulin
2015-03-19 12:04 ` Chris Wilson
2015-03-19 14:01 ` Tvrtko Ursulin
2015-03-19 14:34 ` Chris Wilson
2015-03-09 9:55 ` [PATCH 4/6] drm/i915: Free batch pool when idle Chris Wilson
2015-03-19 17:03 ` Tvrtko Ursulin
2015-03-19 17:14 ` Chris Wilson
2015-03-19 17:27 ` Tvrtko Ursulin
2015-03-09 9:55 ` [PATCH 5/6] drm/i915: Split batch pool into size buckets Chris Wilson
2015-03-19 17:35 ` Tvrtko Ursulin
2015-03-19 21:09 ` Chris Wilson
2015-03-20 9:25 ` Tvrtko Ursulin [this message]
2015-03-09 9:55 ` [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs Chris Wilson
2015-03-09 14:59 ` shuang.he
2015-03-19 17:41 ` Tvrtko Ursulin
2015-03-19 21:05 ` Chris Wilson
2015-03-20 9:23 ` Tvrtko Ursulin
2015-03-19 17:37 ` [PATCH 1/6] drm/i915: Split i915_gem_batch_pool into its own header Tvrtko Ursulin
2015-03-19 21:06 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550BE78B.9010706@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox