From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sivakumar Thulasimani Subject: Re: [PATCH 48/49] drm/i915/bxt: VSwing programming sequence Date: Tue, 24 Mar 2015 14:49:30 +0530 Message-ID: <55112C22.4060905@intel.com> References: <1426585215-8788-1-git-send-email-imre.deak@intel.com> <1426585215-8788-49-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1655898809==" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id C1E316E020 for ; Tue, 24 Mar 2015 02:19:32 -0700 (PDT) In-Reply-To: <1426585215-8788-49-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1655898809== Content-Type: multipart/alternative; boundary="------------040805080001060701090403" This is a multi-part message in MIME format. --------------040805080001060701090403 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/17/2015 3:10 PM, Imre Deak wrote: > From: Vandana Kannan > > VSwing programming sequence as specified in the updated BXT BSpec > ... > ... > > +void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level, > + enum port port, int type) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + const struct bxt_ddi_buf_trans *ddi_translations; > + u32 n_entries, i; > + uint32_t val; > + > + if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) { INTEL_OUPPUT_DP_MST might be needed here, please check once. otherwise fine with the changes. Reviewed-by: Sivakumar Thulasimani --------------040805080001060701090403 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

On 3/17/2015 3:10 PM, Imre Deak wrote:

From: Vandana Kannan <vandana.kannan@intel.com>

VSwing programming sequence as specified in the updated BXT BSpec
...
...
 
+void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level,
+			     enum port port, int type)
+{
+	struct drm_i915_private *dev_priv = dev->dev_private;
+	const struct bxt_ddi_buf_trans *ddi_translations;
+	u32 n_entries, i;
+	uint32_t val;
+
+	if (type == INTEL_OUTPUT_DISPLAYPORT || type == INTEL_OUTPUT_EDP) {

INTEL_OUPPUT_DP_MST might be needed here, please check once. otherwise fine with the changes.
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>

--------------040805080001060701090403-- --===============1655898809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1655898809==--