Re: [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On 03/24/2015 04:23 AM, Tvrtko Ursulin wrote:
> 
> On 03/23/2015 07:43 PM, Jesse Barnes wrote:
>> Or users can just spam the log all they want.
>>
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=89628
>> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>> ---
>>   drivers/gpu/drm/i915/intel_display.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index 589addf..c48e2d7 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -12831,8 +12831,8 @@ static int intel_framebuffer_init(struct
>> drm_device *dev,
>>       case I915_FORMAT_MOD_X_TILED:
>>           break;
>>       default:
>> -        DRM_ERROR("Unsupported fb modifier 0x%llx!\n",
>> -                mode_cmd->modifier[0]);
>> +        DRM_DEBUG("Unsupported fb modifier 0x%llx!\n",
>> +              mode_cmd->modifier[0]);
>>           return -EINVAL;
>>       }
> 
> Ooops! The one that got away.. I always think about this very issue as
> you can see from three DRM_DEBUGs just above this offender. No idea how
> this one sneaked in but thanks for fixing it!

Yeah no problem, we used to have a lot more but I think we're getting
better.  One sneaks in every now and then though!

Jesse

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx