From: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Add psr_enabled on pipe_config
Date: Wed, 25 Mar 2015 12:34:12 +0530 [thread overview]
Message-ID: <55125DEC.6030402@intel.com> (raw)
In-Reply-To: <1427224333-2446-1-git-send-email-rodrigo.vivi@intel.com>
> _crtc_state *pipe_config)
> {
> @@ -5812,6 +5844,8 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc,
> pipe_config->pipe_bpp = 8*3;
> }
>
> + intel_compute_psr_config(crtc, pipe_config);
> +
> if (HAS_IPS(dev))
> hsw_compute_ips_config(crtc, pipe_config);
>
is it required to update psr_enabled during every call to
intel_crtc_compute_config ? all conditions being checked will never
change post init so it will be better to do this as part of eDP init
rather than here.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-25 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 19:12 [PATCH 1/2] drm/i915: Add psr_enabled on pipe_config Rodrigo Vivi
2015-03-24 19:12 ` [PATCH 2/2] drm/i915: Only enabled DRRS if PRS won't be enabled on this pipe Rodrigo Vivi
2015-03-24 23:17 ` shuang.he
2015-03-25 10:38 ` Ramalingam C
2015-03-25 15:41 ` Vivi, Rodrigo
2015-03-26 14:39 ` Ramalingam C
2015-03-26 19:21 ` Rodrigo Vivi
2015-03-30 9:49 ` Ramalingam C
2015-03-30 15:39 ` Daniel Vetter
2015-03-31 13:34 ` Daniel Vetter
2015-03-25 7:04 ` Sivakumar Thulasimani [this message]
2015-03-25 20:21 ` [PATCH 1/2] drm/i915: Add psr_enabled on pipe_config Rodrigo Vivi
2015-03-26 14:50 ` Ramalingam C
2015-03-26 19:20 ` [PATCH 1/2] drm/i915: Add psr_ready " Rodrigo Vivi
2015-03-27 6:07 ` Sivakumar Thulasimani
2015-03-27 8:32 ` Daniel Vetter
2015-03-27 9:00 ` Sivakumar Thulasimani
2015-03-30 9:50 ` Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55125DEC.6030402@intel.com \
--to=sivakumar.thulasimani@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox