From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH] drm: Defer disabling the vblank IRQ until the next interrupt (for instant-off) Date: Wed, 15 Apr 2015 03:03:10 +0200 Message-ID: <552DB8CE.9020500@gmail.com> References: <1426607071-20515-1-git-send-email-chris@chris-wilson.co.uk> <1427974453-10633-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1427974453-10633-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , dri-devel@lists.freedesktop.org Cc: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= , Laurent Pinchart , Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDQvMDIvMjAxNSAwMTozNCBQTSwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IE9uIHZibGFuayBp bnN0YW50LW9mZiBzeXN0ZW1zLCB3ZSBjYW4gZ2V0IGludG8gYSBzaXR1YXRpb24gd2hlcmUgdGhl IGNvc3QKPiBvZiBlbmFibGluZyBhbmQgZGlzYWJsaW5nIHRoZSB2YmxhbmsgSVJRIGFyb3VuZCBh IGRybVdhaXRWYmxhbmsgcXVlcnkKPiBkb21pbmF0ZXMuIEhvd2V2ZXIsIHdlIGtub3cgdGhhdCBp ZiB0aGUgdXNlciB3YW50cyB0aGUgY3VycmVudCB2YmxhbmsKPiBjb3VudGVyLCB0aGV5IGFyZSBh bHNvIHZlcnkgbGlrZWx5IHRvIGltbWVkaWF0ZWx5IHF1ZXVlIGEgdmJsYW5rIHdhaXQKPiBhbmQg c28gd2UgY2FuIGtlZXAgdGhlIGludGVycnVwdCBhcm91bmQgYW5kIG9ubHkgdHVybiBpdCBvZmYg aWYgd2UgaGF2ZQo+IG5vIGZ1cnRoZXIgdmJsYW5rIHJlcXVlc3RzIGluIHRoZSBpbnRlcnJ1cHQg aW50ZXJ2YWwuCj4KPiBBZnRlciB2YmxhbmsgZXZlbnQgZGVsaXZlcnkgdGhlcmUgaXMgYSBzaGFk b3cgb2Ygb25lIHZibGFuayB3aGVyZSB0aGUKPiBpbnRlcnJ1cHQgaXMga2VwdCBhbGl2ZSBmb3Ig dGhlIHVzZXIgdG8gcXVlcnkgYW5kIHF1ZXVlIGFub3RoZXIgdmJsYW5rCj4gZXZlbnQuIFNpbWls YXJseSwgaWYgdGhlIHVzZXIgaXMgdXNpbmcgYmxvY2tpbmcgZHJtV2FpdFZibGFua3MsIHRoZQo+ IGludGVycnVwdCB3aWxsIGJlIGRpc2FibGVkIG9uIHRoZSBJUlEgZm9sbG93aW5nIHRoZSB3YWl0 IGNvbXBsZXRpb24uCj4gSG93ZXZlciwgaWYgdGhlIHVzZXIgaXMgc2ltcGx5IHF1ZXJ5aW5nIHRo ZSBjdXJyZW50IHZibGFuayBjb3VudGVyIGFuZAo+IHRpbWVzdGFtcCwgdGhlIGludGVycnVwdCB3 aWxsIGJlIGRpc2FibGVkIGFmdGVyIGV2ZXJ5IElSUSBhbmQgdGhlIHVzZXIKPiB3aWxsIGVuYWJs ZWQgaXQgYWdhaW4gb24gdGhlIGZpcnN0IHF1ZXJ5IGZvbGxvd2luZyB0aGUgSVJRLgo+Cj4gVGVz dGNhc2U6IGlndC9rbXNfdmJsYW5rCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4K PiBDYzogTWljaGVsIETDpG56ZXIgPG1pY2hlbEBkYWVuemVyLm5ldD4KPiBDYzogTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IENjOiBEYXZlIEFp cmxpZSA8YWlybGllZEByZWRoYXQuY29tPiwKPiBDYzogTWFyaW8gS2xlaW5lciA8bWFyaW8ua2xl aW5lci5kZUBnbWFpbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jIHwg MTUgKysrKysrKysrKysrKy0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+IGluZGV4IGM4YTM0NDc2NTcwYS4uNmY1ZGMx ODc3OWUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gQEAgLTEwOTEsOSArMTA5MSw5IEBAIHZvaWQgZHJt X3ZibGFua19wdXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGNydGMpCj4gICAJaWYgKGF0 b21pY19kZWNfYW5kX3Rlc3QoJnZibGFuay0+cmVmY291bnQpKSB7Cj4gICAJCWlmIChkcm1fdmJs YW5rX29mZmRlbGF5ID09IDApCj4gICAJCQlyZXR1cm47Cj4gLQkJZWxzZSBpZiAoZGV2LT52Ymxh bmtfZGlzYWJsZV9pbW1lZGlhdGUgfHwgZHJtX3ZibGFua19vZmZkZWxheSA8IDApCj4gKwkJZWxz ZSBpZiAoZHJtX3ZibGFua19vZmZkZWxheSA8IDApCj4gICAJCQl2YmxhbmtfZGlzYWJsZV9mbigo dW5zaWduZWQgbG9uZyl2YmxhbmspOwo+IC0JCWVsc2UKPiArCQllbHNlIGlmICghZGV2LT52Ymxh bmtfZGlzYWJsZV9pbW1lZGlhdGUpCj4gICAJCQltb2RfdGltZXIoJnZibGFuay0+ZGlzYWJsZV90 aW1lciwKPiAgIAkJCQkgIGppZmZpZXMgKyAoKGRybV92Ymxhbmtfb2ZmZGVsYXkgKiBIWikvMTAw MCkpOwo+ICAgCX0KPiBAQCAtMTY5Nyw2ICsxNjk3LDE3IEBAIGJvb2wgZHJtX2hhbmRsZV92Ymxh bmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGNydGMpCj4KPiAgIAlzcGluX2xvY2tfaXJx c2F2ZSgmZGV2LT5ldmVudF9sb2NrLCBpcnFmbGFncyk7Cj4KCllvdSBjb3VsZCBtb3ZlIHRoZSBj b2RlIGJlZm9yZSB0aGUgc3Bpbl9sb2NrX2lycXNhdmUoJmRldi0+ZXZlbnRfbG9jaywgCmlycWZs YWdzKTsgaSB0aGluayBpdCBkb2Vzbid0IG5lZWQgdGhhdCBsb2NrPwoKPiArCWlmIChkZXYtPnZi bGFua19kaXNhYmxlX2ltbWVkaWF0ZSAmJiAhYXRvbWljX3JlYWQoJnZibGFuay0+cmVmY291bnQp KSB7CgpBbHNvIGNoZWNrIGZvciAoZHJtX3ZibGFua19vZmZkZWxheSA+IDApIHRvIG1ha2Ugc3Vy ZSB3ZSBoYXZlIGEgd2F5IG91dCAKb2YgaW5zdGFudCBkaXNhYmxlIGhlcmUsIGFuZCB0aGUgc2Ft ZSBtZWFuaW5nIG9mIG9mIGRybV92Ymxhbmtfb2ZmZGVsYXkgCmxpa2Ugd2UgaGF2ZSBpbiB0aGUg Y3VycmVudCBpbXBsZW1lbnRhdGlvbi4KClRoaXMgaHVuayAuLi4KCj4gKwkJdW5zaWduZWQgbG9u ZyB2YmxfbG9ja19pcnFmbGFnczsKPiArCj4gKwkJc3Bpbl9sb2NrX2lycXNhdmUoJmRldi0+dmJs X2xvY2ssIHZibF9sb2NrX2lycWZsYWdzKTsKPiArCQlpZiAoYXRvbWljX3JlYWQoJnZibGFuay0+ cmVmY291bnQpID09IDAgJiYgdmJsYW5rLT5lbmFibGVkKSB7Cj4gKwkJCURSTV9ERUJVRygiZGlz YWJsaW5nIHZibGFuayBvbiBjcnRjICVkXG4iLCBjcnRjKTsKPiArCQkJdmJsYW5rX2Rpc2FibGVf YW5kX3NhdmUoZGV2LCBjcnRjKTsKPiArCQl9Cj4gKwkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgm ZGV2LT52YmxfbG9jaywgdmJsX2xvY2tfaXJxZmxhZ3MpOwoKLi4uIGlzIHRoZSBzYW1lIGFzIGEg Y2FsbCB0byB2YmxhbmtfZGlzYWJsZV9mbigodW5zaWduZWQgbG9uZykgdmJsYW5rKTsKTWF5YmUg cmVwbGFjZSBieSB0aGF0IGNhbGw/CgpZb3UgY291bGQgYWxzbyByZXR1cm4gaGVyZSBhbHJlYWR5 LCBhcyB0aGUgY29kZSBiZWxvdyB3aWxsIGp1c3QgdGFrZSBhIApsb2NrLCByZWFsaXplIHZibGFu a3MgYXJlIG5vdyBkaXNhYmxlZCBhbmQgdGhlbiByZWxlYXNlIHRoZSBsb2NrcyBhbmQgZXhpdC4K Cj4gKwl9Cj4gKwo+ICAgCS8qIE5lZWQgdGltZXN0YW1wIGxvY2sgdG8gcHJldmVudCBjb25jdXJy ZW50IGV4ZWN1dGlvbiB3aXRoCj4gICAJICogdmJsYW5rIGVuYWJsZS9kaXNhYmxlLCBhcyB0aGlz IHdvdWxkIGNhdXNlIGluY29uc2lzdGVudAo+ICAgCSAqIG9yIGNvcnJ1cHRlZCB0aW1lc3RhbXBz IGFuZCB2YmxhbmsgY291bnRzLgo+CgpJIHRoaW5rIHRoZSBsb2dpYyBpdHNlbGYgaXMgZmluZSBh bmQgYXQgbGVhc3QgYmFzaWMgdGVzdGluZyBvZiB0aGUgcGF0Y2ggCm9uIGEgSW50ZWwgSEQgSXJv bmxha2UgZGlkbid0IHNob3cgcHJvYmxlbXMsIHNvIHdpdGggdGhlIGFib3ZlIHRha2VuIAppbnRv IGFjY291bnQgaXQgd291bGQgaGF2ZSBteSBzbGlnaHRseSB1bmVhc3kgcmV2aWV3ZWQtYnkuCgpP bmUgdGhpbmcgdGhhdCB3b3JyaWVzIG1lIGEgbGl0dGxlIGJpdCBhYm91dCB0aGUgZGlzYWJsZSBp bnNpZGUgdmJsYW5rIAppcnEgYXJlIHRoZSBwb3RlbnRpYWwgcmFjZXMgYmV0d2VlbiB0aGUgZGlz YWJsZSBjb2RlIGFuZCB0aGUgZGlzcGxheSAKZW5naW5lIHdoaWNoIGNvdWxkIGNhdXNlIHJlYWxs eSBiYWQgb2ZmLWJ5LW9uZSBlcnJvcnMgZm9yIGNsaWVudHMgb24gYSAKaW1wZXJmZWN0IGRyaXZl ci4gVGhlc2UgcmFjZXMgY2FuIG9ubHkgaGFwcGVuIGlmIHZibGFuayBlbmFibGUgb3IgCmRpc2Fi bGUgaGFwcGVucyBjbG9zZSB0byBvciBpbnNpZGUgdGhlIHZibGFuay4gVGhpcyBhcHByb2FjaCBs ZXRzIHRoZSAKaW5zdGFudCBkaXNhYmxlIGhhcHBlbiBleGFjdGx5IGluc2lkZSB2Ymxhbmsgd2hl biB0aGVyZSBpcyB0aGUgaGlnaGVzdCAKY2hhbmNlIG9mIHRyaWdnZXJpbmcgdGhhdCBjb25kaXRp b24uCgpUaGlzIGRvZXNuJ3Qgc2VlbSB0byBiZSBhIHByb2JsZW0gZm9yIGludGVsIGttcywgYnV0 IG90aGVyIGRyaXZlcnMgZG9uJ3QgCmhhdmUgaW5zdGFudCBkaXNhYmxlIHlldCwgc28gd2UgZG9u J3Qga25vdyBob3cgd2VsbCB3ZSBjb3VsZCBkbyBpdCAKdGhlcmUuIEFkZGl0aW9uYWxseSB0aGlu Z3MgbGlrZSBkeW5hbWljIHBvd2VyIG1hbmFnZW1lbnQgdGVuZCB0byBvcGVyYXRlIAppbnNpZGUg dmJsYW5rLCBzb21ldGltZXMgd2l0aCAiZnVubnkiIHNpZGUgZWZmZWN0cyB0byBvdGhlciBzdHVm ZiwgZS5nLiwgCmRwbSBvbiBBTUQsIGFzIGkgcmVtZW1iZXIgZnJvbSBzb21lIGxvbmcgZGVidWcg c2Vzc2lvbiB3aXRoIE1pY2hlbCBhbmQgCkFsZXggbGFzdCBzdW1tZXIgd2hlcmUgZHBtIHBsYXll ZCBhIHJvbGUuIFRoZXJlZm9yZSBpdCBzZWVtcyBtb3JlIHNhZmUgCnRvIG1lIHRvIGF2b2lkIGFj dGlvbnMgaW5zaWRlIHZibGFuayB0aGF0IGNvdWxkIGJlIGRvbmUgb3V0c2lkZS4gRS5nLiwgCmlu c3RlYWQgb2YgZG9pbmcgdGhlIGRpc2FibGUgaW5zaWRlIHRoZSB2YmxhbmsgaXJxIG9uZSBjb3Vs ZCBtYXliZSBqdXN0IApzY2hlZHVsZSBhbiBleGFjdCB0aW1lciB0byBkbyB0aGUgZGlzYWJsZSBh IGZldyBtaWxsaXNlY29uZHMgbGF0ZXIgaW4gCnRoZSBtaWRkbGUgb2YgYWN0aXZlIHNjYW5vdXQg dG8gYXZvaWQgdGhlc2UgcG90ZW50aWFsIGlzc3Vlcz8KCi1tYXJpbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=