From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Do not leak VMAs (and PPGTT VMs) of imported flinked objects Date: Mon, 20 Apr 2015 13:53:03 +0100 Message-ID: <5534F6AF.7010303@linux.intel.com> References: <1429532074-30022-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20150420123612.GA17348@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id DB50D6E398 for ; Mon, 20 Apr 2015 05:53:05 -0700 (PDT) In-Reply-To: <20150420123612.GA17348@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzIwLzIwMTUgMDE6MzYgUE0sIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIEFw ciAyMCwgMjAxNSBhdCAwMToxNDozNFBNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4g RnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4KPj4gSWYg YSBjbGllbnQgaW5zdGFudGlhdGVzIGEgVk1BIGFnYWluc3QgYW4gaW1wb3J0ZWQgb2JqZWN0IChm bGluaykgdGhpcyBWTUEKPj4gd2lsbCBub3QgZ2V0IHVuYm91bmQgd2hlbiB0aGUgb2JqZWN0IGlz IGNsb3NlZC4KPj4KPj4gVGhpcyBoYXBwZW5zIGJlY2F1c2UgdGhlIGV4cG9ydGVyIGhvbGRzIGEg cmVmZXJlbmNlIGNvdW50IG9uIHRoZSBvYmplY3QgYW5kCj4+IHdpbGwgYWxzbyBrZWVwIGEgcmVm ZXJlbmNlIHRvIHRoZSBQUEdUVCBWTS4KPj4KPj4gSW4gcmVhbCBsaWZlIHRoaXMgaGFwcGVucyB3 aXRoIHhvcmctZHJpdmVyLWludGVsIGFuZCBmYmNvbiB0YWtlb3Zlci4gTGF0dGVyCj4+IGlzIGNv cGllZCBmcm9tIHZpYSB0aGUgZmxpbmsgbmFtZSBhbmQgd2hlbiBYb3JnIHByb2Nlc3MgZXhpc3Rz IG9uZSBWTUEKPj4gcmVtYWlucyBkYW5nbGluZyB3aXRoIGEgbm93IHVucmVhY2hhYmxlIFZNLgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IFRl c3RjYXNlOiBpZ3QvZ2VtX3BwZ3R0L2ZsaW5rLXZzLWN0eC12bS1sZWFrCj4+IC0tLQo+PiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCAgMSArCj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCB8ICAyICsrCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyB8IDYzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4+ICAg MyBmaWxlcyBjaGFuZ2VkLCA1MyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPj4KPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4+IGluZGV4IGY5NzU0YzMuLjE2YTBiMzQgMTAwNjQ0Cj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+PiBAQCAtMTYzMCw2ICsxNjMwLDcgQEAgc3RhdGljIHN0 cnVjdCBkcm1fZHJpdmVyIGRyaXZlciA9IHsKPj4gICAJLmRlYnVnZnNfaW5pdCA9IGk5MTVfZGVi dWdmc19pbml0LAo+PiAgIAkuZGVidWdmc19jbGVhbnVwID0gaTkxNV9kZWJ1Z2ZzX2NsZWFudXAs Cj4+ICAgI2VuZGlmCj4+ICsJLmdlbV9jbG9zZV9vYmplY3QgPSBpOTE1X2dlbV9jbG9zZV9vYmpl Y3QsCj4+ICAgCS5nZW1fZnJlZV9vYmplY3QgPSBpOTE1X2dlbV9mcmVlX29iamVjdCwKPj4gICAJ LmdlbV92bV9vcHMgPSAmaTkxNV9nZW1fdm1fb3BzLAo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPj4gaW5kZXggNmEyNTI4Yy4uZTgyNzkwYiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oCj4+IEBAIC0yNjM1LDYgKzI2MzUsOCBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq aTkxNV9nZW1fYWxsb2Nfb2JqZWN0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAgCQkJCQkJ ICBzaXplX3Qgc2l6ZSk7Cj4+ICAgdm9pZCBpOTE1X2luaXRfdm0oc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+PiAgIAkJICBzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSk7 Cj4+ICt2b2lkIGk5MTVfZ2VtX2Nsb3NlX29iamVjdChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmdl bV9vYmosCj4+ICsJCQkgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpOwo+PiAgIHZvaWQgaTkxNV9n ZW1fZnJlZV9vYmplY3Qoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmopOwo+PiAgIHZvaWQgaTkx NV9nZW1fdm1hX2Rlc3Ryb3koc3RydWN0IGk5MTVfdm1hICp2bWEpOwo+Pgo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPj4gaW5kZXggZjdiODc2Ni4uYTcyMDE1NCAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jCj4+IEBAIC00NTIzLDYgKzQ1MjMsNTUgQEAgc3RhdGljIGJvb2wgZGlzY2Fy ZF9iYWNraW5nX3N0b3JhZ2Uoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPj4gICAJ cmV0dXJuIGF0b21pY19sb25nX3JlYWQoJm9iai0+YmFzZS5maWxwLT5mX2NvdW50KSA9PSAxOwo+ PiAgIH0KPj4KPj4gK3N0YXRpYyB2b2lkIGk5MTVfZ2VtX3VuYmluZF92bWEoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiArCQkJCXN0cnVjdCBpOTE1X3ZtYSAqdm1hKQo+PiAr ewo+PiArCWlmIChXQVJOX09OKGk5MTVfdm1hX3VuYmluZCh2bWEpID09IC1FUkVTVEFSVFNZUykp IHsKPj4gKwkJYm9vbCB3YXNfaW50ZXJydXB0aWJsZTsKPj4gKwo+PiArCQl3YXNfaW50ZXJydXB0 aWJsZSA9IGRldl9wcml2LT5tbS5pbnRlcnJ1cHRpYmxlOwo+PiArCQlkZXZfcHJpdi0+bW0uaW50 ZXJydXB0aWJsZSA9IGZhbHNlOwo+PiArCj4+ICsJCVdBUk5fT04oaTkxNV92bWFfdW5iaW5kKHZt YSkpOwo+PiArCj4+ICsJCWRldl9wcml2LT5tbS5pbnRlcnJ1cHRpYmxlID0gd2FzX2ludGVycnVw dGlibGU7Cj4+ICsJfQo+PiArfQo+PiArCj4+ICt2b2lkIGk5MTVfZ2VtX2Nsb3NlX29iamVjdChz dHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmdlbV9vYmosCj4+ICsJCQkgICBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUpCj4+ICt7Cj4+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiA9IHRvX2lu dGVsX2JvKGdlbV9vYmopOwo+PiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvYmotPmJhc2Uu ZGV2Owo+PiArCXN0cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdiA9IGZpbGUt PmRyaXZlcl9wcml2Owo+PiArCXN0cnVjdCBpOTE1X3ZtYSAqdm1hLCAqbmV4dDsKPj4gKwlzdHJ1 Y3QgaTkxNV9od19wcGd0dCAqcHBndHQ7Cj4+ICsKPj4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVj dF9tdXRleCk7Cj4+ICsKPj4gKwkvKgo+PiArCSAqIFJlbGVhc2UgYWxsIFZNQXMgYXNzb2NpYXRl ZCB3aXRoIHRoaXMgY2xpZW50J3MgUFBHVFQuCj4+ICsJICoKPj4gKwkgKiBUaGlzIGlzIHRvIGF2 b2lkIHBvdGVudGlhbGx5IHVucmVhY2hhYmxlIFZNQXMgc2luY2UgY29udGV4dHMgY2FuIGhhdmUK Pj4gKwkgKiBzaG9ydGVyIGxpZmV0aW1lIHRoYW4gb2JqZWN0cy4gTWVhbmluZyBpZiBhIGNsaWVu dCBoYXMgYSByZWZlcmVuY2UgdG8KPj4gKwkgKiBhbiBvYmplY3QgKGZsaW5rKSBhbmQgYW4gaW5z dGFudGlhdGVkIFZNQSwgd2hlbiBpdCBleGlzdHMgbmVpdGhlciBWTUEKPj4gKwkgKiB3aWxsIGJl IHVuYm91bmQgKHNpbmNlIG9iamVjdCBmcmVlIHdvbid0IHJ1biksIG5vciB0aGUgUFBHVFQgVk0K Pj4gKwkgKiBmcmVlZCAoc2luY2UgVk1BIGhvbGRzIGEgcmVmZXJlbmNlIHRvIGl0KS4KPj4gKwkg Ki8KPj4gKwlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUodm1hLCBuZXh0LCAmb2JqLT52bWFfbGlz dCwgdm1hX2xpbmspIHsKPj4gKwkJaWYgKGk5MTVfaXNfZ2d0dCh2bWEtPnZtKSkKPj4gKwkJCWNv bnRpbnVlOwo+PiArCj4+ICsJCXBwZ3R0ID0gKHN0cnVjdCBpOTE1X2h3X3BwZ3R0ICopdm1hLT52 bTsKPj4gKwkJaWYgKHBwZ3R0LT5maWxlX3ByaXYgIT0gZmlsZV9wcml2KQo+PiArCQkJY29udGlu dWU7Cj4+ICsKPj4gKwkJaTkxNV9nZW1fdW5iaW5kX3ZtYShkZXYtPmRldl9wcml2YXRlLCB2bWEp Owo+Cj4gTm8gd2UgY2FuJ3QgZG8gdGhpcywgYXMgaXQgbWFrZXMgY2xvc2Ugc3luYyBhbmQgc28g Y2FuIGhhdmUgZGlzYXN0ZXJvdXMKPiBlZmZlY3RzIG9uIHBlcmZvcm1hbmNlICh0aG91Z2ggbWl0 aWdhdGVkIGNoaWVmbHkgYnkgdXNlcnNwYWNlCj4gYWdyZXNzaXZlbHkgY2FjaGluZyBibykgYW5k IGFsc28gdGhlIHVuYmluZCBpcyB2ZXJ5IGxpa2VseSB0byBmYWlsLAo+IHRob3VnaCBhZG1pdHRl ZGx5IHRoZSBmYmNvbiBjb3B5IHNob3VsZCBiZSBiZWZvcmUgWCBzdGFydHMgKGFiKXVzaW5nCj4g c2lnbmFscyAtIGhlbmNlIG5hc3R5IFdBUk5fT04uCj4KPiBQbHVzIGFsc28gd2Fsa2luZyB0aGlz IGxpbmVhciBsaXN0IGlzIHF1aXRlIHBhaW5mdWwgaW4gY2VydGFpbiBhYnVzaXZlCj4gdGVzdHMu IE15IHByZWZlcmVuY2UgZm9yIGZpeGluZyB0aGlzIGJ1ZyB3b3VsZCBiZSB2aWEgdm1hIGFjdGl2 ZQo+IHJlZmVyZW5jZXMgYW5kIGF1dG8tdW5iaW5kaW5nIG9uIHJldGlyZW1lbnQgYWZ0ZXIgYSBj bG9zZS4KCldoeSB0aGlzIGlzIGFueSBkaWZmZXJlbnQgdG9kYXkgd2l0aCBHRU1fQ0xPU0UgaGF2 aW5nIHByZXR0eSBzaW1pbGFyIFZNQSAKdW5iaW5kIGxvb3A/IElzIHRoZSB0eXBpY2FsIChhbmQg aW50ZXJlc3RpbmcpIGNhc2Ugbm90IHRoYXQgR0VNX0NMT1NFIAp3aWxsIHRyaWdnZXIgZ2VtX29i amVjdF9jbG9zZSBhbmQgZ2VtX29iamVjdF9mcmVlIGF0IHRoZSBzYW1lIGludm9jYXRpb24/Cgo+ IEV4cGVjdCBzb21lIGZ1biBwYXRjaGVzIGluIHlvdXIgaW5ib3ggVHZydGtvIDotcAoKT2ssIGp1 c3QgZG9uJ3QgbWFrZSB0aGVtIGRlcGVuZCBvbiBldmVyeXRoaW5nLiA6KQoKUmVnYXJkcywKClR2 cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=