Re: [RFC] drm/i915/skl: Use plane update function from mmio flips

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Intel-gfx@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [RFC] drm/i915/skl: Use plane update function from mmio flips
Date: Tue, 21 Apr 2015 11:01:03 +0100	[thread overview]
Message-ID: <55361FDF.6020009@linux.intel.com> (raw)
In-Reply-To: <20150421095142.GJ17348@nuc-i3427.alporthouse.com>

Hi,

On 04/21/2015 10:51 AM, Chris Wilson wrote:
> On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Avoids duplicating the code.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Sonika Jindal <sonika.jindal@intel.com>
>> Cc: Damien Lespiau <damien.lespiau@intel.com>
>> ---
>> Can we do this?
>
> Sure, but I'd like to see update_primary_plane split into two in that
> case. One to precalcuate the parameters, then the second to apply them
> as we skip the first here (due to doing the setup in process context)
> and want the second to run inside the vblank evasion logic (and the
> unbounded nature of the current update_primary_plane logic scares me).

What part is unbounded? I don't see anything blocking?

As a side note, watermarks seem to be not handled at all in the flip 
path as well...

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx