Re: [PATCH v3] [i-g-t] tests/gem_ppgtt: Check for vm leaks with flink and ppgtt

Chris Wilson
2015-04-23T13:09:39Z

On Thu, Apr 23, 2015 at 02:01:43PM +0100, Ceraolo Spurio, Daniele wrote:
> On 4/23/2015 12:36 PM, Chris Wilson wrote:
> >>+ memset(&execbuf, 0, sizeof(execbuf));
> >>+ execbuf.buffers_ptr = (uintptr_t)exec;
> >>+ execbuf.buffer_count = 1;
> >>+ execbuf.batch_len = sizeof(batch_data);
> >>+ execbuf.flags = 0;
> >These two can also happily disappear.
>
> Ok for the execbuf.flags and for the other fixes, but why remove
> also execbuf.batch_len?

Then we get flagged as a no-op batch. It's just a piece of
sleight-of-hand.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre