From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v3 03/15] drm/i915: Unified firmware loading mechanism Date: Thu, 23 Apr 2015 18:12:18 +0100 Message-ID: <553927F2.6060906@intel.com> References: <1429305680-4990-1-git-send-email-yu.dai@intel.com> <1429305680-4990-4-git-send-email-yu.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4AC8F6E7C3 for ; Thu, 23 Apr 2015 10:12:20 -0700 (PDT) In-Reply-To: <1429305680-4990-4-git-send-email-yu.dai@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: yu.dai@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTcvMDQvMTUgMjI6MjEsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogRGF2ZSBH b3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiAKPiBGYWN0b3Igb3V0IHRoZSBjb21t b24gY29kZSBvZiBsb2FkaW5nIGZpcm13YXJlIGludG8gYSBuZXcgZmlsZSwKPiBsZWF2aW5nIG9u bHkgdGhlIHVDLXNwZWNpZmljIHBhcnRzIGluIHRoZSBHdUMgbG9hZGVycy4KPiAKPiBJc3N1ZTog VklaLTQ4ODQKPiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZSAgICAgICAgICB8ICAgMyArCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2xvYWRlci5jIHwgMjQ0ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19sb2Fk ZXIuaCB8ICA3OCArKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDMyNSBpbnNlcnRpb25z KCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19s b2FkZXIuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf dWNfbG9hZGVyLmgKCkluIGdlbmVyYWwsIHllczsgYnV0IEkgbm90aWNlZCB0aGF0IHRoZSBmaXJt d2FyZSBpbWFnZSBibG9iIGlzbid0CnJlbGVhc2VkIGluIHRoZSAnc3VjY2VzcycgcGF0aCwgd2hp Y2ggbWVhbnMgd2UncmUga2VlcGluZyBib3RoIHRoZSByYXcKaW1hZ2UgYW5kIHRoZSBHRU0gY29w eSBhcm91bmQgZm9yZXZlci4gSXQgd291bGQgYmUgYmV0dGVyIHRvIHJlbGVhc2UgdGhlCnJhdyBp bWFnZSBhbmQgb25seSBrZWVwIHRoZSBHRU0gb2JqZWN0ICh3aGljaCBpcyBzd2FwcGFibGUpLgoK VW5mb3J0dW5hdGVseSwgdGhhdCB3b3VsZG4ndCB3b3JrIHdpdGggdGhlIGN1cnJlbnQgdmVyc2lv biBvZiB0aGUgR3VDCmxvYWRlciBiZWNhdXNlIG9mIHRoZSB3YXkgaXQgbmVlZHMgdGhlIGRhdGEg cmVvcmdhbmlzZWQgZm9yIERNQSwgYW5kCnRoZXJlZm9yZSBhY2Nlc3NlcyB0aGUgYmxvYiBvbiBl YWNoIHJlbG9hZCA6KAoKU28gSSB0aGluayB0aGUgd2F5IHRvIGdvIGhlcmUgaXMgdG8gdXBncmFk ZSB0aGUgdWNfZndfY2hlY2soKSBjYWxsYmFjawp0byBhbGxvdyBpdCB0byBvdmVycmlkZSB0aGUg d2F5IHRoZSBkYXRhIGlzIHNhdmVkLCBpZiB0aGUgZGVmYXVsdCAoR0VNCm9iamVjdCBpcyBqdXN0 IGEgY29weSBvZiB0aGUgZmlybXdhcmUgaW1hZ2UpIGRvZXNuJ3QgbWF0Y2ggdGhlIHNwZWNpZmlj CnVDIHJlcXVpcmVtZW50cy4KClRoZSBHdUMgY2FsbGJhY2sgY2FuIHRoZW4gc2h1ZmZsZSB0aGUg ZGF0YSBkdXJpbmcgdGhpcyBvbmUtb2ZmIGNvcHksIGFuZAp0aGUgc3Vic2VxdWVudCBETUEgdHJh bnNmZXIgd2lsbCBiZSBtdWNoIG1vcmUgc3RyYWlnaHRmb3J3YXJkLgoKSSdsbCBwb3N0IGEgbmV3 IHN1Z2dlc3Rpb24gZm9yIHRoaXMgZmlsZSBzb29uLCBwcm9iYWJseSB0b21vcnJvdyAuLi4KCi5E YXZlLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfbG9hZGVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19sb2FkZXIuYwoKPiArc3RhdGljIHZv aWQgdWNfZndfZmluaXNoKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF91Y19m dyAqdWNfZncpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSBOVUxM Owo+ICsJY29uc3Qgc3RydWN0IGZpcm13YXJlICpmdzsKPiArCj4gKwlEUk1fREVCVUdfRFJJVkVS KCJiZWZvcmUgd2FpdGluZzogJXMgZncgZmV0Y2ggc3RhdHVzICVkLCBmdyAlcFxuIiwKPiArCQl1 Y19mdy0+dWNfbmFtZSwgdWNfZnctPnVjX2Z3X2ZldGNoX3N0YXR1cywgdWNfZnctPnVjX2Z3X2Js b2IpOwo+ICsKPiArCVdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgmZGV2LT5zdHJ1Y3RfbXV0ZXgp KTsKPiArCVdBUk5fT04odWNfZnctPnVjX2Z3X2ZldGNoX3N0YXR1cyAhPSBJTlRFTF9VQ19GSVJN V0FSRV9QRU5ESU5HKTsKPiArCj4gKwl3YWl0X2Zvcl9jb21wbGV0aW9uKCZ1Y19mdy0+dWNfZndf ZmV0Y2hlZCk7Cj4gKwo+ICsJRFJNX0RFQlVHX0RSSVZFUigiYWZ0ZXIgd2FpdGluZzogJXMgZncg ZmV0Y2ggc3RhdHVzICVkLCBmdyAlcFxuIiwKPiArCQl1Y19mdy0+dWNfbmFtZSwgdWNfZnctPnVj X2Z3X2ZldGNoX3N0YXR1cywgdWNfZnctPnVjX2Z3X2Jsb2IpOwo+ICsKPiArCWZ3ID0gdWNfZnct PnVjX2Z3X2Jsb2I7Cj4gKwlpZiAoIWZ3KSB7Cj4gKwkJLyogbm8gZmlybXdhcmUgZm91bmQ7IHRy eSBhZ2FpbiBpbiBjYXNlIEZTIHdhcyBub3QgbW91bnRlZCAqLwo+ICsJCURSTV9ERUJVR19EUklW RVIoInJldHJ5IGZldGNoaW5nICVzIGZ3IGZyb20gPCVzPlxuIiwKPiArCQkJdWNfZnctPnVjX25h bWUsIHVjX2Z3LT51Y19md19wYXRoKTsKPiArCQlpZiAocmVxdWVzdF9maXJtd2FyZSgmZncsIHVj X2Z3LT51Y19md19wYXRoLCAmZGV2LT5wZGV2LT5kZXYpKQo+ICsJCQlnb3RvIGZhaWw7Cj4gKwkJ RFJNX0RFQlVHX0RSSVZFUigiZmV0Y2ggJXMgZncgZnJvbSA8JXM+IHN1Y2NlZWRlZCwgZncgJXBc biIsCj4gKwkJCXVjX2Z3LT51Y19uYW1lLCB1Y19mdy0+dWNfZndfcGF0aCwgZncpOwo+ICsJCXVj X2Z3LT51Y19md19ibG9iID0gZnc7Cj4gKwl9Cj4gKwo+ICsJb2JqID0gaTkxNV9nZW1fYWxsb2Nf b2JqZWN0KGRldiwgcm91bmRfdXAoZnctPnNpemUsIFBBR0VfU0laRSkpOwo+ICsJaWYgKCFvYmop Cj4gKwkJZ290byBmYWlsOwo+ICsKPiArCWlmIChpOTE1X2dlbV9vYmplY3Rfd3JpdGUob2JqLCBm dy0+ZGF0YSwgZnctPnNpemUpKQo+ICsJCWdvdG8gZmFpbDsKPiArCj4gKwlEUk1fREVCVUdfRFJJ VkVSKCIlcyBmdyBmZXRjaCBzdGF0dXMgU1VDQ0VTU1xuIiwgdWNfZnctPnVjX25hbWUpOwo+ICsJ dWNfZnctPnVjX2Z3X29iaiA9IG9iajsKPiArCXVjX2Z3LT51Y19md19zaXplID0gZnctPnNpemU7 Cj4gKwl1Y19mdy0+dWNfZndfZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VT UzsKCldlIG91Z2h0IHRvIGJlIGFibGUgdG8gcmVsZWFzZV9maXJtd2FyZSgpIGhlcmUuCgo+ICsJ cmV0dXJuOwo+ICsKPiArZmFpbDoKPiArCURSTV9ERUJVR19EUklWRVIoIiVzIGZ3IGZldGNoIHN0 YXR1cyBGQUlMOyBmdyAlcCwgb2JqICVwXG4iLAo+ICsJCXVjX2Z3LT51Y19uYW1lLCBmdywgb2Jq KTsKPiArCURSTV9FUlJPUigiRmFpbGVkIHRvIGZldGNoICVzIGZpcm13YXJlIGZyb20gPCVzPlxu IiwKPiArCQkgIHVjX2Z3LT51Y19uYW1lLCB1Y19mdy0+dWNfZndfcGF0aCk7Cj4gKwo+ICsJaWYg KG9iaikKPiArCQlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiArCj4g Kwl1Y19mdy0+dWNfZndfZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfRkFJTDsKPiAr CXVjX2Z3LT51Y19md19ibG9iID0gTlVMTDsKPiArCXJlbGVhc2VfZmlybXdhcmUoZncpOwkJLyog T0sgZXZlbiBpZiBmdyBpcyBOVUxMICovCj4gK30KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==