From: Dave Gordon <david.s.gordon@intel.com>
To: Yunlian Jiang <yunlian@chromium.org>, intel-gfx@lists.freedesktop.org
Subject: Re: PATCH i-g-t Fix a clang compile error.
Date: Mon, 27 Apr 2015 19:48:09 +0100 [thread overview]
Message-ID: <553E8469.9040806@intel.com> (raw)
In-Reply-To: <CAMsPy2vfqX9FZiAx0JWUOE_AkK+W74rTCBA2ZDLsPcCuy9zWNw@mail.gmail.com>
On 23/04/15 17:54, Yunlian Jiang wrote:
> The bug entry is at
> https://code.google.com/p/chromium/issues/detail?id=476001
>
> The patch below makes clang happy.
>
> debugger/eudb.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/debugger/eudb.c b/debugger/eudb.c
> index 0e810db..7188a4f 100644
> --- a/debugger/eudb.c
> +++ b/debugger/eudb.c
> @@ -207,15 +207,11 @@ wait_for_attn(int timeout, int *out_bits) {
> #define eu_tid(bit) eu_info->debuggees[bit].tid
> static struct eu_state *
> find_eu_shmem(int bit, volatile uint8_t *buf) {
> - struct per_thread_data {
> - uint8_t ____[dh.per_thread_scratch];
> - }__attribute__((packed)) *data;
> struct eu_state *eu;
> int mem_tid, mem_euid, i;
>
> - data = (struct per_thread_data *)buf;
> for(i = 0; i < eu_info->num_threads; i++) {
> - eu = (struct eu_state *)&data[i];
> + eu = (struct eu_state *)&buff[i*dh.per_thread_scratch];
"buff" here vs. "buf" elsewhere - is that a typo?
.Dave.
> mem_tid = eu->sr0 & 0x7;
> mem_euid = (eu->sr0 >> 8) & 0xf;
> if (mem_tid == eu_tid(bit) && mem_euid == eu_id(bit))
>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-27 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 16:54 PATCH i-g-t Fix a clang compile error Yunlian Jiang
2015-04-27 13:36 ` Thomas Wood
2015-04-27 16:20 ` Yunlian Jiang
2015-04-30 14:15 ` Dave Gordon
2015-05-01 22:03 ` Yunlian Jiang
2015-04-27 18:48 ` Dave Gordon [this message]
2015-04-27 19:53 ` Yunlian Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E8469.9040806@intel.com \
--to=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yunlian@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox