From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 01/16] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level Date: Wed, 29 Apr 2015 15:50:13 +0100 Message-ID: <5540EFA5.1030002@linux.intel.com> References: <1430138487-22541-1-git-send-email-chris@chris-wilson.co.uk> <1430138487-22541-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 4483D6E26F for ; Wed, 29 Apr 2015 07:50:28 -0700 (PDT) In-Reply-To: <1430138487-22541-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzI3LzIwMTUgMDE6NDEgUE0sIENocmlzIFdpbHNvbiB3cm90ZToKPiBTaW5jZSB0aGUg cmVtb3ZlIG9mIHRoZSBwaW4taW9jdGwsIHdlIG9ubHkgY2FyZSBhYm91dCBub3QgY2hhbmdpbmcg dGhlCj4gY2FjaGUgbGV2ZWwgb24gYnVmZmVycyBwaW5uZWQgdG8gdGhlIGhhcmR3YXJlIGFzIGlu ZGljYXRlZCBieQo+IG9iai0+cGluX2Rpc3BsYXkuIFNvIHdlIGNhbiBzYWZlbHkgcmVwbGFjZSBp OTE1X2dlbV9vYmplY3RfaXNfcGlubmVkKCkKPiBoZXJlIHdpdGggYSBwbGFpbiBvYmotPnBpbl9k aXNwbGF5IGNoZWNrLiBEdXJpbmcgcmViaW5kaW5nLCB3ZSB3aWxsIGNoZWNrCj4gc2FuaXR5IGNo ZWNrcyBpbiBjYXNlIHZtYS0+cGluX2NvdW50IGlzIGVycm9uZW91c2x5IHNldC4KPgo+IEF0IHRo ZSBzYW1lIHRpbWUsIHdlIGNhbiBtaWNyby1vcHRpbWlzZSBHVFQgbW1hcCgpIGJlaGF2aW91ciBz aW5jZSB3ZQo+IG9ubHkgbmVlZCB0byByZWxpbnF1aXNoIHRoZSBtbWFwcyBiZWZvcmUgU2FuZHli cmlkZ2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAzMyAr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyMSBp bnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ IGluZGV4IGYwYTZkMDNlOWJhNS4uYWZkYjYwNGU0MDA1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gQEAgLTM3NjgsMzEgKzM3NjgsMzQgQEAgaW50IGk5MTVfZ2VtX29iamVjdF9zZXRf Y2FjaGVfbGV2ZWwoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIHsKPiAgIAlz dHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gb2JqLT5iYXNlLmRldjsKPiAgIAlzdHJ1Y3QgaTkxNV92 bWEgKnZtYSwgKm5leHQ7Cj4gKwlib29sIGJvdW5kID0gZmFsc2U7Cj4gICAJaW50IHJldDsKPgo+ ICAgCWlmIChvYmotPmNhY2hlX2xldmVsID09IGNhY2hlX2xldmVsKQo+ICAgCQlyZXR1cm4gMDsK Pgo+IC0JaWYgKGk5MTVfZ2VtX29ial9pc19waW5uZWQob2JqKSkgewo+ICsJaWYgKG9iai0+cGlu X2Rpc3BsYXkpIHsKPiAgIAkJRFJNX0RFQlVHKCJjYW4gbm90IGNoYW5nZSB0aGUgY2FjaGUgbGV2 ZWwgb2YgcGlubmVkIG9iamVjdHNcbiIpOwo+ICAgCQlyZXR1cm4gLUVCVVNZOwo+ICAgCX0KPgo+ ICAgCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2bWEsIG5leHQsICZvYmotPnZtYV9saXN0LCB2 bWFfbGluaykgewo+ICsJCWlmICghZHJtX21tX25vZGVfYWxsb2NhdGVkKCZ2bWEtPm5vZGUpKQo+ ICsJCQljb250aW51ZTsKPiArCgpBbm90aGVyIG1pY3JvLW9wdGltaXNhdGlvbj8KClNpZGUgbm90 ZSAtIHRoaXMgd2FzIHB1enpsaW5nIGFuZCB0aGVuIEkgcmVhbGl6ZWQgCmk5MTVfZ2VtX3ZhbGlk X2d0dF9zcGFjZSBzYXlzIHRydWUgd2hlbiBub2RlIGlzIG5vdCBhbGxvY2F0ZWQuIEl0IHNlZW1z IAp0byBiZSBvbmx5IGNvbmNlcm5lZCBieSBub2RlIGNvbG91cmluZyAtIHNvIGlzIHRoYXQgb25l IGJhZGx5IG5hbWUgCmZ1bmN0aW9uIG9yIEkgYW0gbWlzc2luZyBzb21ldGhpbmc/Cgo+ICAgCQlp ZiAoIWk5MTVfZ2VtX3ZhbGlkX2d0dF9zcGFjZSh2bWEsIGNhY2hlX2xldmVsKSkgewo+ICAgCQkJ cmV0ID0gaTkxNV92bWFfdW5iaW5kKHZtYSk7Cj4gICAJCQlpZiAocmV0KQo+ICAgCQkJCXJldHVy biByZXQ7Cj4gLQkJfQo+ICsJCX0gZWxzZQo+ICsJCQlib3VuZCA9IHRydWU7Cj4gICAJfQo+Cj4g LQlpZiAoaTkxNV9nZW1fb2JqX2JvdW5kX2FueShvYmopKSB7Cj4gKwlpZiAoYm91bmQpIHsKPiAg IAkJcmV0ID0gaTkxNV9nZW1fb2JqZWN0X2ZpbmlzaF9ncHUob2JqKTsKPiAgIAkJaWYgKHJldCkK PiAgIAkJCXJldHVybiByZXQ7Cj4KPiAtCQlpOTE1X2dlbV9vYmplY3RfZmluaXNoX2d0dChvYmop Owo+IC0KPiAgIAkJLyogQmVmb3JlIFNhbmR5QnJpZGdlLCB5b3UgY291bGQgbm90IHVzZSB0aWxp bmcgb3IgZmVuY2UKPiAgIAkJICogcmVnaXN0ZXJzIHdpdGggc25vb3BlZCBtZW1vcnksIHNvIHJl bGlucXVpc2ggYW55IGZlbmNlcwo+ICAgCQkgKiBjdXJyZW50bHkgcG9pbnRpbmcgdG8gb3VyIHJl Z2lvbiBpbiB0aGUgYXBlcnR1cmUuCj4gQEAgLTM4MDEsMTUgKzM4MDQsMjEgQEAgaW50IGk5MTVf Z2VtX29iamVjdF9zZXRfY2FjaGVfbGV2ZWwoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9i aiwKPiAgIAkJCXJldCA9IGk5MTVfZ2VtX29iamVjdF9wdXRfZmVuY2Uob2JqKTsKPiAgIAkJCWlm IChyZXQpCj4gICAJCQkJcmV0dXJuIHJldDsKPiArCj4gKwkJCWk5MTVfZ2VtX3JlbGVhc2VfbW1h cChvYmopOwo+ICAgCQl9CgpJZiBvbmx5IDwgZ2VuNiB3ZSBuZWVkIHRvIGRyb3AgdGhlIG1tYXAs IHdoYXQgaGFwcGVucyB3aXRoIHRoZSBkb21haW4gCnRyYWNraW5nIC0gd2hvIHJlbW92ZXMgdGhl IEdUVCBiaXQgZnJvbSB0aGVyZSBub3c/Cgo+Cj4gLQkJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEs ICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykKPiAtCQkJaWYgKGRybV9tbV9ub2RlX2FsbG9jYXRl ZCgmdm1hLT5ub2RlKSkgewo+IC0JCQkJcmV0ID0gaTkxNV92bWFfYmluZCh2bWEsIGNhY2hlX2xl dmVsLAo+IC0JCQkJCQkgICAgUElOX1VQREFURSk7Cj4gLQkJCQlpZiAocmV0KQo+IC0JCQkJCXJl dHVybiByZXQ7Cj4gLQkJCX0KPiArCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZtYSwgJm9iai0+dm1h X2xpc3QsIHZtYV9saW5rKSB7Cj4gKwkJCWlmICghZHJtX21tX25vZGVfYWxsb2NhdGVkKCZ2bWEt Pm5vZGUpKQo+ICsJCQkJY29udGludWU7Cj4gKwo+ICsJCQlpZiAodm1hLT5waW5fY291bnQpCj4g KwkJCQlyZXR1cm4gLUVCVVNZOwoKUHJlc2VydmUgRFJNX0RFQlVHIGFzIGl0IHdhcyBiZWZvcmU/ CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==