From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories Date: Thu, 30 Apr 2015 15:53:29 +0100 Message-ID: <554241E9.1020400@intel.com> References: <20150430104745.GA25329@mwanda> <1430402374-16855-1-git-send-email-michel.thierry@intel.com> <20150430142211.GZ18908@intel.com> <55423D51.5060205@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 26A1B6E03F for ; Thu, 30 Apr 2015 07:53:37 -0700 (PDT) In-Reply-To: <55423D51.5060205@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMzAvMDQvMTUgMTU6MzMsIE1pY2hlbCBUaGllcnJ5IHdyb3RlOgo+IE9uIDQvMzAvMjAxNSAz OjIyIFBNLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4+IE9uIFRodSwgQXByIDMwLCAyMDE1IGF0 IDAyOjU5OjM0UE0gKzAxMDAsIE1pY2hlbCBUaGllcnJ5IHdyb3RlOgo+Pj4gVGhlIHBhdGNoIDY5 ODc2YmVkN2UwMDhmNWZlMDE1MzhhMmQ0N2MwOWYyODYyMTI5ZDA6ICJkcm0vaTkxNS9nZW44Ogo+ Pj4gcGFnZSBkaXJlY3RvcmllcyByZXdvcmsgYWxsb2NhdGlvbiIgYWRkZWQgYW4gb3ZlcmZsb3cg d2FybmluZywgYnV0IHRoZQo+Pj4gbWFzayBoYWQgYW4gZXh0cmEgMC4gVXNlIHR5cG8tcHJvbmUg b3B0aW9uIHN1Z2dlc3RlZCBieSBEYXZlIGluc3RlYWQuCj4+Pgo+Pj4gVGhpcyBjaGVjayB3aWxs IGJlIHVubmVjZXNzYXJ5IGFmdGVyIGdlbjhfYWxsb2NfdmFfcmFuZ2UgaGFuZGxlcyBtb3JlCj4+ PiB0aGFuIDQgUERQcyAoNDhiIGFkZHJlc3NpbmcpLgo+Pj4KPj4+IFJlcG9ydGVkLWJ5OiBEYW4g Q2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4+PiBDYzogRGF2ZSBHb3Jkb24g PGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBUaGll cnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgfCA0ICsrLS0KPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZ3R0LmMKPj4+IGluZGV4IDZmYWU2YmQuLjZkODk0ZmMgMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPj4+IEBAIC03NTYsOCArNzU2LDggQEAgc3RhdGlj IGludAo+Pj4gZ2VuOF9wcGd0dF9hbGxvY19wYWdlX2RpcmVjdG9yaWVzKHN0cnVjdCBpOTE1X2h3 X3BwZ3R0ICpwcGd0dCwKPj4+Cj4+PiAgICAgICBXQVJOX09OKCFiaXRtYXBfZW1wdHkobmV3X3Bk cywgR0VOOF9MRUdBQ1lfUERQRVMpKTsKPj4+Cj4+PiAtICAgIC8qIEZJWE1FOiBQUEdUVCBjb250 YWluZXJfb2Ygd29uJ3Qgd29yayBmb3IgNjRiICovCj4+PiAtICAgIFdBUk5fT04oKHN0YXJ0ICsg bGVuZ3RoKSA+IDB4ODAwMDAwMDAwVUxMKTsKPj4+ICsgICAgLyogRklYTUU6IHVwcGVyIGJvdW5k IG11c3Qgbm90IG92ZXJmbG93IDMxIGJpdHMgICovCj4+PiArICAgIFdBUk5fT04oKHN0YXJ0ICsg bGVuZ3RoKSAmICh+MFVMTCA8PCAzMSkpOwo+Pgo+PiBXaHkgaXMgaXQgMzEgYW5kIG5vdCAzMj8K PiAKPiBSaWdodCwgdGhlIGNoZWNrIHJlYWxseSBzaG91bGQgYmUgKHN0YXJ0ICsgbGVuZ3RoKSA+ PSAweDEwMDAwMDAwMFVMTC4KClNvbWV0aGluZyB3aXRoICczMicgaW4gaXQgbWlnaHQgYmUgbW9y ZSBvYnZpb3VzIGFuZCBzYXZlIGFueW9uZSBoYXZpbmcKdG8gY291bnQgdGhlIHplcm9lcyAuLi4g YW5kIGEgY29tbWVudCB0aGF0IGFsc28gbWVudGlvbmVkIHRoZSBsaW1pdDoKCgkvKiBGSVhNRTog Zm9yIG5vdywgdXBwZXIgYm91bmQgbXVzdCBmaXQgaW4gMzIgYml0cyAgKi8KCglXQVJOX09OKChz dGFydCArIGxlbmd0aCkgPj0gKDFVTEwgPDwgMzIpKQoJV0FSTl9PTigoc3RhcnQgKyBsZW5ndGgp ICYgKH4wVUxMIDw8IDMyKSkKCVdBUk5fT04oKHN0YXJ0ICsgbGVuZ3RoKSA+PiAzMikgIT0gMCkK Ci5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=