From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 5/5] drm/i915: Use partial view in mmap fault handler Date: Thu, 30 Apr 2015 15:54:51 +0100 Message-ID: <5542423B.1060909@linux.intel.com> References: <1430392887.1189.10.camel@jlahtine-mobl1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id E15026E839 for ; Thu, 30 Apr 2015 07:55:02 -0700 (PDT) In-Reply-To: <1430392887.1189.10.camel@jlahtine-mobl1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , intel-gfx List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzMwLzIwMTUgMTI6MjEgUE0sIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKPgo+IFVzZSBw YXJ0aWFsIHZpZXcgZm9yIGh1Z2UgQk9zIChiaWdnZXIgdGhhbiB0aGUgbWFwcGFibGUgYXBlcnR1 cmUpCj4gaW4gZmF1bHQgaGFuZGxlciBzbyB0aGF0IHRoZXkgY2FuIGJlIGFjY2Vzc2VkIHdpdGhv dXQgdHJ5aW5nIHRvIG1ha2UKPiByb29tIGZvciB0aGVtIGJ5IGV2aWN0aW5nIG90aGVyIG9iamVj dHMuCj4KPiB2MjoKPiAtIE9ubHkgdXNlIHBhcnRpYWwgdmlld3MgaW4gdGhlIGNhc2Ugd2hlcmUg ZWFybHkgcmVqZWN0aW9uIHdhcwo+ICAgIHByZXZpb3VzbHkgZG9uZS4KPiAtIEFjY291bnQgdmFy aWFibGUgdHlwZSBjaGFuZ2VzIGZyb20gcHJldmlvdXMgcmVyb2xsLgo+Cj4gQ2M6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IFNpZ25lZC1vZmYtYnk6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCA2OSArKysrKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDIz IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggYTAyMDgzNi4u MmYzZmEwYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0xNjM1LDYgKzE2MzUs NyBAQCBpbnQgaTkxNV9nZW1fZmF1bHQoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVj dCB2bV9mYXVsdCAqdm1mKQo+ICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSB0 b19pbnRlbF9ibyh2bWEtPnZtX3ByaXZhdGVfZGF0YSk7Cj4gICAJc3RydWN0IGRybV9kZXZpY2Ug KmRldiA9IG9iai0+YmFzZS5kZXY7Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBpOTE1X2dndHRfdmlldyB2aWV3ID0g aTkxNV9nZ3R0X3ZpZXdfbm9ybWFsOwo+ICAgCXBnb2ZmX3QgcGFnZV9vZmZzZXQ7Cj4gICAJdW5z aWduZWQgbG9uZyBwZm47Cj4gICAJaW50IHJldCA9IDA7Cj4gQEAgLTE2NjcsOCArMTY2OCwyMSBA QCBpbnQgaTkxNV9nZW1fZmF1bHQoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCB2 bV9mYXVsdCAqdm1mKQo+ICAgCQlnb3RvIHVubG9jazsKPiAgIAl9Cj4KPiAtCS8qIE5vdyBiaW5k IGl0IGludG8gdGhlIEdUVCBpZiBuZWVkZWQgKi8KPiAtCXJldCA9IGk5MTVfZ2VtX29ial9nZ3R0 X3BpbihvYmosIDAsIFBJTl9NQVBQQUJMRSk7Cj4gKwkvKiBVc2UgYSBwYXJ0aWFsIHZpZXcgaWYg dGhlIG9iamVjdCBpcyBiaWdnZXIgdGhhbiB0aGUgYXBlcnR1cmUuICovCj4gKwlpZiAob2JqLT5i YXNlLnNpemUgPj0gZGV2X3ByaXYtPmd0dC5tYXBwYWJsZV9lbmQpIHsKPiArCQlzdGF0aWMgY29u c3QgdW5zaWduZWQgaW50IGNodW5rX3NpemUgPSAyNTY7IC8vIDEgTWlCCj4gKwkJbWVtc2V0KCZ2 aWV3LCAwLCBzaXplb2YodmlldykpOwo+ICsJCXZpZXcudHlwZSA9IEk5MTVfR0dUVF9WSUVXX1BB UlRJQUw7Cj4gKwkJdmlldy5wYXJhbXMucGFydGlhbC5vZmZzZXQgPSByb3VuZGRvd24ocGFnZV9v ZmZzZXQsIGNodW5rX3NpemUpOwo+ICsJCXZpZXcucGFyYW1zLnBhcnRpYWwuc2l6ZSA9Cj4gKwkJ CW1pbl90KHVuc2lnbmVkIGludCwKPiArCQkJICAgICAgY2h1bmtfc2l6ZSwKPiArCQkJICAgICAg KHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCkvUEFHRV9TSVpFIC0KPiArCQkJICAgICAgdmll dy5wYXJhbXMucGFydGlhbC5vZmZzZXQpOwo+ICsJfQo+ICsKPiArCS8qIE5vdyBwaW4gaXQgaW50 byB0aGUgR1RUIGlmIG5lZWRlZCAqLwo+ICsJcmV0ID0gaTkxNV9nZW1fb2JqZWN0X2dndHRfcGlu KG9iaiwgJnZpZXcsIDAsIFBJTl9NQVBQQUJMRSk7Cj4gICAJaWYgKHJldCkKPiAgIAkJZ290byB1 bmxvY2s7Cj4KPiBAQCAtMTY4MSwzMCArMTY5NSw0NCBAQCBpbnQgaTkxNV9nZW1fZmF1bHQoc3Ry dWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+ICAgCQlnb3Rv IHVucGluOwo+Cj4gICAJLyogRmluYWxseSwgcmVtYXAgaXQgdXNpbmcgdGhlIG5ldyBHVFQgb2Zm c2V0ICovCj4gLQlwZm4gPSBkZXZfcHJpdi0+Z3R0Lm1hcHBhYmxlX2Jhc2UgKyBpOTE1X2dlbV9v YmpfZ2d0dF9vZmZzZXQob2JqKTsKPiArCXBmbiA9IGRldl9wcml2LT5ndHQubWFwcGFibGVfYmFz ZSArCj4gKwkJaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0X3ZpZXcob2JqLCAmdmlldyk7Cj4gICAJ cGZuID4+PSBQQUdFX1NISUZUOwo+Cj4gLQlpZiAoIW9iai0+ZmF1bHRfbWFwcGFibGUpIHsKPiAt CQl1bnNpZ25lZCBsb25nIHNpemUgPSBtaW5fdCh1bnNpZ25lZCBsb25nLAo+IC0JCQkJCSAgIHZt YS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCwKPiAtCQkJCQkgICBvYmotPmJhc2Uuc2l6ZSk7Cj4g LQkJaW50IGk7Cj4gKwlpZiAodW5saWtlbHkodmlldy50eXBlID09IEk5MTVfR0dUVF9WSUVXX1BB UlRJQUwpKSB7Cj4gKwkJdW5zaWduZWQgbG9uZyBiYXNlID0gdm1hLT52bV9zdGFydCArCj4gKwkJ CSh2aWV3LnBhcmFtcy5wYXJ0aWFsLm9mZnNldCA8PCBQQUdFX1NISUZUKTsKPiArCQl1bnNpZ25l ZCBpbnQgaTsKPgo+IC0JCWZvciAoaSA9IDA7IGkgPCBzaXplID4+IFBBR0VfU0hJRlQ7IGkrKykg ewo+IC0JCQlyZXQgPSB2bV9pbnNlcnRfcGZuKHZtYSwKPiAtCQkJCQkgICAgKHVuc2lnbmVkIGxv bmcpdm1hLT52bV9zdGFydCArIGkgKiBQQUdFX1NJWkUsCj4gLQkJCQkJICAgIHBmbiArIGkpOwo+ ICsJCWZvciAoaSA9IDA7IGkgPCB2aWV3LnBhcmFtcy5wYXJ0aWFsLnNpemU7IGkrKykgewo+ICsJ CQlyZXQgPSB2bV9pbnNlcnRfcGZuKHZtYSwgYmFzZSArIGkgKiBQQUdFX1NJWkUsIHBmbiArIGkp Owo+ICAgCQkJaWYgKHJldCkKPiAgIAkJCQlicmVhazsKPiAgIAkJfQo+IC0KPiAgIAkJb2JqLT5m YXVsdF9tYXBwYWJsZSA9IHRydWU7Cj4gLQl9IGVsc2UKPiAtCQlyZXQgPSB2bV9pbnNlcnRfcGZu KHZtYSwKPiAtCQkJCSAgICAodW5zaWduZWQgbG9uZyl2bWYtPnZpcnR1YWxfYWRkcmVzcywKPiAt CQkJCSAgICBwZm4gKyBwYWdlX29mZnNldCk7CgpJZiBJIHJlYWQgdGhlIGRpZmYgY29ycmVjdGx5 IHlvdSBkb24ndCBoYXZlIGVxdWl2YWxlbnQgaGFuZGxpbmcgKGFzIHRoZSAKbm9ybWFsIHZpZXcp IGZvciB3aGVuIHRoZSBjYXNlIHdoZW4gdGhlIHByZS1mYXVsdCBmYWlscyBzb21ld2hlcmUgaW4g dGhlIAptaWRkbGU/CgpUaGF0IG1lYW5zIGlmIHRoYXQgaGFwcGVucyB5b3UnbGwgY2FsbCB2bV9p bnNlcnRfcGZuIG9uIHRoZSB3aG9sZSByYW5nZSAKYWdhaW4gLSBpcyB0aGF0IE9LPwoKUmVnYXJk cywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=