From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH] drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories Date: Thu, 30 Apr 2015 15:56:34 +0100 Message-ID: <554242A2.5050006@intel.com> References: <20150430104745.GA25329@mwanda> <1430402374-16855-1-git-send-email-michel.thierry@intel.com> <20150430142211.GZ18908@intel.com> <55423D51.5060205@intel.com> <554241E9.1020400@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 91C556E839 for ; Thu, 30 Apr 2015 07:56:36 -0700 (PDT) In-Reply-To: <554241E9.1020400@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gNC8zMC8yMDE1IDM6NTMgUE0sIERhdmUgR29yZG9uIHdyb3RlOgo+IE9uIDMwLzA0LzE1IDE1 OjMzLCBNaWNoZWwgVGhpZXJyeSB3cm90ZToKPj4gT24gNC8zMC8yMDE1IDM6MjIgUE0sIFZpbGxl IFN5cmrDpGzDpCB3cm90ZToKPj4+IE9uIFRodSwgQXByIDMwLCAyMDE1IGF0IDAyOjU5OjM0UE0g KzAxMDAsIE1pY2hlbCBUaGllcnJ5IHdyb3RlOgo+Pj4+IFRoZSBwYXRjaCA2OTg3NmJlZDdlMDA4 ZjVmZTAxNTM4YTJkNDdjMDlmMjg2MjEyOWQwOiAiZHJtL2k5MTUvZ2VuODoKPj4+PiBwYWdlIGRp cmVjdG9yaWVzIHJld29yayBhbGxvY2F0aW9uIiBhZGRlZCBhbiBvdmVyZmxvdyB3YXJuaW5nLCBi dXQgdGhlCj4+Pj4gbWFzayBoYWQgYW4gZXh0cmEgMC4gVXNlIHR5cG8tcHJvbmUgb3B0aW9uIHN1 Z2dlc3RlZCBieSBEYXZlIGluc3RlYWQuCj4+Pj4KPj4+PiBUaGlzIGNoZWNrIHdpbGwgYmUgdW5u ZWNlc3NhcnkgYWZ0ZXIgZ2VuOF9hbGxvY192YV9yYW5nZSBoYW5kbGVzIG1vcmUKPj4+PiB0aGFu IDQgUERQcyAoNDhiIGFkZHJlc3NpbmcpLgo+Pj4+Cj4+Pj4gUmVwb3J0ZWQtYnk6IERhbiBDYXJw ZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPj4+PiBDYzogRGF2ZSBHb3Jkb24gPGRh dmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBNaWNoZWwgVGhpZXJy eSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgNCArKy0tCj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+Pj4+IGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmMKPj4+PiBpbmRleCA2ZmFlNmJkLi42ZDg5NGZjIDEwMDY0NAo+ Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPj4+PiBAQCAtNzU2LDggKzc1Niw4 IEBAIHN0YXRpYyBpbnQKPj4+PiBnZW44X3BwZ3R0X2FsbG9jX3BhZ2VfZGlyZWN0b3JpZXMoc3Ry dWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0LAo+Pj4+Cj4+Pj4gICAgICAgIFdBUk5fT04oIWJpdG1h cF9lbXB0eShuZXdfcGRzLCBHRU44X0xFR0FDWV9QRFBFUykpOwo+Pj4+Cj4+Pj4gLSAgICAvKiBG SVhNRTogUFBHVFQgY29udGFpbmVyX29mIHdvbid0IHdvcmsgZm9yIDY0YiAqLwo+Pj4+IC0gICAg V0FSTl9PTigoc3RhcnQgKyBsZW5ndGgpID4gMHg4MDAwMDAwMDBVTEwpOwo+Pj4+ICsgICAgLyog RklYTUU6IHVwcGVyIGJvdW5kIG11c3Qgbm90IG92ZXJmbG93IDMxIGJpdHMgICovCj4+Pj4gKyAg ICBXQVJOX09OKChzdGFydCArIGxlbmd0aCkgJiAofjBVTEwgPDwgMzEpKTsKPj4+Cj4+PiBXaHkg aXMgaXQgMzEgYW5kIG5vdCAzMj8KPj4KPj4gUmlnaHQsIHRoZSBjaGVjayByZWFsbHkgc2hvdWxk IGJlIChzdGFydCArIGxlbmd0aCkgPj0gMHgxMDAwMDAwMDBVTEwuCj4KPiBTb21ldGhpbmcgd2l0 aCAnMzInIGluIGl0IG1pZ2h0IGJlIG1vcmUgb2J2aW91cyBhbmQgc2F2ZSBhbnlvbmUgaGF2aW5n Cj4gdG8gY291bnQgdGhlIHplcm9lcyAuLi4gYW5kIGEgY29tbWVudCB0aGF0IGFsc28gbWVudGlv bmVkIHRoZSBsaW1pdDoKPgo+IAkvKiBGSVhNRTogZm9yIG5vdywgdXBwZXIgYm91bmQgbXVzdCBm aXQgaW4gMzIgYml0cyAgKi8KPgo+IAlXQVJOX09OKChzdGFydCArIGxlbmd0aCkgPj0gKDFVTEwg PDwgMzIpKQo+IAlXQVJOX09OKChzdGFydCArIGxlbmd0aCkgJiAofjBVTEwgPDwgMzIpKQo+IAlX QVJOX09OKChzdGFydCArIGxlbmd0aCkgPj4gMzIpICE9IDApCgpZZXMsIEkgd2FzIHBsYW5uaW5n IHRvIGp1c3QgcmVwbGFjZSBfMzFfIHdpdGggXzMyXyBhbmQgYXZvaWQgYWxsIHRob3NlIAp6ZXJv ZXMuLi4KCj4KPiAuRGF2ZS4KPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=