From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sivakumar Thulasimani Subject: Re: [PATCH 2/2] drm/i915/audio: do not mess with audio registers if port is invalid Date: Tue, 05 May 2015 11:03:28 +0530 Message-ID: <55485628.7070009@intel.com> References: <1430749249-15565-1-git-send-email-jani.nikula@intel.com> <1430749249-15565-2-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CEB26E1A5 for ; Mon, 4 May 2015 22:33:32 -0700 (PDT) In-Reply-To: <1430749249-15565-2-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UmV2aWV3ZWQtYnk6IFNpdmFrdW1hciBUaHVsYXNpbWFuaSA8c2l2YWt1bWFyLnRodWxhc2ltYW5p QGludGVsLmNvbT4KCk9uIDUvNC8yMDE1IDc6NTAgUE0sIEphbmkgTmlrdWxhIHdyb3RlOgo+IFdl IHNob3VsZCBubyBsb25nZXIgZW50ZXIgdGhlIGNvZGVjIGVuYWJsZS9kaXNhYmxlIGZ1bmN0aW9u cyBpbiBxdWVzdGlvbgo+IHdpdGggcG9ydCBBIGFueXdheSwgYnV0IHRvIGVyciBvbiB0aGUgc2Fm ZSBzaWRlLCBrZWVwIHRoZSB3YXJuaW5ncy4gSnVzdAo+IGJhaWwgb3V0IGVhcmx5IHdpdGhvdXQg bWVzc2luZyB3aXRoIHRoZSByZWdpc3RlcnMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3Vs YSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfYXVkaW8uYyB8IDIwICsrKysrKysrLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgOCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXVkaW8uYwo+IGluZGV4IGY3MmU5M2E0NWUxMS4uYzQzMTIxNzdiMGVlIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jCj4gQEAgLTI2OSw2ICsyNjksOSBAQCBzdGF0aWMgdm9p ZCBpbGtfYXVkaW9fY29kZWNfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikK PiAgIAlEUk1fREVCVUdfS01TKCJEaXNhYmxlIGF1ZGlvIGNvZGVjIG9uIHBvcnQgJWMsIHBpcGUg JWNcbiIsCj4gICAJCSAgICAgIHBvcnRfbmFtZShwb3J0KSwgcGlwZV9uYW1lKHBpcGUpKTsKPiAg IAo+ICsJaWYgKFdBUk5fT04ocG9ydCA9PSBQT1JUX0EpKQo+ICsJCXJldHVybjsKPiArCj4gICAJ aWYgKEhBU19QQ0hfSUJYKGRldl9wcml2LT5kZXYpKSB7Cj4gICAJCWF1ZF9jb25maWcgPSBJQlhf QVVEX0NGRyhwaXBlKTsKPiAgIAkJYXVkX2NudHJsX3N0MiA9IElCWF9BVURfQ05UTF9TVDI7Cj4g QEAgLTI5MCwxMiArMjkzLDcgQEAgc3RhdGljIHZvaWQgaWxrX2F1ZGlvX2NvZGVjX2Rpc2FibGUo c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gICAJCXRtcCB8PSBBVURfQ09ORklHX05f VkFMVUVfSU5ERVg7Cj4gICAJSTkxNV9XUklURShhdWRfY29uZmlnLCB0bXApOwo+ICAgCj4gLQlp ZiAoV0FSTl9PTighcG9ydCkpIHsKPiAtCQllbGR2ID0gSUJYX0VMRF9WQUxJRChQT1JUX0IpIHwg SUJYX0VMRF9WQUxJRChQT1JUX0MpIHwKPiAtCQkJSUJYX0VMRF9WQUxJRChQT1JUX0QpOwo+IC0J fSBlbHNlIHsKPiAtCQllbGR2ID0gSUJYX0VMRF9WQUxJRChwb3J0KTsKPiAtCX0KPiArCWVsZHYg PSBJQlhfRUxEX1ZBTElEKHBvcnQpOwo+ICAgCj4gICAJLyogSW52YWxpZGF0ZSBFTEQgKi8KPiAg IAl0bXAgPSBJOTE1X1JFQUQoYXVkX2NudHJsX3N0Mik7Cj4gQEAgLTMyNSw2ICszMjMsOSBAQCBz dGF0aWMgdm9pZCBpbGtfYXVkaW9fY29kZWNfZW5hYmxlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IsCj4gICAJRFJNX0RFQlVHX0tNUygiRW5hYmxlIGF1ZGlvIGNvZGVjIG9uIHBvcnQg JWMsIHBpcGUgJWMsICV1IGJ5dGVzIEVMRFxuIiwKPiAgIAkJICAgICAgcG9ydF9uYW1lKHBvcnQp LCBwaXBlX25hbWUocGlwZSksIGRybV9lbGRfc2l6ZShlbGQpKTsKPiAgIAo+ICsJaWYgKFdBUk5f T04ocG9ydCA9PSBQT1JUX0EpKQo+ICsJCXJldHVybjsKPiArCj4gICAJLyoKPiAgIAkgKiBGSVhN RTogV2UncmUgc3VwcG9zZWQgdG8gd2FpdCBmb3IgdmJsYW5rIGhlcmUsIGJ1dCB3ZSBoYXZlIHZi bGFua3MKPiAgIAkgKiBkaXNhYmxlZCBkdXJpbmcgdGhlIG1vZGUgc2V0LiBUaGUgcHJvcGVyIGZp eCB3b3VsZCBiZSB0byBwdXNoIHRoZQo+IEBAIC0zNDksMTIgKzM1MCw3IEBAIHN0YXRpYyB2b2lk IGlsa19hdWRpb19jb2RlY19lbmFibGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwK PiAgIAkJYXVkX2NudHJsX3N0MiA9IENQVF9BVURfQ05UUkxfU1QyOwo+ICAgCX0KPiAgIAo+IC0J aWYgKFdBUk5fT04oIXBvcnQpKSB7Cj4gLQkJZWxkdiA9IElCWF9FTERfVkFMSUQoUE9SVF9CKSB8 IElCWF9FTERfVkFMSUQoUE9SVF9DKSB8Cj4gLQkJCUlCWF9FTERfVkFMSUQoUE9SVF9EKTsKPiAt CX0gZWxzZSB7Cj4gLQkJZWxkdiA9IElCWF9FTERfVkFMSUQocG9ydCk7Cj4gLQl9Cj4gKwllbGR2 ID0gSUJYX0VMRF9WQUxJRChwb3J0KTsKPiAgIAo+ICAgCS8qIEludmFsaWRhdGUgRUxEICovCj4g ICAJdG1wID0gSTkxNV9SRUFEKGF1ZF9jbnRybF9zdDIpOwoKLS0gCnJlZ2FyZHMsClNpdmFrdW1h cgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK