From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 5/5] drm/i915: Use partial view in mmap fault handler Date: Tue, 05 May 2015 10:07:44 +0100 Message-ID: <55488860.7040101@linux.intel.com> References: <1430392887.1189.10.camel@jlahtine-mobl1> <5542423B.1060909@linux.intel.com> <1430740262.3724.1.camel@jlahtine-mobl1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A00546E280 for ; Tue, 5 May 2015 02:07:46 -0700 (PDT) In-Reply-To: <1430740262.3724.1.camel@jlahtine-mobl1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA1LzA0LzIwMTUgMTI6NTEgUE0sIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKPiBPbiB0bywg MjAxNS0wNC0zMCBhdCAxNTo1NCArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IE9uIDA0 LzMwLzIwMTUgMTI6MjEgUE0sIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKPj4+Cj4+PiBVc2UgcGFy dGlhbCB2aWV3IGZvciBodWdlIEJPcyAoYmlnZ2VyIHRoYW4gdGhlIG1hcHBhYmxlIGFwZXJ0dXJl KQo+Pj4gaW4gZmF1bHQgaGFuZGxlciBzbyB0aGF0IHRoZXkgY2FuIGJlIGFjY2Vzc2VkIHdpdGhv dXQgdHJ5aW5nIHRvIG1ha2UKPj4+IHJvb20gZm9yIHRoZW0gYnkgZXZpY3Rpbmcgb3RoZXIgb2Jq ZWN0cy4KPj4+Cj4+PiB2MjoKPj4+IC0gT25seSB1c2UgcGFydGlhbCB2aWV3cyBpbiB0aGUgY2Fz ZSB3aGVyZSBlYXJseSByZWplY3Rpb24gd2FzCj4+PiAgICAgcHJldmlvdXNseSBkb25lLgo+Pj4g LSBBY2NvdW50IHZhcmlhYmxlIHR5cGUgY2hhbmdlcyBmcm9tIHByZXZpb3VzIHJlcm9sbC4KPj4+ Cj4+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5j b20+Cj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCA2OSAr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+Pj4gICAgMSBmaWxlIGNo YW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+Pj4gaW5kZXggYTAyMDgzNi4uMmYzZmEwYiAxMDA2NDQKPj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPj4+IEBAIC0xNjM1LDYgKzE2MzUsNyBAQCBpbnQgaTkxNV9nZW1f ZmF1bHQoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+ Pj4gICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSB0b19pbnRlbF9ibyh2bWEt PnZtX3ByaXZhdGVfZGF0YSk7Cj4+PiAgICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IG9iai0+ YmFzZS5kZXY7Cj4+PiAgICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2 LT5kZXZfcHJpdmF0ZTsKPj4+ICsJc3RydWN0IGk5MTVfZ2d0dF92aWV3IHZpZXcgPSBpOTE1X2dn dHRfdmlld19ub3JtYWw7Cj4+PiAgICAJcGdvZmZfdCBwYWdlX29mZnNldDsKPj4+ICAgIAl1bnNp Z25lZCBsb25nIHBmbjsKPj4+ICAgIAlpbnQgcmV0ID0gMDsKPj4+IEBAIC0xNjY3LDggKzE2Njgs MjEgQEAgaW50IGk5MTVfZ2VtX2ZhdWx0KHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hLCBzdHJ1 Y3Qgdm1fZmF1bHQgKnZtZikKPj4+ICAgIAkJZ290byB1bmxvY2s7Cj4+PiAgICAJfQo+Pj4KPj4+ IC0JLyogTm93IGJpbmQgaXQgaW50byB0aGUgR1RUIGlmIG5lZWRlZCAqLwo+Pj4gLQlyZXQgPSBp OTE1X2dlbV9vYmpfZ2d0dF9waW4ob2JqLCAwLCBQSU5fTUFQUEFCTEUpOwo+Pj4gKwkvKiBVc2Ug YSBwYXJ0aWFsIHZpZXcgaWYgdGhlIG9iamVjdCBpcyBiaWdnZXIgdGhhbiB0aGUgYXBlcnR1cmUu ICovCj4+PiArCWlmIChvYmotPmJhc2Uuc2l6ZSA+PSBkZXZfcHJpdi0+Z3R0Lm1hcHBhYmxlX2Vu ZCkgewo+Pj4gKwkJc3RhdGljIGNvbnN0IHVuc2lnbmVkIGludCBjaHVua19zaXplID0gMjU2OyAv LyAxIE1pQgo+Pj4gKwkJbWVtc2V0KCZ2aWV3LCAwLCBzaXplb2YodmlldykpOwo+Pj4gKwkJdmll dy50eXBlID0gSTkxNV9HR1RUX1ZJRVdfUEFSVElBTDsKPj4+ICsJCXZpZXcucGFyYW1zLnBhcnRp YWwub2Zmc2V0ID0gcm91bmRkb3duKHBhZ2Vfb2Zmc2V0LCBjaHVua19zaXplKTsKPj4+ICsJCXZp ZXcucGFyYW1zLnBhcnRpYWwuc2l6ZSA9Cj4+PiArCQkJbWluX3QodW5zaWduZWQgaW50LAo+Pj4g KwkJCSAgICAgIGNodW5rX3NpemUsCj4+PiArCQkJICAgICAgKHZtYS0+dm1fZW5kIC0gdm1hLT52 bV9zdGFydCkvUEFHRV9TSVpFIC0KPj4+ICsJCQkgICAgICB2aWV3LnBhcmFtcy5wYXJ0aWFsLm9m ZnNldCk7Cj4+PiArCX0KPj4+ICsKPj4+ICsJLyogTm93IHBpbiBpdCBpbnRvIHRoZSBHVFQgaWYg bmVlZGVkICovCj4+PiArCXJldCA9IGk5MTVfZ2VtX29iamVjdF9nZ3R0X3BpbihvYmosICZ2aWV3 LCAwLCBQSU5fTUFQUEFCTEUpOwo+Pj4gICAgCWlmIChyZXQpCj4+PiAgICAJCWdvdG8gdW5sb2Nr Owo+Pj4KPj4+IEBAIC0xNjgxLDMwICsxNjk1LDQ0IEBAIGludCBpOTE1X2dlbV9mYXVsdChzdHJ1 Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgc3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4+PiAgICAJCWdv dG8gdW5waW47Cj4+Pgo+Pj4gICAgCS8qIEZpbmFsbHksIHJlbWFwIGl0IHVzaW5nIHRoZSBuZXcg R1RUIG9mZnNldCAqLwo+Pj4gLQlwZm4gPSBkZXZfcHJpdi0+Z3R0Lm1hcHBhYmxlX2Jhc2UgKyBp OTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQob2JqKTsKPj4+ICsJcGZuID0gZGV2X3ByaXYtPmd0dC5t YXBwYWJsZV9iYXNlICsKPj4+ICsJCWk5MTVfZ2VtX29ial9nZ3R0X29mZnNldF92aWV3KG9iaiwg JnZpZXcpOwo+Pj4gICAgCXBmbiA+Pj0gUEFHRV9TSElGVDsKPj4+Cj4+PiAtCWlmICghb2JqLT5m YXVsdF9tYXBwYWJsZSkgewo+Pj4gLQkJdW5zaWduZWQgbG9uZyBzaXplID0gbWluX3QodW5zaWdu ZWQgbG9uZywKPj4+IC0JCQkJCSAgIHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCwKPj4+IC0J CQkJCSAgIG9iai0+YmFzZS5zaXplKTsKPj4+IC0JCWludCBpOwo+Pj4gKwlpZiAodW5saWtlbHko dmlldy50eXBlID09IEk5MTVfR0dUVF9WSUVXX1BBUlRJQUwpKSB7Cj4+PiArCQl1bnNpZ25lZCBs b25nIGJhc2UgPSB2bWEtPnZtX3N0YXJ0ICsKPj4+ICsJCQkodmlldy5wYXJhbXMucGFydGlhbC5v ZmZzZXQgPDwgUEFHRV9TSElGVCk7Cj4+PiArCQl1bnNpZ25lZCBpbnQgaTsKPj4+Cj4+PiAtCQlm b3IgKGkgPSAwOyBpIDwgc2l6ZSA+PiBQQUdFX1NISUZUOyBpKyspIHsKPj4+IC0JCQlyZXQgPSB2 bV9pbnNlcnRfcGZuKHZtYSwKPj4+IC0JCQkJCSAgICAodW5zaWduZWQgbG9uZyl2bWEtPnZtX3N0 YXJ0ICsgaSAqIFBBR0VfU0laRSwKPj4+IC0JCQkJCSAgICBwZm4gKyBpKTsKPj4+ICsJCWZvciAo aSA9IDA7IGkgPCB2aWV3LnBhcmFtcy5wYXJ0aWFsLnNpemU7IGkrKykgewo+Pj4gKwkJCXJldCA9 IHZtX2luc2VydF9wZm4odm1hLCBiYXNlICsgaSAqIFBBR0VfU0laRSwgcGZuICsgaSk7Cj4+PiAg ICAJCQlpZiAocmV0KQo+Pj4gICAgCQkJCWJyZWFrOwo+Pj4gICAgCQl9Cj4+PiAtCj4+PiAgICAJ CW9iai0+ZmF1bHRfbWFwcGFibGUgPSB0cnVlOwo+Pj4gLQl9IGVsc2UKPj4+IC0JCXJldCA9IHZt X2luc2VydF9wZm4odm1hLAo+Pj4gLQkJCQkgICAgKHVuc2lnbmVkIGxvbmcpdm1mLT52aXJ0dWFs X2FkZHJlc3MsCj4+PiAtCQkJCSAgICBwZm4gKyBwYWdlX29mZnNldCk7Cj4+Cj4+IElmIEkgcmVh ZCB0aGUgZGlmZiBjb3JyZWN0bHkgeW91IGRvbid0IGhhdmUgZXF1aXZhbGVudCBoYW5kbGluZyAo YXMgdGhlCj4+IG5vcm1hbCB2aWV3KSBmb3Igd2hlbiB0aGUgY2FzZSB3aGVuIHRoZSBwcmUtZmF1 bHQgZmFpbHMgc29tZXdoZXJlIGluIHRoZQo+PiBtaWRkbGU/Cj4+Cj4KPiBUcnVlIHNvLCB0aGUg ZmxhZyBmYXVsdF9tYXBwYWJsZSBpcyB1c2VkIGZvciB0aGUgbm9ybWFsIHZpZXcgdG8gdHJhY2sK PiB3aGV0aGVyIGFsbCBwYWdlcyB3ZXJlIGluc2VydGVkIGFuZCBpdCBtYWtlcyBzZW5zZSB0byBq dXN0IGluc2VydCB0aGUKPiBmYXVsdGVkIG9uZS4gSSBqdXN0IGRpZG4ndCB3YW50IHRvIGFkZCBh bm90aGVyIGZsYWcgdG8gdHJhY2sgdGhlIHNhbWUKPiBmb3IgZWFjaCB2bWEuCgpCdXQgaXQgaXMg c2FmZSB0byBkbyBpdCBtdWx0aXBsZSB0aW1lcz8KCkVpdGhlciB3YXkgSSB3b3VsZCBwdXQgYSBj b21tZW50IGluIGV4cGxhaW5pbmcgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiAKY29kZSBwYXRocy4K ClJlZ2FyZHMsCgpUdnJ0a28KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK