Re: [PATCH v3 3/4] drm/i915: Add a partial GGTT view type

Daniel Vetter
2015-05-07T16:15:07Z

On Wed, May 06, 2015 at 01:24:18PM +0100, Tvrtko Ursulin wrote:
>
>
> On 05/06/2015 12:35 PM, Joonas Lahtinen wrote:
> >
> >Partial view type allows manipulating parts of huge BOs through the GGTT,
> >which was not previously possible due to constraint that whole object had
> >to be mapped for any access to it through GGTT.
> >
> >v2:
> >- Retain error value from sg_alloc_table (Tvrtko Ursulin)
> >- Do not zero already zeroed variable (Tvrtko Ursulin)
> >- Use more common variable types for page size/offset (Tvrtko Ursulin)
> >v3:
> >- Only compare additional view parameters when need to (Tvrtko Ursulin)
> >v4:
> >- Do zero out the variable that needs to be (bug introduced in v2).
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Pulled in entire series, thanks. Imo we have now an even bigger chaos
between i915_gem.c and i915_gem_gtt.c around vma handling. But as
discussed this is something we can clean up once the dust has settled a
bit I think. I guess we could extract an i915_gem_vma.c for all this code,
leaving only low-level gtt handling to i915_gem_gtt.c.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation