Re: [PATCH v3 2/4] drm/i915: Consider object pinned if any VMA is pinned

Tvrtko Ursulin
2015-05-06T12:45:09Z

On 05/06/2015 12:34 PM, Joonas Lahtinen wrote:
> Do not skip special GGTT views when considering whether an object
> is pinned or not.
>
> Wrong behaviour was introduced in;
>
> commit ec7adb6ee79c8c9fe64d63ad638a31cd62e55515
> Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Date: Mon Mar 16 14:11:13 2015 +0200
>
> drm/i915: Do not use ggtt_view with (aliasing) PPGTT
>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)

Callers are inconsistent with what they want to know when calling this
function which needs some follow-up work, but this is I think better in
the short term.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko