From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/4] drm/i915: Consider object pinned if any VMA is pinned
Date: Wed, 06 May 2015 13:44:54 +0100 [thread overview]
Message-ID: <554A0CC6.1010702@linux.intel.com> (raw)
In-Reply-To: <1430912098.9311.5.camel@jlahtine-mobl1>
On 05/06/2015 12:34 PM, Joonas Lahtinen wrote:
> Do not skip special GGTT views when considering whether an object
> is pinned or not.
>
> Wrong behaviour was introduced in;
>
> commit ec7adb6ee79c8c9fe64d63ad638a31cd62e55515
> Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Date: Mon Mar 16 14:11:13 2015 +0200
>
> drm/i915: Do not use ggtt_view with (aliasing) PPGTT
>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Callers are inconsistent with what they want to know when calling this
function which needs some follow-up work, but this is I think better in
the short term.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-06 12:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:18 [PATCH v2 0/5] Partial GGTT views Joonas Lahtinen
2015-05-06 11:33 ` [PATCH v3 1/4] drm/i915: Do not make assumptions on GGTT VMA sizes Joonas Lahtinen
2015-05-06 12:23 ` Tvrtko Ursulin
2015-05-06 11:34 ` [PATCH v3 2/4] drm/i915: Consider object pinned if any VMA is pinned Joonas Lahtinen
2015-05-06 12:44 ` Tvrtko Ursulin [this message]
2015-05-06 11:35 ` [PATCH v3 3/4] drm/i915: Add a partial GGTT view type Joonas Lahtinen
2015-05-06 12:24 ` Tvrtko Ursulin
2015-05-07 16:17 ` Daniel Vetter
2015-06-09 8:56 ` Chris Wilson
2015-06-10 10:38 ` Joonas Lahtinen
2015-06-10 10:56 ` Chris Wilson
2015-05-06 11:36 ` [PATCH v3 4/4] drm/i915: Use partial view in mmap fault handler Joonas Lahtinen
2015-05-06 12:33 ` Tvrtko Ursulin
2015-05-07 11:27 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A0CC6.1010702@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox