From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 i-g-t 1/4] igt_kms: Avoid NULL ptr deref when commiting disabled planes Date: Thu, 07 May 2015 10:00:40 +0100 Message-ID: <554B29B8.8020004@linux.intel.com> References: <1430819603-492-1-git-send-email-tvrtko.ursulin@linux.intel.com> <76A9B330A4D78C4D99CB292C4CC06C0E36FC745A@fmsmsx101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 7048F6E1F9 for ; Thu, 7 May 2015 02:00:43 -0700 (PDT) In-Reply-To: <76A9B330A4D78C4D99CB292C4CC06C0E36FC745A@fmsmsx101.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Konduru, Chandra" , "Intel-gfx@lists.freedesktop.org" Cc: "Wood, Thomas" List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA1LzA2LzIwMTUgMDk6NDcgUE0sIEtvbmR1cnUsIENoYW5kcmEgd3JvdGU6Cj4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IFR2cnRrbyBVcnN1bGluIFttYWlsdG86dHZy dGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tXQo+PiBTZW50OiBUdWVzZGF5LCBNYXkgMDUsIDIw MTUgMjo1MyBBTQo+PiBUbzogSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBDYzog VXJzdWxpbiwgVHZydGtvOyBLb25kdXJ1LCBDaGFuZHJhOyBXb29kLCBUaG9tYXMKPj4gU3ViamVj dDogW1BBVENIIHYyIGktZy10IDEvNF0gaWd0X2ttczogQXZvaWQgTlVMTCBwdHIgZGVyZWYgd2hl biBjb21taXRpbmcKPj4gZGlzYWJsZWQgcGxhbmVzCj4+Cj4+IEZyb206IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEkgdGhpbms7Cj4+Cj4+ICAgICBjb21t aXQgYTI2ZjlmOWFkMGU2NzljN2NlNDEzYTI1ZDM0ZjY5MTRlMTE3NDE1MQo+PiAgICAgQXV0aG9y OiBjaGFuZHJhIGtvbmR1cnUgPGNoYW5kcmEua29uZHVydUBpbnRlbC5jb20+Cj4+ICAgICBEYXRl OiAgIE1vbiBNYXIgMzAgMTM6NTI6MDQgMjAxNSAtMDcwMAo+Pgo+PiAgICAgICAgIGktZy10OiBB ZGRpbmcgcGxhbmUgc2NhbGluZyB0ZXN0IGNhc2UKPj4KPj4gaW50cm9kdWNlZCBhIGNvbmRpdGlv biB3aGVyZSBpdCBhdHRlbXB0cyB0byB1cGRhdGUgYSBkaXNhYmxlZCBwbGFuZSBiZWNhdXNlIG9m Cj4+IHRoZSBuZXdseSBpbnRyb2R1Y2VkIHNpemVfY2hhbmdlZCBmbGFnIHdoaWNoIGlzIHNldCBm b3IgZGlzYWJsZWQgZnJhbWUgYnVmZmVycy4KPj4gUmVzdWx0IGlzIGEgTlVMTCBwdHIgZGVyZWYg aW4gaWd0X2RybV9wbGFuZV9jb21taXQgKHBsYW5lLT5mYi0+c3JjX3gpLgo+Pgo+PiBTdGFydCBy ZWNvZ25pc2luZyB0aGlzIGNhc2UgYXMgZGlzYWJsZWQgcGxhbmUgYW5kIGFjdCBhY2NvcmRpbmds eS4KPj4KPj4gdjI6IFNwbGl0IG91dCBpZ3RfcGxhbmVfc2V0X2ZiIGNsZWFudXAuIChUaG9tYXMg V29vZCkKPj4KPj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPj4gQ2M6IGNoYW5kcmEga29uZHVydSA8Y2hhbmRyYS5rb25kdXJ1QGludGVs LmNvbT4KPj4gQ2M6IFRob21hcyBXb29kIDx0aG9tYXMud29vZEBpbnRlbC5jb20+Cj4+IC0tLQo+ PiBUaGVyZSBtaWdodCBiZSBhIGJldHRlciBmaXgsIGJ1dCB0aGlzIHdvcmtzIGZvciBtZS4KPj4g LS0tCj4+ICAgbGliL2lndF9rbXMuYyB8IDIgKy0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmMg Yi9saWIvaWd0X2ttcy5jIGluZGV4IGI3ZDFlOTAuLjMzZDQzN2QgMTAwNjQ0Cj4+IC0tLSBhL2xp Yi9pZ3Rfa21zLmMKPj4gKysrIGIvbGliL2lndF9rbXMuYwo+PiBAQCAtMTMzMSw3ICsxMzMxLDcg QEAgc3RhdGljIGludCBpZ3RfZHJtX3BsYW5lX2NvbW1pdChpZ3RfcGxhbmVfdCAqcGxhbmUsCj4+ ICAgCWZiX2lkID0gaWd0X3BsYW5lX2dldF9mYl9pZChwbGFuZSk7Cj4+ICAgCWNydGNfaWQgPSBv dXRwdXQtPmNvbmZpZy5jcnRjLT5jcnRjX2lkOwo+Pgo+PiAtCWlmIChwbGFuZS0+ZmJfY2hhbmdl ZCAmJiBmYl9pZCA9PSAwKSB7Cj4+ICsJaWYgKChwbGFuZS0+ZmJfY2hhbmdlZCB8fCBwbGFuZS0+ c2l6ZV9jaGFuZ2VkKSAmJiBmYl9pZCA9PSAwKSB7Cj4KPiBTaG91bGRuJ3QgdGhpcyBpbmNsdWRl IHBsYW5lLT5wb3NpdGlvbl9jaGFuZ2VkIHRvbz8gTGlrZToKPiAJaWYgKChwbGFuZS0+ZmJfY2hh bmdlZCB8fCBwbGFuZS0+c2l6ZV9jaGFuZ2VkIHx8IHBsYW5lLT5wb3NpdGlvbl9jaGFuZ2VkKSAm JiBmYl9pZCA9PSAwKSB7CgpXaGVuIHlvdSBhZGRlZCBzaXplX2NoYW5nZWQsIHN0YXRlIGZvciBw b3NpdGlvbl9jaGFuZ2VkIGFuZCBmYiA9PSBOVUxMIApyZW1haW5lZCB0aGUgc2FtZSwgd2hpbGUg c2l6ZV9jaGFuZ2VkIGFkZGVkIG5ldyBzdGF0ZSBmb3Igc2l6ZV9jaGFuZ2VkIAo9PSB0cnVlIGFu ZCBmYiA9PSBOVUxMLiBTbyBJIGFkZGVkIGhhbmRsaW5nIGZvciB0aGF0IGFuZCBkaWQgbm90IHRo aW5rIAptdWNoIGJleW9uZCBpdC4gSXQgZml4ZXMgYSBzZWdmYXVsdCBzbyBJIG1vdmVkIG9uLiBP ciBpbiBvdGhlciB3b3JkcywgSSAKZG9uJ3Qgc2VlIGhvdyBpdCB3b3VsZCBoYXJtIHRvIG1lcmdl IHRoaXMsIGl0IGRvZXNuJ3QgbWFrZSBhbnl0aGluZyB3b3JzZS4KClJlZ2FyZHMsCgpUdnJ0a28K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK