Re: [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb

Konduru, Chandra
2015-05-06T19:02:14Z

> diff --git a/lib/igt_kms.c b/lib/igt_kms.c index b5ba273..0665d70 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1765,9 +1765,7 @@ void igt_plane_set_fb(igt_plane_t *plane, struct
> igt_fb *fb)
> plane->fb = fb;
> /* hack to keep tests working that don't call igt_plane_set_size() */
> if (fb) {
> - /* set default plane pos/size as fb size */
> - plane->crtc_x = 0;
> - plane->crtc_y = 0;
Reason for doing this is to make existing kms tests to run without modification.
Otherwise every existing test has to explicitly call igt_plane_set_position to make
sure it works. Can you make sure removing above 2 lines doesn't break existing tests?

By the way, instead of this, did you look at the option of changing kms_rotation_crc
to set plane position to whatever required when fb is changed.